Skip to content
This repository was archived by the owner on Jan 24, 2020. It is now read-only.

Commit c0188d5

Browse files
committed
Fix return type on ios
1 parent e5d9f84 commit c0188d5

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

RNCookieManagerIOS/RNCookieManagerIOS.m

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,32 +29,30 @@ @implementation RNCookieManagerIOS
2929
NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieProperties];
3030
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
3131

32-
callback(@[[NSNull null], @"success"]);
32+
callback(@[[NSNull null]]);
3333
}
3434

3535
RCT_EXPORT_METHOD(setFromResponse:(NSURL *)url value:(NSDictionary *)value callback:(RCTResponseSenderBlock)callback) {
3636
NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:value forURL:url];
3737
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookies:cookies forURL:url mainDocumentURL:NULL];
38-
callback(@[[NSNull null], @"success"]);
38+
callback(@[[NSNull null]]);
3939
}
4040

4141

4242
RCT_EXPORT_METHOD(get:(NSURL *)url callback:(RCTResponseSenderBlock)callback) {
43-
NSArray *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:url];
44-
NSDictionary *headers = [NSHTTPCookie requestHeaderFieldsWithCookies:cookies];
45-
if ([headers objectForKey:@"Cookie"] == nil) {
46-
callback(@[[NSNull null], @"success"]);
47-
} else {
48-
callback(@[headers[@"Cookie"], @"success"]);
43+
NSMutableDictionary *cookies = [NSMutableDictionary dictionary];
44+
for (NSHTTPCookie *c in [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:url]) {
45+
[cookies setObject:c.value forKey:c.name];
4946
}
47+
callback(@[[NSNull null], cookies]);
5048
}
5149

5250
RCT_EXPORT_METHOD(clearAll:(RCTResponseSenderBlock)callback) {
5351
NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
5452
for (NSHTTPCookie *c in cookieStorage.cookies) {
5553
[cookieStorage deleteCookie:c];
5654
}
57-
callback(@[[NSNull null], @"success"]);
55+
callback(@[[NSNull null]]);
5856
}
5957

6058
// TODO: return a better formatted list of cookies per domain
@@ -69,7 +67,7 @@ @implementation RNCookieManagerIOS
6967
[d setObject:c.path forKey:@"path"];
7068
[cookies setObject:d forKey:c.name];
7169
}
72-
callback(@[cookies, @"success"]);
70+
callback(@[[NSNull null], cookies]);
7371
}
7472

7573
@end

0 commit comments

Comments
 (0)