Merge pull request facebookarchive#820 from yguedidi/prefer_lowest

Add prefer lowest dependencies builds

Author: SammyK

.travis.yml

@@ -1,5 +1,7 @@
 language: php
 
+dist: trusty
+
 sudo: false
 
 cache:
@@ -9,17 +11,19 @@ cache:
 matrix:
   include:
     - php: 7.1
+    - php: 7.1
+      env:
+        - deps=low
+    - php: nightly
     - php: nightly
+      env:
+        - deps=low
     - php: hhvm
-      dist: trusty
     - php: hhvm-nightly
-      dist: trusty
   # Allow failures until Travis build includes HHVM 3.20.2 which fix the issue with composer (see http://hhvm.com/blog/2017/06/07/hhvm-3-20.html)
   allow_failures:
     - php: hhvm
-      dist: trusty
     - php: hhvm-nightly
-      dist: trusty
   fast_finish: true
 
 before_install:
@@ -28,7 +32,8 @@ before_install:
 
 install:
   - travis_retry composer require --dev --no-update squizlabs/php_codesniffer
-  - travis_retry composer install --prefer-dist --no-interaction
+  - if [ $deps != low ]; then travis_retry composer update --no-interaction --prefer-dist; fi;
+  - if [ $deps == low ]; then travis_retry composer update --no-interaction --prefer-dist --prefer-lowest; fi;
 
 script:
   - vendor/bin/phpcs

composer.json

@@ -18,9 +18,8 @@
         "php": "^7.1"
     },
     "require-dev": {
-        "guzzlehttp/guzzle": "~5.0",
-        "mockery/mockery": "~0.8",
-        "phpunit/phpunit": "^5.7.5"
+        "guzzlehttp/guzzle": "^5.3.1",
+        "phpunit/phpunit": "^6.2"
     },
     "suggest": {
         "guzzlehttp/guzzle": "Allows for implementation of the Guzzle HTTP client"

phpunit.xml.dist

@@ -16,7 +16,4 @@
             <directory suffix=".php">./src/Facebook</directory>
         </whitelist>
     </filter>
-    <listeners>
-        <listener class="\Mockery\Adapter\Phpunit\TestListener"/>
-    </listeners>
 </phpunit>

src/HttpClients/FacebookCurlHttpClient.php

@@ -70,6 +70,8 @@ public function send($url, $method, $body, array $headers, $timeOut)
         $this->sendRequest();
 
         if ($curlErrorCode = $this->facebookCurl->errno()) {
+            $this->closeConnection();
+
             throw new FacebookSDKException($this->facebookCurl->error(), $curlErrorCode);
         }
 

tests/Authentication/AccessTokenMetadataTest.php

@@ -24,8 +24,9 @@
 namespace Facebook\Tests\Authentication;
 
 use Facebook\Authentication\AccessTokenMetadata;
+use PHPUnit\Framework\TestCase;
 
-class AccessTokenMetadataTest extends \PHPUnit_Framework_TestCase
+class AccessTokenMetadataTest extends TestCase
 {
 
     protected $graphResponseData = [
@@ -93,6 +94,8 @@ public function testAnExpectedAppIdWillNotThrow()
     {
         $metadata = new AccessTokenMetadata($this->graphResponseData);
         $metadata->validateAppId('123');
+
+        $this->assertTrue(true);
     }
 
     /**
@@ -102,12 +105,16 @@ public function testAnUnexpectedAppIdWillThrow()
     {
         $metadata = new AccessTokenMetadata($this->graphResponseData);
         $metadata->validateAppId('foo');
+
+        $this->assertTrue(true);
     }
 
     public function testAnExpectedUserIdWillNotThrow()
     {
         $metadata = new AccessTokenMetadata($this->graphResponseData);
         $metadata->validateUserId('1337');
+
+        $this->assertTrue(true);
     }
 
     /**
@@ -124,6 +131,8 @@ public function testAnActiveAccessTokenWillNotThrow()
         $this->graphResponseData['data']['expires_at'] = time() + 1000;
         $metadata = new AccessTokenMetadata($this->graphResponseData);
         $metadata->validateExpiration();
+
+        $this->assertTrue(true);
     }
 
     /**

tests/Authentication/AccessTokenTest.php

@@ -24,8 +24,9 @@
 namespace Facebook\Tests\Authentication;
 
 use Facebook\Authentication\AccessToken;
+use PHPUnit\Framework\TestCase;
 
-class AccessTokenTest extends \PHPUnit_Framework_TestCase
+class AccessTokenTest extends TestCase
 {
 
     public function testAnAccessTokenCanBeReturnedAsAString()

tests/Authentication/OAuth2ClientTest.php

@@ -28,8 +28,9 @@
 use Facebook\Authentication\OAuth2Client;
 use Facebook\Authentication\AccessTokenMetadata;
 use Facebook\Authentication\AccessToken;
+use PHPUnit\Framework\TestCase;
 
-class OAuth2ClientTest extends \PHPUnit_Framework_TestCase
+class OAuth2ClientTest extends TestCase
 {
 
     /**

tests/Exceptions/FacebookResponseExceptionTest.php

@@ -33,8 +33,9 @@
 use Facebook\Exceptions\FacebookAuthorizationException;
 use Facebook\Exceptions\FacebookClientException;
 use Facebook\Exceptions\FacebookOtherException;
+use PHPUnit\Framework\TestCase;
 
-class FacebookResponseExceptionTest extends \PHPUnit_Framework_TestCase
+class FacebookResponseExceptionTest extends TestCase
 {
 
     /**

tests/FacebookAppTest.php

@@ -25,8 +25,9 @@
 
 use Facebook\FacebookApp;
 use Facebook\Authentication\AccessToken;
+use PHPUnit\Framework\TestCase;
 
-class FacebookAppTest extends \PHPUnit_Framework_TestCase
+class FacebookAppTest extends TestCase
 {
     /**
      * @var FacebookApp

tests/FacebookBatchRequestTest.php

@@ -27,8 +27,9 @@
 use Facebook\FacebookRequest;
 use Facebook\FacebookBatchRequest;
 use Facebook\FileUpload\FacebookFile;
+use PHPUnit\Framework\TestCase;
 
-class FacebookBatchRequestTest extends \PHPUnit_Framework_TestCase
+class FacebookBatchRequestTest extends TestCase
 {
     /**
      * @var FacebookApp
@@ -196,6 +197,8 @@ public function testLessOrEqualThanFiftyRequestsWillNotThrow()
         $this->createAndAppendRequestsTo($batchRequest, 50);
 
         $batchRequest->validateBatchRequestCount();
+
+        $this->assertTrue(true);
     }
 
     /**