Skip to content

Commit 717acef

Browse files
authored
Merge pull request facebookarchive#814 from yguedidi/php7
Add HHVM build but allow to fail
2 parents 7417955 + 59faecb commit 717acef

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

.travis.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,27 @@ cache:
99
matrix:
1010
include:
1111
- php: 7.1
12+
- php: nightly
1213
- php: hhvm
1314
dist: trusty
15+
- php: hhvm-nightly
16+
dist: trusty
17+
# Allow failures until Travis build includes HHVM 3.20.2 which fix the issue with composer (see http://hhvm.com/blog/2017/06/07/hhvm-3-20.html)
18+
allow_failures:
19+
- php: hhvm
20+
dist: trusty
21+
- php: hhvm-nightly
22+
dist: trusty
23+
fast_finish: true
1424

1525
before_install:
26+
- if [[ $TRAVIS_PHP_VERSION = hhv* ]]; then echo hhvm.php7.all=1 >> /etc/hhvm/php.ini; fi
1627
- travis_retry composer self-update
1728

1829
install:
1930
- travis_retry composer require --dev --no-update squizlabs/php_codesniffer
2031
- travis_retry composer install --prefer-dist --no-interaction
2132

22-
before_script:
23-
- if [[ $TRAVIS_PHP_VERSION = hhvm ]]; then echo hhvm.php7.all=1 >> /etc/hhvm/php.ini; fi
24-
2533
script:
2634
- vendor/bin/phpcs
2735
- vendor/bin/phpunit --coverage-text --exclude-group integration

src/Facebook/FacebookBatchRequest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ class FacebookBatchRequest extends FacebookRequest implements IteratorAggregate,
3939
/**
4040
* @var array An array of FacebookRequest entities to send.
4141
*/
42-
protected $requests;
42+
protected $requests = [];
4343

4444
/**
4545
* @var array An array of files to upload.
4646
*/
47-
protected $attachedFiles;
47+
protected $attachedFiles = [];
4848

4949
/**
5050
* Creates a new Request entity.

0 commit comments

Comments
 (0)