Make isIso8601DateString private

Author: yguedidi

src/GraphNode/GraphNode.php

@@ -248,33 +248,6 @@ public function uncastFields()
         }, $fields);
     }
 
-    /**
-     * Detects an ISO 8601 formatted string.
-     *
-     * @param string $string
-     *
-     * @return bool
-     *
-     * @see https://developers.facebook.com/docs/graph-api/using-graph-api/#readmodifiers
-     * @see http://www.cl.cam.ac.uk/~mgk25/iso-time.html
-     * @see http://en.wikipedia.org/wiki/ISO_8601
-     */
-    public function isIso8601DateString($string)
-    {
-        // This insane regex was yoinked from here:
-        // http://www.pelagodesign.com/blog/2009/05/20/iso-8601-date-validation-that-doesnt-suck/
-        // ...and I'm all like:
-        // http://thecodinglove.com/post/95378251969/when-code-works-and-i-dont-know-why
-        $crazyInsaneRegexThatSomehowDetectsIso8601 = '/^([\+-]?\d{4}(?!\d{2}\b))'
-            . '((-?)((0[1-9]|1[0-2])(\3([12]\d|0[1-9]|3[01]))?'
-            . '|W([0-4]\d|5[0-2])(-?[1-7])?|(00[1-9]|0[1-9]\d'
-            . '|[12]\d{2}|3([0-5]\d|6[1-6])))([T\s]((([01]\d|2[0-3])'
-            . '((:?)[0-5]\d)?|24\:?00)([\.,]\d+(?!:))?)?(\17[0-5]\d'
-            . '([\.,]\d+)?)?([zZ]|([\+-])([01]\d|2[0-3]):?([0-5]\d)?)?)?)?$/';
-
-        return preg_match($crazyInsaneRegexThatSomehowDetectsIso8601, $string) === 1;
-    }
-
     /**
      * Casts a date value from Graph to DateTime.
      *
@@ -337,4 +310,31 @@ private function shouldCastAsDateTime($key)
             'publish_time'
         ], true);
     }
+
+    /**
+     * Detects an ISO 8601 formatted string.
+     *
+     * @param string $string
+     *
+     * @return bool
+     *
+     * @see https://developers.facebook.com/docs/graph-api/using-graph-api/#readmodifiers
+     * @see http://www.cl.cam.ac.uk/~mgk25/iso-time.html
+     * @see http://en.wikipedia.org/wiki/ISO_8601
+     */
+    private function isIso8601DateString($string)
+    {
+        // This insane regex was yoinked from here:
+        // http://www.pelagodesign.com/blog/2009/05/20/iso-8601-date-validation-that-doesnt-suck/
+        // ...and I'm all like:
+        // http://thecodinglove.com/post/95378251969/when-code-works-and-i-dont-know-why
+        $crazyInsaneRegexThatSomehowDetectsIso8601 = '/^([\+-]?\d{4}(?!\d{2}\b))'
+            . '((-?)((0[1-9]|1[0-2])(\3([12]\d|0[1-9]|3[01]))?'
+            . '|W([0-4]\d|5[0-2])(-?[1-7])?|(00[1-9]|0[1-9]\d'
+            . '|[12]\d{2}|3([0-5]\d|6[1-6])))([T\s]((([01]\d|2[0-3])'
+            . '((:?)[0-5]\d)?|24\:?00)([\.,]\d+(?!:))?)?(\17[0-5]\d'
+            . '([\.,]\d+)?)?([zZ]|([\+-])([01]\d|2[0-3]):?([0-5]\d)?)?)?)?$/';
+
+        return preg_match($crazyInsaneRegexThatSomehowDetectsIso8601, $string) === 1;
+    }
 }

tests/GraphNode/GraphNodeTest.php

@@ -66,29 +66,38 @@ public static function provideDateTimeFieldNames()
         yield ['publish_time'];
     }
 
-    public function testDatesThatShouldBeCastAsDateTimeObjectsAreDetected()
+    /**
+     * @dataProvider provideValidDateTimeFieldValues
+     */
+    public function testIsCastDateTimeFieldValueToDateTime($value, $message)
     {
-        $graphNode = new GraphNode();
+        $graphNode = new GraphNode(['created_time' => $value]);
 
-        // Should pass
-        $shouldPass = $graphNode->isIso8601DateString('1985-10-26T01:21:00+0000');
-        $this->assertTrue($shouldPass, 'Expected the valid ISO 8601 formatted date from Back To The Future to pass.');
-
-        $shouldPass = $graphNode->isIso8601DateString('1999-12-31');
-        $this->assertTrue($shouldPass, 'Expected the valid ISO 8601 formatted date to party like it\'s 1999.');
+        $this->assertInstanceOf(\DateTime::class, $graphNode->getField('created_time'), $message);
+    }
 
-        $shouldPass = $graphNode->isIso8601DateString('2009-05-19T14:39Z');
-        $this->assertTrue($shouldPass, 'Expected the valid ISO 8601 formatted date to pass.');
+    public static function provideValidDateTimeFieldValues()
+    {
+        yield ['1985-10-26T01:21:00+0000', 'Expected the valid ISO 8601 formatted date from Back To The Future to pass.'];
+        yield ['1999-12-31', 'Expected the valid ISO 8601 formatted date to party like it\'s 1999.'];
+        yield ['2009-05-19T14:39Z', 'Expected the valid ISO 8601 formatted date to pass.'];
+        yield ['2014-W36', 'Expected the valid ISO 8601 formatted date to pass.'];
+    }
 
-        $shouldPass = $graphNode->isIso8601DateString('2014-W36');
-        $this->assertTrue($shouldPass, 'Expected the valid ISO 8601 formatted date to pass.');
+    /**
+     * @dataProvider provideInvalidDateTimeFieldValues
+     */
+    public function testIsNotCastDateTimeFieldValueToDateTime($value, $message)
+    {
+        $graphNode = new GraphNode(['created_time' => $value]);
 
-        // Should fail
-        $shouldFail = $graphNode->isIso8601DateString('2009-05-19T14a39r');
-        $this->assertFalse($shouldFail, 'Expected the invalid ISO 8601 format to fail.');
+        $this->assertNotInstanceOf(\DateTime::class, $graphNode->getField('created_time'), $message);
+    }
 
-        $shouldFail = $graphNode->isIso8601DateString('foo_time');
-        $this->assertFalse($shouldFail, 'Expected the invalid ISO 8601 format to fail.');
+    public static function provideInvalidDateTimeFieldValues()
+    {
+        yield ['2009-05-19T14a39r', 'Expected the invalid ISO 8601 format to fail.'];
+        yield ['foo_time', 'Expected the invalid ISO 8601 format to fail.'];
     }
 
     public function testATimeStampCanBeConvertedToADateTimeObject()