chore: Version 2025.0.1 - Test & Verbiage Improvements (#126)

* test: Fix test mocks and remove console logs

* chore: Bump version to 2025.0.1 and update changelogs

* docs: Update CHANGELOG with TimeSlot pipe and UI improvements

* changes

---------

Co-authored-by: Joel Meaders <joelmeaders@outlook.com>

Author: joelmeaders

CHANGELOG.md

@@ -5,6 +5,33 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to a versioning scheme of `year.minor.patch`.
 
+## [2025.0.1] - 2025-11-09
+
+### Added
+- **TimeSlot Pipe**: New custom pipe for formatting appointment time slots (e.g., "10AM - 11AM")
+  - Displays start and end times for one-hour time slots
+  - Supports timezone parameter for proper time zone handling
+  - Includes comprehensive unit tests
+
+### Changed
+- **UI Improvements**: Updated time display formatting across registration flow
+  - Date/time selection page now uses TimeSlot pipe for consistent formatting
+  - Schedule card component uses TimeSlot pipe instead of raw date formatting
+  - Submit page displays time slots in user-friendly format
+- **Translations**: Updated infant toy messaging to be more inclusive
+  - English: Changed from "gender neutral toys" to "toys for children ages 0-2"
+  - Spanish: Updated to match new English messaging
+
+### Removed
+- Outdated face mask recommendation from event information page
+
+### Fixed
+- Test suite compatibility: Updated test mocks and helpers for better reliability
+- Removed debug console.log statements from test environment configuration
+- Fixed Auth mock to include `authStateReady` method
+- Fixed Analytics mock to include proper app structure
+- Fixed ActivatedRoute mock to include all required snapshot properties
+
 ## [2025.0.0] - 2025-11-09
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
   "name": "santasworkshop",
-  "version": "2025.0.0",
+  "version": "2025.0.1",
   "author": "Joel Meaders",
   "private": true,
   "scripts": {

santashop-admin/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to the admin application will be documented in this file.
 
+## [2025.0.1] - 2025-11-09
+
+### Fixed
+- Test suite compatibility: Updated Auth mock with `authStateReady` method
+- Enhanced ActivatedRoute mock with complete snapshot properties
+- Improved test helper implementation for better test reliability
+
 ## [2025.0.0] - 2025-11-09
 
 ### Added

santashop-admin/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@santashop/admin",
-	"version": "2025.0.0",
+	"version": "2025.0.1",
 	"description": "",
 	"scripts": {
 		"lint": "ng lint santashop-admin --fix --cache",

santashop-admin/src/test-helpers.ts

@@ -24,13 +24,14 @@ export function createAuthMock(): jasmine.SpyObj<Auth> {
 		'createUserWithEmailAndPassword',
 		'sendPasswordResetEmail',
 		'onAuthStateChanged',
+		'authStateReady',
 	]) as jasmine.SpyObj<Auth> & { currentUser: null };
 	mock.currentUser = null;
-	mock.onAuthStateChanged = jasmine
+	const authStateChangedSpy = jasmine
 		.createSpy('onAuthStateChanged')
-		.and.returnValue(
-			() => undefined,
-		) as unknown as Auth['onAuthStateChanged'];
+		.and.returnValue(() => undefined);
+	(mock as any).onAuthStateChanged = authStateChangedSpy;
+	mock.authStateReady.and.returnValue(Promise.resolve());
 	return mock;
 }
 
@@ -137,8 +138,13 @@ export function createFirestoreMock(): jasmine.SpyObj<Firestore> {
 		doc: jasmine.createSpy('doc').and.returnValue(docMock),
 		_databaseId: { database: 'mock-database' },
 		type: 'firestore',
-		app: { name: 'mock-app' },
-	} as jasmine.SpyObj<Firestore>;
+		app: {
+			name: 'mock-app',
+			options: {},
+			automaticDataCollectionEnabled: false,
+		},
+		toJSON: () => ({}),
+	} as unknown as jasmine.SpyObj<Firestore>;
 
 	// Set circular references so collection/doc references point back to firestore
 	collectionMock.firestore = firestoreMock;
@@ -333,7 +339,31 @@ export function createActivatedRouteMock(): Partial<ActivatedRoute> {
 			params: {},
 			queryParams: {},
 			data: {},
-		},
+			url: [],
+			fragment: null,
+			outlet: 'primary',
+			component: null,
+			routeName: null,
+			title: undefined,
+			routeConfig: null,
+			root: {} as any,
+			parent: null,
+			firstChild: null,
+			children: [],
+			pathFromRoot: [] as any,
+			paramMap: {
+				get: () => null,
+				has: () => false,
+				getAll: () => [],
+				keys: [],
+			} as any,
+			queryParamMap: {
+				get: () => null,
+				has: () => false,
+				getAll: () => [],
+				keys: [],
+			} as any,
+		} as any,
 		params: of({}),
 		queryParams: of({}),
 		data: of({}),

santashop-app/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to the main application will be documented in this file.
 
+## [2025.0.1] - 2025-11-09
+
+### Fixed
+- Test suite compatibility: Fixed all spec files to use proper mock factories
+- Removed debug console.log statements from environment.test.ts
+- Updated test helpers with complete Auth mock (including `authStateReady`)
+- Fixed Analytics mock to use proper factory pattern
+- Enhanced ActivatedRoute mock with all required snapshot properties
+- Fixed E2E test to remove unnecessary debug logging
+- Improved service spec files with proper dependency mocking
+- Fixed guard spec files to use factory-based mocks
+
 ## [2025.0.0] - 2025-11-09
 
 ### Added

santashop-app/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@santashop/app",
-	"version": "2025.0.0",
+	"version": "2025.0.1",
 	"description": "Coming soon.",
 	"main": "index.js",
 	"scripts": {

santashop-app/src/app/app.component.spec.ts

@@ -4,13 +4,19 @@ import { Analytics } from '@angular/fire/analytics';
 import {
 	provideActivatedRouteMock,
 	createTranslateServiceMock,
+	createAnalyticsMock,
+	createModalControllerMock,
 } from '../test-helpers';
 
-import { AlertController, Platform } from '@ionic/angular/standalone';
+import {
+	AlertController,
+	Platform,
+	ModalController,
+} from '@ionic/angular/standalone';
 import { TranslateService } from '@ngx-translate/core';
 
 import { AppComponent } from './app.component';
-import { AppStateService } from './core';
+import { AppStateService } from '@santashop/core';
 import { provideRouter } from '@angular/router';
 import { of } from 'rxjs';
 
@@ -39,14 +45,18 @@ describe('AppComponent', () => {
 				{ provide: AppStateService, useValue: appStateSpy },
 				{
 					provide: Analytics,
-					useValue: jasmine.createSpyObj('Analytics', ['']),
+					useFactory: createAnalyticsMock,
 				},
 				{
 					provide: AlertController,
 					useValue: jasmine.createSpyObj('AlertController', [
 						'create',
 					]),
 				},
+				{
+					provide: ModalController,
+					useValue: createModalControllerMock(),
+				},
 				provideActivatedRouteMock(),
 			],
 		})

santashop-app/src/app/core/guards/checked-in.guard.spec.ts

@@ -2,6 +2,7 @@ import { TestBed } from '@angular/core/testing';
 import { Auth } from '@angular/fire/auth';
 import { Firestore } from '@angular/fire/firestore';
 import { Functions } from '@angular/fire/functions';
+import { createAuthMock } from '../../../test-helpers';
 
 import { CheckedInGuard } from './checked-in.guard';
 
@@ -20,9 +21,7 @@ describe('CheckedInGuard', () => {
 				},
 				{
 					provide: Auth,
-					useValue: jasmine.createSpyObj('Auth', [
-						'signInWithEmailAndPassword',
-					]),
+					useFactory: createAuthMock,
 				},
 				{
 					provide: Functions,

santashop-app/src/app/core/guards/registration-complete.guard.spec.ts

@@ -48,7 +48,7 @@ describe('RegistrationCompleteGuard', () => {
 		});
 
 		// Recreate guard with updated observable
-		guard = new RegistrationCompleteGuard(preregistrationService, router);
+		guard = TestBed.inject(RegistrationCompleteGuard);
 
 		// Act
 		const value = await firstValueFrom(guard.canActivate());
@@ -62,13 +62,28 @@ describe('RegistrationCompleteGuard', () => {
 		const mockUrlTree = new UrlTree();
 		router.parseUrl.and.returnValue(mockUrlTree);
 
-		Object.defineProperty(preregistrationService, 'registrationComplete$', {
-			get: () => of(true),
-			configurable: true,
+		// Reconfigure TestBed with new PreRegistrationService mock
+		TestBed.resetTestingModule();
+		TestBed.configureTestingModule({
+			teardown: { destroyAfterEach: false },
+			providers: [
+				{
+					provide: Router,
+					useValue: router,
+				},
+				{
+					provide: PreRegistrationService,
+					useValue: jasmine.createSpyObj<PreRegistrationService>(
+						'prs',
+						[],
+						{ registrationComplete$: of(true) },
+					),
+				},
+			],
 		});
 
-		// Recreate guard with updated observable
-		guard = new RegistrationCompleteGuard(preregistrationService, router);
+		// Get new guard instance
+		guard = TestBed.inject(RegistrationCompleteGuard);
 
 		// Act
 		const value = await firstValueFrom(guard.canActivate());