Skip to content

Commit b213bf3

Browse files
Added compulsory RF5 precheck to affected tests
1 parent fcbc90a commit b213bf3

File tree

2 files changed

+25
-22
lines changed

2 files changed

+25
-22
lines changed

src/rf5_echo_aprsis_traffic.robot

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ ${filter} t/m
2222
*** Test Cases ***
2323
RF5 Echo APRS-IS Raw Traffic
2424
[Documentation] Capture APRS messages from APRS-IS and display them on the console
25+
Log To Console \nAPRS-IS Echo Server
26+
Log To Console Press CTRL-C to quit
2527
WHILE ${True}
2628
Receive Packet From APRS-IS
2729
END
@@ -38,11 +40,12 @@ Open APRS-IS Connection
3840
Set APRS-IS Passcode ${passcode}
3941
Set APRS-IS Filter ${filter}
4042

41-
Log Connecting to APRS-IS
43+
Log To Console Connecting to APRS-IS
4244
Connect to APRS-IS
45+
Log To Console Connected to APRS-IS
4346

4447
Close APRS-IS Connection
45-
Log Disconnect from APRS-IS
48+
Log To Console Disconnect from APRS-IS
4649
Disconnect from APRS-IS
4750

4851
Receive packet from APRS-IS
@@ -55,13 +58,13 @@ Receive packet from APRS-IS
5558
Log To Console ${packet}
5659

5760
Check Robot Framework Version
58-
[Documentation] Checks the robotframework's version and aborts if we don't use minimum version 5.x.x
59-
# Get the version. Will be in x.x.x format, e.g. 4.1.2
60-
${ver}= Evaluate (robot.version.VERSION)
61+
[Documentation] Checks the robotframework's version and aborts if we don't use minimum version 5.x.x
62+
# Get the version. Will be in x.x.x format, e.g. 4.1.2
63+
${ver}= Evaluate (robot.version.VERSION)
6164

62-
# Split up the string and get the major and minor versions, then convert the values to integer
63-
${words}= Split String ${ver} .
64-
${major}= Convert To Integer ${words[0]}
65+
# Split up the string and get the major and minor versions, then convert the values to integer
66+
${words}= Split String ${ver} .
67+
${major}= Convert To Integer ${words[0]}
6568

66-
# Check the version and fail the test if necessary
67-
Run Keyword If '${major}' < '5' Fatal Error msg=This test suite can only be run with Robot Framework 5.x.x. Present Version is '${ver}'
69+
# Check the version and fail the test if necessary
70+
Run Keyword If '${major}' < '5' Fatal Error msg=This test suite can only be run with Robot Framework 5.x.x. Present Version is '${ver}'

src/rf5_receive_and_send.robot

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Receive packet from APRS-IS
4141
[Documentation] VERY simplified ack-and-respond-to-message test case. Sends ack & msg to user, then terminates the test
4242
4343
# Get the packet from APRS-IS
44-
Log Receive message from APRS-IS
44+
Log To Console Receive message from APRS-IS
4545
${packet} = Receive APRS Packet
4646

4747
Log To Console Receive complete
@@ -150,7 +150,7 @@ Process APRS Response
150150
Send Packet to APRS-IS
151151
[Documentation] Send packet to APRS-IS
152152
[arguments] ${message}
153-
Log Send Packet to APRS-IS
153+
Log To Console Send Packet to APRS-IS
154154
Send APRS Packet ${message}
155155

156156
Open APRS-IS Connection
@@ -166,22 +166,22 @@ Open APRS-IS Connection
166166
Set APRS-IS Passcode ${passcode}
167167
Set APRS-IS Filter ${filter}
168168

169-
Log Connecting to APRS-IS
169+
Log To Console Connecting to APRS-IS
170170
Connect to APRS-IS
171171

172172
Close APRS-IS Connection
173173
[Documentation] Closes an existing connection to APRS-IS
174-
Log Disconnect from APRS-IS
174+
Log To Console Disconnect from APRS-IS
175175
Disconnect from APRS-IS
176176

177177
Check Robot Framework Version
178-
[Documentation] Checks the robotframework's version and aborts if we don't use minimum version 5.x.x
179-
# Get the version. Will be in x.x.x format, e.g. 4.1.2
180-
${ver}= Evaluate (robot.version.VERSION)
178+
[Documentation] Checks the robotframework's version and aborts if we don't use minimum version 5.x.x
179+
# Get the version. Will be in x.x.x format, e.g. 4.1.2
180+
${ver}= Evaluate (robot.version.VERSION)
181181

182-
# Split up the string and get the major and minor versions, then convert the values to integer
183-
${words}= Split String ${ver} .
184-
${major}= Convert To Integer ${words[0]}
182+
# Split up the string and get the major and minor versions, then convert the values to integer
183+
${words}= Split String ${ver} .
184+
${major}= Convert To Integer ${words[0]}
185185

186-
# Check the version and fail the test if necessary
187-
Run Keyword If '${major}' < '5' Fatal Error msg=This test suite can only be run with Robot Framework 5.x.x. Present Version is '${ver}'
186+
# Check the version and fail the test if necessary
187+
Run Keyword If '${major}' < '5' Fatal Error msg=This test suite can only be run with Robot Framework 5.x.x. Present Version is '${ver}'

0 commit comments

Comments
 (0)