[rust2cpg] typeFullName for record/tuple patterns. (#6221)

Author: xavierpinho

MODULE.bazel

@@ -132,7 +132,7 @@ RUBYSRC2CPG_ASTGEN_VERSION = "0.59.6"
 
 RUBYSRC2CPG_TYPE_STUBS_VERSION = "0.6.0"
 
-RUST2CPG_ASTGEN_VERSION = "0.19.0"
+RUST2CPG_ASTGEN_VERSION = "0.19.1"
 
 PHP_PARSER_VERSION = "4.15.10"
 

joern-cli/frontends/rust2cpg/src/main/resources/application.conf

@@ -1,3 +1,3 @@
 rust2cpg {
-    rust_ast_gen_version: "0.19.0"
+    rust_ast_gen_version: "0.19.1"
 }

joern-cli/frontends/rust2cpg/src/main/scala/io/joern/rust2cpg/astcreation/RustFullNames.scala

@@ -160,7 +160,9 @@ trait RustFullNames { this: AstCreator =>
         case tuplePat: RustNodeSyntax.TuplePat =>
           val childTypes = tuplePat.pat.map(typeFullNameForPat)
           s"(${childTypes.mkString(", ")})"
-        case _ => Defines.Any
+        case recordPat: RustNodeSyntax.RecordPat           => typeFullNameForPath(recordPat.path)
+        case tupleStructPat: RustNodeSyntax.TupleStructPat => typeFullNameForPath(tupleStructPat.path)
+        case _                                             => Defines.Any
       }
     }
   }

joern-cli/frontends/rust2cpg/src/test/scala/io/joern/rust2cpg/passes/ast/DeclarationTests.scala

@@ -1119,6 +1119,31 @@ class DeclarationTests extends Rust2CpgSuite(noSysRoot = true) {
           endAssign.code shouldBe "end = <tmp>0.end"
       }
     }
+
+    "have correct field accesses" in {
+      inside(cpg.assignment.where(_.target.isIdentifier.nameExact("x")).source.l) { case (fieldAccess: Call) :: Nil =>
+        fieldAccess.name shouldBe Operators.fieldAccess
+        fieldAccess.typeFullName shouldBe "i32"
+        inside(fieldAccess.argument.sortBy(_.argumentIndex).l) {
+          case (startFieldAccess: Call) :: (field: FieldIdentifier) :: Nil =>
+            field.canonicalName shouldBe "x"
+            startFieldAccess.name shouldBe Operators.fieldAccess
+            startFieldAccess.code shouldBe "<tmp>0.start"
+            startFieldAccess.typeFullName shouldBe "rust2cpgtest::Point"
+        }
+      }
+      inside(cpg.assignment.where(_.target.isIdentifier.nameExact("y")).source.l) { case (fieldAccess: Call) :: Nil =>
+        fieldAccess.name shouldBe Operators.fieldAccess
+        fieldAccess.typeFullName shouldBe "i64"
+        inside(fieldAccess.argument.sortBy(_.argumentIndex).l) {
+          case (startFieldAccess: Call) :: (field: FieldIdentifier) :: Nil =>
+            field.canonicalName shouldBe "y"
+            startFieldAccess.name shouldBe Operators.fieldAccess
+            startFieldAccess.code shouldBe "<tmp>0.start"
+            startFieldAccess.typeFullName shouldBe "rust2cpgtest::Point"
+        }
+      }
+    }
   }
 
   "let with a record pattern in a tuple pattern" should {

joern-cli/frontends/rust2cpg/src/test/scala/io/joern/rust2cpg/passes/ast/ForTests.scala

@@ -259,8 +259,7 @@ class ForTestsWithSysroot extends Rust2CpgSuite(noSysRoot = false) {
     "have correct locals" in {
       inside(cpg.whileBlock.astChildren.isBlock.astChildren.isLocal.l) { case tmp :: xLocal :: yLocal :: Nil =>
         tmp.name shouldBe "<tmp>1"
-        // TODO(rust_ast_gen): typeFullName for patterns.
-        pendingUntilFixed(tmp.typeFullName shouldBe "rust2cpgtest::Point")
+        tmp.typeFullName shouldBe "rust2cpgtest::Point"
         xLocal.name shouldBe "x"
         xLocal.typeFullName shouldBe "i32"
         yLocal.name shouldBe "y"