Add oauth_body_hash #110
Closed
Add oauth_body_hash #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webjunkie thanks for the PR! @jaitaiwan can you take a look? |
| @@ -695,8 +707,9 @@ class Server(object): | |||
| version = OAUTH_VERSION | |||
| signature_methods = None | |||
|
|
|||
| def __init__(self, signature_methods=None): | |||
| def __init__(self, signature_methods=None, body_hashing=False): | |||
There was a problem hiding this comment.
Can we make this check_body_hashing? Or verify_body_hash?
|
Is this the same issue as #138? If so, the body should always be hashed even if empty according to spec... |
|
@jaitaiwan that's true, but I don't think body hashing itself is part of the OAuth specification. In other words, if you implement it you need to do this, but the providers don't have to implement body hashing. At least that's how I've understood this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add body_hash capability to server as in
http://oauth.googlecode.com/svn/spec/ext/body_hash/1.0/oauth-bodyhash.html