Commit 6104ccd
Correct the excludePlatforms logic in combining schema step of Codegen (facebook#51910)
Summary:
Pull Request resolved: facebook#51910
**Changelog:**
[Android] [Fixed] - Fix combining schema in Codegen process to exclude platforms correctly
Discovered an issue with how we are excluding platforms in processing codegen schema.
`excludedPlatforms` is a field on `OptionsShape` part of `ComponentShape` not Module
https://www.internalfb.com/code/fbsource/[153d78d4cd5d0fa652e5a0919bcdb26f32d0945e]/xplat/js/react-native-github/packages/react-native-codegen/src/CodegenSchema.js?lines=112
Hence for components modifying the script to iterate over component and for then exclude accordingly based on `platform`.
Reviewed By: cipolleschi
Differential Revision: D76158851
fbshipit-source-id: 791ec12d068794e36f34da7419082887483ce6c51 parent 84f9e48 commit 6104ccd
File tree
1 file changed
+14
-0
lines changed- packages/react-native-codegen/src/cli/combine
1 file changed
+14
-0
lines changedLines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
88 | 102 | | |
89 | 103 | | |
90 | 104 | | |
| |||
0 commit comments