Skip to content

Fix dependency on window in an enviroment, where window is not available. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix dependency on window in an enviroment, where window is not available. #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5602332
This should fix any issues arising from testing/using this library, w…
johandavidsen Oct 17, 2016
dbb484f
updated the documentation and package json
johandavidsen Oct 18, 2016
14ae73f
Added contributors to the package.json
johandavidsen Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
ReconnectingWebSocket
=====================
****
**Major notice, this is a library developed by Joe Walnes, I have made a small change
to the implementations: see [pull request](https://github.com/joewalnes/reconnecting-websocket/pull/76). I have decided to publish this to npm so that I can use it with yarn. **
****

A small JavaScript library that decorates the WebSocket API to provide a WebSocket connection that will automatically reconnect if the connection is dropped.

Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
"url": "git://github.com/joewalnes/reconnecting-websocket.git"
},
"author": "Joe Walnes",
"contributors": [
{ "name" : "Jóhan Davidsen", "email" : "[email protected]", "url" : "https://fjakkarin.com" }
],
"license": "MIT",
"bugs": {
"url": "https://github.com/joewalnes/reconnecting-websocket/issues"
Expand Down
2 changes: 1 addition & 1 deletion reconnecting-websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
}
})(this, function () {

if (!('WebSocket' in window)) {
if (!global.window || !('WebSocket' in global.window)) {
return;
}

Expand Down