-
Notifications
You must be signed in to change notification settings - Fork 11
Description
Hello Team 👋
Describe the bug
The Gitmoji Browser Extension currently doesn't work with GitHub's new PR merge interface which was recently deployed. The extension fails to insert gitmojis into the commit message field because the selector for the input element has changed in GitHub's new UI.
Current Behavior
The extension can't find the commit title input field in GitHub's new merge UI, so no gitmoji is injected.
Expected Behavior
The extension should detect the input field in both the new and old GitHub UI and inject the gitmoji correctly.
Technical Details
The old selector was input[name="commit_title"]
The new GitHub UI uses input[data-component="input"] for the commit message field
We also need to improve the MutationObserver configuration to include subtree: true for faster detection of UI changes
Device (please complete the following information):
- OS: MacOS
- Browser: Brave
Proposed Solution
Update the selector logic in injectMergeGitmoji.js to support both old and new GitHub UIs, and improve the MutationObserver configuration for better responsiveness.