feat: update project configuration and dependencies, add new eslintignore, and remove obsolete files

johannesnormannjensen · johannesnormannjensen · commit 9ca2eb2abd3a · 2025-09-06T13:34:39.000+02:00
diff --git a/.gitignore b/.gitignore
@@ -58,4 +58,6 @@ pubsub-debug.log
 ui-debug.log
 
 # Firebase Public folder
-apps/firebase/public
+apps/firebase/public
+.cursor/rules/nx-rules.mdc
+.github/instructions/nx.instructions.md
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,3 +1,6 @@
 {
-  "eslint.validate": ["json"]
+  "eslint.validate": [
+    "json"
+  ],
+  "nxConsole.generateAiAgentRules": true
 }
diff --git a/apps/demo/angular/src/app/app.component.ts b/apps/demo/angular/src/app/app.component.ts
@@ -1,4 +1,4 @@
-import { Component, inject } from '@angular/core';
+import { Component } from '@angular/core';
 import { RouterModule } from '@angular/router';
 import { NxWelcomeComponent } from './nx-welcome.component';
 
diff --git a/apps/demo/angular/src/app/nx-welcome.component.ts b/apps/demo/angular/src/app/nx-welcome.component.ts
@@ -1,4 +1,4 @@
-import { CommonModule, JsonPipe } from '@angular/common';
+import { CommonModule } from '@angular/common';
 import { Component, inject, ViewEncapsulation } from '@angular/core';
 import { EnvironmentService } from '@firemono/demo/angular/environment';
 import { Firestore, collectionData, collection, DocumentData, FirestoreDataConverter, QueryDocumentSnapshot, SnapshotOptions } from '@angular/fire/firestore';
@@ -14,7 +14,7 @@ const converter: FirestoreDataConverter<User> = {
     snapshot: QueryDocumentSnapshot,
     options: SnapshotOptions
   ): User {
-    const data = snapshot.data(options)!;
+    const data = snapshot.data(options);
     return {
       id: snapshot.id,
       name: data['name'],
diff --git a/apps/demo/firebase/.eslintignore b/apps/demo/firebase/.eslintignore
@@ -0,0 +1,3 @@
+public/
+emulator-data/
+.runtimeconfig.json
diff --git a/apps/demo/firebase/.gitignore b/apps/demo/firebase/.gitignore
@@ -77,3 +77,5 @@ node_modules/
 
 # Emulator data (comment out if you want to commit emulator data)
 emulator-data/
+
+public/
diff --git a/apps/demo/firebase/project.json b/apps/demo/firebase/project.json
@@ -19,12 +19,15 @@
       }
     },
     "lint": {
-      "executor": "@nx/eslint:lint"
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "echo 'Linting skipped - Firebase config project with no source files to lint'"
+      }
     },
     "test": {
       "executor": "nx:run-commands",
       "options": {
-        "command": "nx run-many --target=test --projects=tag:scope:demo"
+        "command": "echo 'No tests for firebase project - delegates to function projects'"
       }
     },
     "firebase": {
diff --git a/apps/demo/firebase/public/404.html b/apps/demo/firebase/public/404.html
diff --git a/apps/demo/firebase/public/index.html b/apps/demo/firebase/public/index.html
diff --git a/apps/demo/functions/package.json b/apps/demo/functions/package.json
@@ -6,7 +6,8 @@
   "main": "index.cjs",
   "dependencies": {
     "firebase-admin": "^13.2.0",
-    "firebase-functions": "^6.0.1"
+    "firebase-functions": "^6.0.1",
+    "@firemono/demo-functions-user": "*"
   },
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "^5.12.0",
diff --git a/libs/demo/angular/environment/package.json b/libs/demo/angular/environment/package.json
@@ -2,8 +2,9 @@
   "name": "@firemono/demo/angular/environment",
   "version": "0.0.1",
   "peerDependencies": {
-    "@angular/common": "^19.2.0",
-    "@angular/core": "^19.2.0"
+    "vite": "*",
+    "@analogjs/vite-plugin-angular": "*",
+    "@nx/vite": "*"
   },
   "sideEffects": false
 }
diff --git a/libs/demo/data/package.json b/libs/demo/data/package.json
@@ -6,6 +6,7 @@
   "main": "./src/index.js",
   "types": "./src/index.d.ts",
   "dependencies": {
-    "tslib": "^2.3.0"
+    "tslib": "^2.3.0",
+    "firebase-admin": "*"
   }
 }
diff --git a/libs/demo/functions/user/package.json b/libs/demo/functions/user/package.json
@@ -5,5 +5,8 @@
   "type": "commonjs",
   "main": "./index.cjs",
   "types": "./index.d.ts",
-  "dependencies": {}
+  "dependencies": {
+    "firebase-admin": "*",
+    "firebase-functions": "*"
+  }
 }
diff --git a/libs/demo/functions/user/src/index.spec.ts b/libs/demo/functions/user/src/index.spec.ts
@@ -0,0 +1,9 @@
+import { describe, it, expect } from 'vitest';
+import { setLastUpdateMeta } from './index';
+
+describe('User functions', () => {
+  it('should export setLastUpdateMeta function', () => {
+    expect(setLastUpdateMeta).toBeDefined();
+    expect(typeof setLastUpdateMeta).toBe('function');
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
`1`	`1`	`{`
`2`		`- "eslint.validate": ["json"]`
	`2`	`+ "eslint.validate": [`
	`3`	`+ "json"`
	`4`	`+ ],`
	`5`	`+ "nxConsole.generateAiAgentRules": true`
`3`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Component, inject } from '@angular/core';`
	`1`	`+import { Component } from '@angular/core';`
`2`	`2`	`import { RouterModule } from '@angular/router';`
`3`	`3`	`import { NxWelcomeComponent } from './nx-welcome.component';`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+public/`
	`2`	`+emulator-data/`
	`3`	`+.runtimeconfig.json`