feat: update emulator data handling and remove obsolete exports directory

johannesnormannjensen · johannesnormannjensen · commit b1bb2b615b44 · 2025-08-25T00:12:13.000+02:00
diff --git a/apps/demo/firebase/.gitignore b/apps/demo/firebase/.gitignore
@@ -74,3 +74,6 @@ dist/
 
 # Node modules (if not already ignored)
 node_modules/
+
+# Emulator data (comment out if you want to commit emulator data)
+emulator-data/
diff --git a/apps/demo/firebase/exports/.gitkeep b/apps/demo/firebase/exports/.gitkeep
diff --git a/apps/demo/firebase/project.json b/apps/demo/firebase/project.json
@@ -45,14 +45,14 @@
       "executor": "nx:run-commands",
       "options": {
         "cwd": "apps/demo/firebase",
-        "command": "mkdir -p exports && if [ -d \"exports\" ] && [ \"$(ls -A exports)\" ]; then firebase emulators:start --only=functions,firestore,hosting,auth --import=./exports; else firebase emulators:start --only=functions,firestore,hosting,auth; fi"
+        "command": "firebase emulators:start --only=functions,firestore,hosting,auth --import=./emulator-data --export-on-exit=./emulator-data"
       }
     },
     "emulators:debug": {
       "executor": "nx:run-commands",
       "options": {
         "cwd": "apps/demo/firebase",
-        "command": "mkdir -p exports && if [ -d \"exports\" ] && [ \"$(ls -A exports)\" ]; then firebase emulators:start --inspect-functions --only=functions,firestore,hosting,auth --import=./exports; else firebase emulators:start --inspect-functions --only=functions,firestore,hosting,auth; fi"
+        "command": "firebase emulators:start --inspect-functions --only=functions,firestore,hosting,auth --import=./emulator-data --export-on-exit=./emulator-data"
       }
     },
     "emulators:stop": {
@@ -89,7 +89,7 @@
       "options": {
         "commands": [
           "nx build demo-functions --watch",
-          "cd apps/demo/firebase && mkdir -p exports && firebase emulators:start --only=functions,firestore,hosting,auth"
+          "cd apps/demo/firebase && firebase emulators:start --only=functions,firestore,hosting,auth --import=./emulator-data --export-on-exit=./emulator-data"
         ],
         "parallel": true
       }
@@ -98,14 +98,14 @@
       "executor": "nx:run-commands",
       "options": {
         "cwd": "apps/demo/firebase",
-        "command": "firebase emulators:export ./exports --force"
+        "command": "firebase emulators:export ./emulator-data --force"
       }
     },
     "data:import": {
       "executor": "nx:run-commands",
       "options": {
         "cwd": "apps/demo/firebase",
-        "command": "firebase emulators:start --import=./exports --export-on-exit=./exports"
+        "command": "firebase emulators:start --import=./emulator-data --export-on-exit=./emulator-data"
       }
     },
     "data:seed": {
diff --git a/libs/demo/functions/user/src/lib/user.trigger.spec.ts b/libs/demo/functions/user/src/lib/user.trigger.spec.ts
diff --git a/libs/demo/functions/user/src/lib/user.trigger.ts b/libs/demo/functions/user/src/lib/user.trigger.ts
@@ -1,17 +1,36 @@
-import { User } from '@firemono/demo/data';
-import { getFirestore, Timestamp } from 'firebase-admin/firestore';
+import { FieldValue, getFirestore } from 'firebase-admin/firestore';
 import { firestore } from 'firebase-functions';
 
-
-export const setLastUpdate = firestore.onDocumentUpdated("user/{userId}", async (event) => {
+// Fires only when an existing user document changes
+export const setLastUpdateMeta = firestore.onDocumentUpdated('user/{userId}', async (event) => {
     const db = getFirestore();
-    const userAfter: User = event.data?.after.data() as User;
+    const userId = event.params.userId;
+    const after = event.data?.after;
+    if (!after) return;
 
-    if (!userAfter) {
-        return;
-    }
+    // Optional: pick fields to denormalize into metadata
+    const displayName = after.get('displayName') ?? null;
+    const roles = after.get('roles') ?? null;
 
-    return db.collection("user").doc(event.params.userId).update({ lastUpdate: Timestamp.now() });
-})
+    const metaRef = db.collection('user_metadata').doc(userId);
+    const eventId = event.id; // unique-ish per delivery; functions are "at-least-once"
 
+    // Idempotency guard: only write if we haven't processed this eventId yet
+    await db.runTransaction(async (tx) => {
+        const snap = await tx.get(metaRef);
+        const lastEventId = snap.exists ? snap.get('lastEventId') : null;
+        if (lastEventId === eventId) return; // already processed this event
 
+        tx.set(
+            metaRef,
+            {
+                lastUpdate: FieldValue.serverTimestamp(), // server time ✅
+                lastEventId: eventId,                    // idempotency marker
+                displayName,
+                roles,
+                updatedBy: 'setLastUpdateMeta',
+            },
+            { merge: true }
+        );
+    });
+});
diff --git a/tools/nx/src/generators/init-app/init.ts b/tools/nx/src/generators/init-app/init.ts
@@ -161,10 +161,10 @@ nx deploy-functions ${projectName}` : ''}
 
 ### Data Management
 \`\`\`bash
-# Export emulator data
+# Export emulator data (also auto-exported on emulator exit)
 nx data:export ${projectName}
 
-# Import emulator data
+# Import emulator data (also auto-imported on emulator start)
 nx data:import ${projectName}
 
 # Seed development data (customize the seed target)
@@ -225,7 +225,7 @@ ${features.includes('firestore') ? `├── firestore.rules       # Firestore
 ├── firestore.indexes.json # Firestore indexes` : ''}
 ${features.includes('hosting') ? `├── public/               # Hosting files` : ''}
 ${features.includes('storage') ? `├── storage.rules         # Storage security rules` : ''}
-└── exports/              # Emulator data exports
+└── emulator-data/        # Emulator data exports (auto-imported/exported)
 \`\`\`
 
 ## Learn More
@@ -238,7 +238,7 @@ ${features.includes('storage') ? `├── storage.rules         # Storage secu
   tree.write(joinPathFragments(projectRoot, 'README.md'), readmeContent);
 }
 
-function createFunctionsNxApp(tree: Tree, baseProjectName: string, projectDir: string, initDir: string, dynamicConfig: any) {
+function createFunctionsNxApp(tree: Tree, baseProjectName: string, projectDir: string, initDir: string) {
   const functionsAppName = `${baseProjectName}-functions`;
   const functionsAppRoot = joinPathFragments(projectDir, 'functions');
   const functionsSourceDir = join(initDir, 'functions');
@@ -482,7 +482,7 @@ export default async function (tree: Tree, schema: Schema) {
   // Create Functions Nx app if functions are detected
   let functionsAppName: string | null = null;
   if (features.includes('functions')) {
-    functionsAppName = createFunctionsNxApp(tree, baseProjectName, projectDir, initDirResolved, null);
+    functionsAppName = createFunctionsNxApp(tree, baseProjectName, projectDir, initDirResolved);
   }
   
   // Get dynamic configuration based on detected features
@@ -547,7 +547,7 @@ export default async function (tree: Tree, schema: Schema) {
         options: { 
           cwd: projectRoot,
           command: dynamicConfig.hasEmulators && dynamicConfig.emulatorServices 
-            ? `mkdir -p exports && if [ -d "exports" ] && [ "$(ls -A exports)" ]; then firebase emulators:start --only=${dynamicConfig.emulatorServices} --import=./exports; else firebase emulators:start --only=${dynamicConfig.emulatorServices}; fi`
+            ? `firebase emulators:start --only=${dynamicConfig.emulatorServices} --import=./emulator-data --export-on-exit=./emulator-data`
             : 'echo "No emulators configured"'
         }
       },
@@ -556,7 +556,7 @@ export default async function (tree: Tree, schema: Schema) {
         options: { 
           cwd: projectRoot,
           command: dynamicConfig.hasEmulators && dynamicConfig.emulatorServices
-            ? `mkdir -p exports && if [ -d "exports" ] && [ "$(ls -A exports)" ]; then firebase emulators:start --inspect-functions --only=${dynamicConfig.emulatorServices} --import=./exports; else firebase emulators:start --inspect-functions --only=${dynamicConfig.emulatorServices}; fi`
+            ? `firebase emulators:start --inspect-functions --only=${dynamicConfig.emulatorServices} --import=./emulator-data --export-on-exit=./emulator-data`
             : 'echo "No emulators configured"'
         }
       },
@@ -596,28 +596,28 @@ export default async function (tree: Tree, schema: Schema) {
         options: functionsAppName && dynamicConfig.hasEmulators ? {
           commands: [
             `nx build ${functionsAppName} --watch`,
-            `cd ${projectRoot} && mkdir -p exports && firebase emulators:start --only=${dynamicConfig.emulatorServices}`
+            `cd ${projectRoot} && firebase emulators:start --only=${dynamicConfig.emulatorServices} --import=./emulator-data --export-on-exit=./emulator-data`
           ],
           parallel: true
         } : { 
           cwd: projectRoot,
           command: dynamicConfig.hasEmulators 
-            ? `mkdir -p exports && firebase emulators:start --only=${dynamicConfig.emulatorServices}`
+            ? `firebase emulators:start --only=${dynamicConfig.emulatorServices} --import=./emulator-data --export-on-exit=./emulator-data`
             : 'echo "No development environment configured"'
         }
       },
       'data:export': {
         executor: 'nx:run-commands',
         options: { 
           cwd: projectRoot,
-          command: 'firebase emulators:export ./exports --force' 
+          command: 'firebase emulators:export ./emulator-data --force' 
         }
       },
       'data:import': {
         executor: 'nx:run-commands',
         options: { 
           cwd: projectRoot,
-          command: 'firebase emulators:start --import=./exports --export-on-exit=./exports' 
+          command: 'firebase emulators:start --import=./emulator-data --export-on-exit=./emulator-data' 
         }
       },
       'data:seed': {
@@ -663,8 +663,8 @@ export default async function (tree: Tree, schema: Schema) {
   // Fix ESLint configuration conflicts
   fixEslintConfiguration(tree, projectRoot);
   
-  // Create exports directory for emulator data
-  tree.write(joinPathFragments(projectRoot, 'exports', '.gitkeep'), '# This directory stores emulator data exports\n');
+  // Create emulator-data directory for emulator data
+  tree.write(joinPathFragments(projectRoot, 'emulator-data', '.gitkeep'), '# This directory stores emulator data exports\n# The emulator-data directory is automatically used by Firebase emulators for data import/export\n# Data is automatically saved on emulator exit and loaded on startup\n');
   
   // Generate project-specific README
   generateProjectReadme(tree, projectRoot, baseProjectName, features, firebaseProjectName);
@@ -679,6 +679,9 @@ dist/
 
 # Node modules (if not already ignored)
 node_modules/
+
+# Emulator data (comment out if you want to commit emulator data)
+emulator-data/
 `;
   
   if (!existingGitignore.includes('.nx/')) {
