Skip to content

Commit f332203

Browse files
http-client-java, do not generate model under models sub package, for unbranded (microsoft#5269)
also bump TCGC output ![image](https://github.com/user-attachments/assets/72071b8c-a412-4c36-b993-931f4fe06394)
1 parent df30aca commit f332203

File tree

4 files changed

+24
-18
lines changed

4 files changed

+24
-18
lines changed

packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/extension/plugin/JavaSettings.java

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,10 @@ public static JavaSettings getInstance() {
108108
logger.debug("List of require : {}", autorestSettings.getRequire());
109109
}
110110

111-
String fluent = getStringValue(host, "fluent");
111+
final String fluent = getStringValue(host, "fluent");
112+
113+
final String flavor = getStringValue(host, "flavor", "azure");
114+
final String defaultModelsSubPackageName = isBranded(flavor) ? "models" : "";
112115

113116
setHeader(getStringValue(host, "license-header"));
114117
instance = new JavaSettings(autorestSettings,
@@ -120,8 +123,8 @@ public static JavaSettings getInstance() {
120123
getBooleanValue(host, "generate-client-interfaces", false),
121124
getBooleanValue(host, "generate-client-as-impl", false),
122125
getStringValue(host, "implementation-subpackage", "implementation"),
123-
getStringValue(host, "models-subpackage", "models"), getStringValue(host, "custom-types", ""),
124-
getStringValue(host, "custom-types-subpackage", ""),
126+
getStringValue(host, "models-subpackage", defaultModelsSubPackageName),
127+
getStringValue(host, "custom-types", ""), getStringValue(host, "custom-types-subpackage", ""),
125128
getStringValue(host, "fluent-subpackage", "fluent"),
126129
getBooleanValue(host, "required-parameter-client-methods", false),
127130
getBooleanValue(host, "generate-sync-async-clients", false),
@@ -163,7 +166,7 @@ public static JavaSettings getInstance() {
163166
getBooleanValue(host, "disable-required-property-annotation", false),
164167
getBooleanValue(host, "enable-page-size", false), getBooleanValue(host, "use-key-credential", false),
165168
getBooleanValue(host, "null-byte-array-maps-to-empty-array", false),
166-
getBooleanValue(host, "graal-vm-config", false), getStringValue(host, "flavor", "Azure"),
169+
getBooleanValue(host, "graal-vm-config", false), flavor,
167170
getBooleanValue(host, "disable-typed-headers-methods", false),
168171
getBooleanValue(host, "share-jsonserializable-code", false),
169172
getBooleanValue(host, "use-object-for-unknown", false), getBooleanValue(host, "android", false));
@@ -402,7 +405,11 @@ private JavaSettings(AutorestSettings autorestSettings, Map<String, Object> mode
402405
* @return Whether to generate with Azure branding.
403406
*/
404407
public boolean isBranded() {
405-
return "azure".equalsIgnoreCase(this.flavor);
408+
return isBranded(this.flavor);
409+
}
410+
411+
private static boolean isBranded(String flavor) {
412+
return "azure".equalsIgnoreCase(flavor);
406413
}
407414

408415
private final String keyCredentialHeaderName;

packages/http-client-java/generator/http-client-generator-test/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
"dependencies": {
1515
"@azure-tools/cadl-ranch-specs": "0.39.4",
16-
"@typespec/http-client-java": "file:/../../typespec-http-client-java-0.1.2.tgz",
16+
"@typespec/http-client-java": "file:/../../typespec-http-client-java-0.1.3.tgz",
1717
"@typespec/http-client-java-tests": "file:"
1818
},
1919
"overrides": {
@@ -24,7 +24,7 @@
2424
"@typespec/openapi": "~0.62.0",
2525
"@typespec/xml": "~0.62.0",
2626
"@azure-tools/typespec-azure-core": "~0.48.0",
27-
"@azure-tools/typespec-client-generator-core": "~0.48.3",
27+
"@azure-tools/typespec-client-generator-core": "~0.48.4",
2828
"@azure-tools/typespec-azure-resource-manager": "~0.48.0",
2929
"@azure-tools/typespec-autorest": "~0.48.0"
3030
},

packages/http-client-java/package-lock.json

Lines changed: 7 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/http-client-java/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@typespec/http-client-java",
3-
"version": "0.1.2",
3+
"version": "0.1.3",
44
"description": "TypeSpec library for emitting Java client from the TypeSpec REST protocol binding",
55
"keywords": [
66
"TypeSpec"
@@ -44,7 +44,7 @@
4444
"peerDependencies": {
4545
"@azure-tools/typespec-autorest": ">=0.48.0 <1.0.0",
4646
"@azure-tools/typespec-azure-core": ">=0.48.0 <1.0.0",
47-
"@azure-tools/typespec-client-generator-core": ">=0.48.3 <1.0.0",
47+
"@azure-tools/typespec-client-generator-core": ">=0.48.4 <1.0.0",
4848
"@typespec/compiler": ">=0.62.0 <1.0.0",
4949
"@typespec/http": ">=0.62.0 <1.0.0",
5050
"@typespec/openapi": ">=0.62.0 <1.0.0",
@@ -63,7 +63,7 @@
6363
"@azure-tools/typespec-azure-core": "0.48.0",
6464
"@azure-tools/typespec-azure-resource-manager": "0.48.0",
6565
"@azure-tools/typespec-azure-rulesets": "0.48.0",
66-
"@azure-tools/typespec-client-generator-core": "0.48.3",
66+
"@azure-tools/typespec-client-generator-core": "0.48.4",
6767
"@microsoft/api-extractor": "^7.47.11",
6868
"@microsoft/api-extractor-model": "^7.29.8",
6969
"@types/js-yaml": "~4.0.9",

0 commit comments

Comments
 (0)