Added a new utility method to the PrimaryKeyConventionHelper to throw an exception if number of keys does not match the one specified in an entity type

Author: johelvisguzman

src/DotNetToolkit.Repository.AdoNet/Internal/AdoNetRepositoryContext.cs

@@ -1158,12 +1158,6 @@ private static Func<object, TElement> ConvertType<TElement>()
             return ConvertValue<TElement>;
         }
 
-        private void ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(object[] keyValues) where TEntity : class
-        {
-            if (keyValues.Length != PrimaryKeyConventionHelper.GetPrimaryKeyPropertyInfos<TEntity>().Count())
-                throw new ArgumentException(DotNetToolkit.Repository.Properties.Resources.EntityPrimaryKeyValuesLengthMismatch, nameof(keyValues));
-        }
-
         private async Task OnSchemaValidationAsync(Type entityType, CancellationToken cancellationToken)
         {
             // Performs some schema validation for this type (either creates the table if does not exist, or validates)
@@ -1423,7 +1417,7 @@ public QueryResult<TEntity> Find<TEntity>(IFetchQueryStrategy<TEntity> fetchStra
             if (keyValues == null)
                 throw new ArgumentNullException(nameof(keyValues));
 
-            ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
+            PrimaryKeyConventionHelper.ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
 
             var options = new QueryOptions<TEntity>().Include(PrimaryKeyConventionHelper.GetByPrimaryKeySpecification<TEntity>(keyValues));
 
@@ -1777,7 +1771,7 @@ public Task<QueryResult<TEntity>> FindAsync<TEntity>(CancellationToken cancellat
             if (keyValues == null)
                 throw new ArgumentNullException(nameof(keyValues));
 
-            ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
+            PrimaryKeyConventionHelper.ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
 
             var options = new QueryOptions<TEntity>().Include(PrimaryKeyConventionHelper.GetByPrimaryKeySpecification<TEntity>(keyValues));
 

src/DotNetToolkit.Repository.EntityFramework/Internal/EfRepositoryContext.cs

@@ -54,16 +54,6 @@ public EfRepositoryContext(DbContext context)
 
         #endregion
 
-        #region Private Methods
-
-        private void ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(object[] keyValues) where TEntity : class
-        {
-            if (keyValues.Length != PrimaryKeyConventionHelper.GetPrimaryKeyPropertyInfos<TEntity>().Count())
-                throw new ArgumentException(DotNetToolkit.Repository.Properties.Resources.EntityPrimaryKeyValuesLengthMismatch, nameof(keyValues));
-        }
-
-        #endregion
-
         #region Implementation of IRepositoryContext
 
         /// <summary>
@@ -291,7 +281,7 @@ public QueryResult<TEntity> Find<TEntity>(IFetchQueryStrategy<TEntity> fetchStra
             if (keyValues == null)
                 throw new ArgumentNullException(nameof(keyValues));
 
-            ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
+            PrimaryKeyConventionHelper.ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
 
             if (fetchStrategy == null)
             {
@@ -638,7 +628,7 @@ public async Task<QueryResult<TEntity>> FindAsync<TEntity>(CancellationToken can
             if (keyValues == null)
                 throw new ArgumentNullException(nameof(keyValues));
 
-            ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
+            PrimaryKeyConventionHelper.ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
 
             if (fetchStrategy == null)
             {

src/DotNetToolkit.Repository.EntityFrameworkCore/Internal/EfCoreRepositoryContext.cs

@@ -54,16 +54,6 @@ public EfCoreRepositoryContext(DbContext context)
 
         #endregion
 
-        #region Private Methods
-
-        private void ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(object[] keyValues) where TEntity : class
-        {
-            if (keyValues.Length != PrimaryKeyConventionHelper.GetPrimaryKeyPropertyInfos<TEntity>().Count())
-                throw new ArgumentException(DotNetToolkit.Repository.Properties.Resources.EntityPrimaryKeyValuesLengthMismatch, nameof(keyValues));
-        }
-
-        #endregion
-
         #region Implementation of IRepositoryContext
 
         /// <summary>
@@ -294,7 +284,7 @@ public QueryResult<TEntity> Find<TEntity>(IFetchQueryStrategy<TEntity> fetchStra
             if (keyValues == null)
                 throw new ArgumentNullException(nameof(keyValues));
 
-            ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
+            PrimaryKeyConventionHelper.ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
 
             if (fetchStrategy == null)
             {
@@ -641,7 +631,7 @@ public async Task<QueryResult<TEntity>> FindAsync<TEntity>(CancellationToken can
             if (keyValues == null)
                 throw new ArgumentNullException(nameof(keyValues));
 
-            ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
+            PrimaryKeyConventionHelper.ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
 
             if (fetchStrategy == null)
             {

src/DotNetToolkit.Repository.InMemory/Internal/InMemoryRepositoryContext.cs

@@ -40,11 +40,6 @@ internal class InMemoryRepositoryContext : IRepositoryContext
         /// </summary>
         public string DatabaseName { get; internal set; }
 
-        /// <summary>
-        /// Gets the item types in-memory that have not yet been saved. This collection is cleared after the context is saved.
-        /// </summary>
-        internal IEnumerable<Type> ItemTypes { get { return _items.Select(x => x.Entity.GetType()); } }
-
         /// <summary>
         /// Gets the repository context logger.
         /// </summary>
@@ -97,12 +92,6 @@ public void EnsureDeleted()
 
         #region Private Methods
 
-        private void ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(object[] keyValues) where TEntity : class
-        {
-            if (keyValues.Length != PrimaryKeyConventionHelper.GetPrimaryKeyPropertyInfos<TEntity>().Count())
-                throw new ArgumentException(DotNetToolkit.Repository.Properties.Resources.EntityPrimaryKeyValuesLengthMismatch, nameof(keyValues));
-        }
-
         private IQueryable<TEntity> AsQueryable<TEntity>() where TEntity : class
         {
             var entityType = typeof(TEntity);
@@ -327,7 +316,7 @@ public virtual QueryResult<TEntity> Find<TEntity>(IFetchQueryStrategy<TEntity> f
             if (keyValues == null)
                 throw new ArgumentNullException(nameof(keyValues));
 
-            ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
+            PrimaryKeyConventionHelper.ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(keyValues);
 
             var entityType = typeof(TEntity);
             var store = InMemoryCache.Instance.GetDatabaseStore(DatabaseName);

src/DotNetToolkit.Repository/Configuration/Conventions/PrimaryKeyConventionHelper.cs

@@ -224,6 +224,16 @@ public static void ThrowsIfInvalidPrimaryKeyDefinition<TEntity>(params Type[] ke
                 throw new InvalidOperationException(Resources.EntityPrimaryKeyTypesMismatch);
         }
 
+        /// <summary>
+        /// Throws an exception if the specified number of key values does not match the ones defined for the entity.
+        /// </summary>
+        /// <param name="keyValues"></param>
+        public static void ThrowsIfEntityPrimaryKeyValuesLengthMismatch<TEntity>(object[] keyValues) where TEntity : class
+        {
+            if (keyValues.Length != PrimaryKeyConventionHelper.GetPrimaryKeyPropertyInfos<TEntity>().Count())
+                throw new ArgumentException(DotNetToolkit.Repository.Properties.Resources.EntityPrimaryKeyValuesLengthMismatch, nameof(keyValues));
+        }
+
         /// <summary>
         /// Gets the primary key name checks.
         /// </summary>