Merge pull request #563 from johelvisguzman/issue562

Fixed crash when executing a dataset or a datatable in the ado.net context

Author: johelvisguzman

src/DotNetToolkit.Repository.AdoNet/DbHelper.cs

@@ -87,7 +87,7 @@ internal DbHelper(IRepositoryConventions conventions, string nameOrConnectionStr
                 "The connection string does not exist in your configuration file.");
 
             _conventions = conventions;
-            _factory = Internal.DbProviderFactories.GetFactory(css.ProviderName);
+            _factory = DbProviderFactories.GetFactory(css.ProviderName);
             _connectionString = css.ConnectionString;
             _ownsConnection = true;
         }
@@ -105,7 +105,7 @@ internal DbHelper(IRepositoryConventions conventions, string providerName, strin
             Guard.NotEmpty(connectionString, nameof(connectionString));
 
             _conventions = conventions;
-            _factory = Internal.DbProviderFactories.GetFactory(providerName);
+            _factory = DbProviderFactories.GetFactory(providerName);
             _connectionString = connectionString;
             _ownsConnection = true;
         }
@@ -121,6 +121,7 @@ internal DbHelper(IRepositoryConventions conventions, DbConnection existingConne
             Guard.NotNull(existingConnection, nameof(existingConnection));
 
             _conventions = conventions;
+            _factory = DbProviderFactories.GetFactory(existingConnection);
             _connection = existingConnection;
             _ownsConnection = false;
         }

src/DotNetToolkit.Repository.AdoNet/DotNetToolkit.Repository.AdoNet.csproj

@@ -3,34 +3,21 @@
   <Import Project="..\..\build\common.props" />
 
   <PropertyGroup>
-    <TargetFrameworks>net451;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net451</TargetFrameworks>
     <AssemblyName>DotNetToolkit.Repository.AdoNet</AssemblyName>
     <RootNamespace>DotNetToolkit.Repository.AdoNet</RootNamespace>
     <Description>A repository context provider for ADO.NET (for testing purposes only).</Description>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
-    <DefineConstants>NETCORE;NETSTANDARD;NETSTANDARD2_0</DefineConstants>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'$(TargetFramework)' == 'net451'">
-    <DefineConstants>NET45;NETFULL</DefineConstants>
-  </PropertyGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\DotNetToolkit.Repository\DotNetToolkit.Repository.csproj" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'net451'">
+  <ItemGroup>
     <Reference Include="System.Configuration" />
     <Reference Include="System.ComponentModel.DataAnnotations" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
-    <PackageReference Include="System.Data.SqlClient" Version="4.6.1" />
-    <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.1.0" />
-  </ItemGroup>
-
   <ItemGroup>
     <Compile Update="Properties\Resources.Designer.cs">
       <DesignTime>True</DesignTime>