Removed in-memory specific functionality from the primary key convention helper

Author: johelvisguzman

src/DotNetToolkit.Repository.InMemory/Internal/InMemoryRepositoryContext.cs

@@ -128,6 +128,43 @@ private object GeneratePrimaryKey(Type entityType)
             throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, Resources.EntityKeyValueTypeInvalid, entityType.FullName, propertyType));
         }
 
+        private static object GetPrimaryKeyValue(object obj)
+        {
+            if (obj == null)
+                throw new ArgumentNullException(nameof(obj));
+
+            return Combine(PrimaryKeyConventionHelper.GetPrimaryKeyValues(obj));
+        }
+
+        private static object Combine(object[] keyValues)
+        {
+            if (keyValues == null)
+                throw new ArgumentNullException(nameof(keyValues));
+
+            object key;
+
+            switch (keyValues.Length)
+            {
+                case 3:
+                {
+                    key = Tuple.Create(keyValues[0], keyValues[1], keyValues[2]);
+                    break;
+                }
+                case 2:
+                {
+                    key = Tuple.Create(keyValues[0], keyValues[1]);
+                    break;
+                }
+                default:
+                {
+                    key = keyValues[0];
+                    break;
+                }
+            }
+
+            return key;
+        }
+
         #endregion
 
         #region Implementation of IRepositoryContext
@@ -231,7 +268,7 @@ public override int SaveChanges()
                 while (_items.TryTake(out var entitySet))
                 {
                     var entityType = entitySet.Entity.GetType();
-                    var key = PrimaryKeyConventionHelper.GetPrimaryKeyValue(entitySet.Entity);
+                    var key = GetPrimaryKeyValue(entitySet.Entity);
 
                     if (!store.ContainsKey(entityType))
                         store[entityType] = new ConcurrentDictionary<object, object>();
@@ -304,7 +341,7 @@ public override QueryResult<TEntity> Find<TEntity>(IFetchQueryStrategy<TEntity>
             if (!store.ContainsKey(entityType))
                 return new QueryResult<TEntity>(default(TEntity));
 
-            var key = PrimaryKeyConventionHelper.Combine(keyValues);
+            var key = Combine(keyValues);
 
             store[entityType].TryGetValue(key, out object entity);
 

src/DotNetToolkit.Repository/Configuration/Conventions/PrimaryKeyConventionHelper.cs

@@ -107,51 +107,6 @@ public static object[] GetPrimaryKeyValues(object obj)
             return keyValues;
         }
 
-        /// <summary>
-        /// Gets the primary key value for the specified object. If the primary key is defined as a composite key, then the result will be returned as a tuple.
-        /// </summary>
-        /// <returns>The primary key value.</returns>
-        public static object GetPrimaryKeyValue(object obj)
-        {
-            if (obj == null)
-                throw new ArgumentNullException(nameof(obj));
-
-            return Combine(GetPrimaryKeyValues(obj));
-        }
-
-        /// <summary>
-        /// Merges the specified collection of key values into a tuple if there are more than one key; otherwise, it will return the single key object.
-        /// </summary>
-        /// <returns>The merged primary key value.</returns>
-        public static object Combine(object[] keyValues)
-        {
-            if (keyValues == null)
-                throw new ArgumentNullException(nameof(keyValues));
-
-            object key;
-
-            switch (keyValues.Length)
-            {
-                case 3:
-                    {
-                        key = Tuple.Create(keyValues[0], keyValues[1], keyValues[2]);
-                        break;
-                    }
-                case 2:
-                    {
-                        key = Tuple.Create(keyValues[0], keyValues[1]);
-                        break;
-                    }
-                default:
-                    {
-                        key = keyValues[0];
-                        break;
-                    }
-            }
-
-            return key;
-        }
-
         /// <summary>
         /// Returns a specification for getting an entity by it's primary key.
         /// </summary>