Merge pull request #463 from johelvisguzman/issue461

Added a new repository specific exception

Author: johelvisguzman

src/DotNetToolkit.Repository/Configuration/Options/RepositoryOptionsBuilder.cs

@@ -10,7 +10,6 @@
     using Mapper;
     using Properties;
     using System;
-    using System.IO;
     using System.Linq;
     using Utility;
 
@@ -78,7 +77,7 @@ public RepositoryOptionsBuilder([NotNull] IRepositoryOptions options)
         /// </summary>
         /// <param name="fileName">The name of the file to configure from.</param>
         /// <returns>The same builder instance.</returns>
-        /// <remarks>Any element that is defined in the config file can be resolved using the <see cref="DotNetToolkit.Repository.Internal.ConfigFile.ConfigurationProvider.SetDefaultFactory"/></remarks>
+        /// <remarks>Any element that is defined in the config file can be resolved using the <see cref="RepositoryDependencyResolver"/>.</remarks>
         public virtual RepositoryOptionsBuilder UseConfiguration([CanBeNull] string fileName = null)
         {
             const string SectionName = DotNetToolkit.Repository.Internal.ConfigFile.ConfigurationSection.SectionName;
@@ -91,7 +90,7 @@ public virtual RepositoryOptionsBuilder UseConfiguration([CanBeNull] string file
                 var exeConfiguration = System.Configuration.ConfigurationManager.OpenMappedExeConfiguration(fileMap, System.Configuration.ConfigurationUserLevel.None);
 
                 if (!exeConfiguration.HasFile)
-                    throw new FileNotFoundException("The file is not found.", fileName);
+                    throw new System.IO.FileNotFoundException("The file is not found.", fileName);
 
                 config = (DotNetToolkit.Repository.Internal.ConfigFile.ConfigurationSection)exeConfiguration.GetSection(SectionName);
             }
@@ -114,7 +113,7 @@ public virtual RepositoryOptionsBuilder UseConfiguration([CanBeNull] string file
         /// </summary>
         /// <param name="configuration">The configuration.</param>
         /// <returns>The same builder instance.</returns>
-        /// <remarks>Any element that is defined in the config file can be resolved using the <see cref="DotNetToolkit.Repository.Internal.ConfigFile.ConfigurationProvider.SetDefaultFactory"/></remarks>
+        /// <remarks>Any element that is defined in the config file can be resolved using the <see cref="RepositoryDependencyResolver"/>.</remarks>
         public virtual RepositoryOptionsBuilder UseConfiguration([NotNull]  Microsoft.Extensions.Configuration.IConfigurationRoot configuration)
         {
             Guard.NotNull(configuration, nameof(configuration));

src/DotNetToolkit.Repository/Properties/Resources.Designer.cs

@@ -168,4 +168,7 @@
   <data name="UnableToResolveTypeWithDependencyResolver_ConfigFile" xml:space="preserve">
     <value>Unable to resolve an instance for '{0}'. Please consider using the {1} to use an IOC container or provide additional parameters to create an instance for the specified type. For more information on DotNetToolkit.Repository configuration, visit the https://github.com/johelvisguzman/DotNetToolkit.Repository/wiki/Config-File-Setup.</value>
   </data>
+  <data name="RepositoryExceptionMessage" xml:space="preserve">
+    <value>An error has occurred while performing an operation within the repository. Please see inner exception for fault details.</value>
+  </data>
 </root>

src/DotNetToolkit.Repository/Properties/Resources.resx

@@ -80,11 +80,7 @@ public void Delete([NotNull] TKey1 key1, [NotNull] TKey2 key2, [NotNull] TKey3 k
 
             if (!TryDelete(key1, key2, key3))
             {
-                var ex = new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, Resources.EntityKeyNotFound, key1 + ", " + key2 + ", " + key3));
-
-                Logger.Error(ex);
-
-                throw ex;
+                InterceptError(() => new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, Resources.EntityKeyNotFound, key1 + ", " + key2 + ", " + key3)));
             }
 
             LogExecutedMethod(false);
@@ -2526,7 +2522,7 @@ protected void InterceptError([NotNull] Action action)
             }
             catch (Exception ex)
             {
-                Logger.Error(ex);
+                Logger.Error(new RepositoryException(ex));
 
                 throw;
             }
@@ -2546,7 +2542,7 @@ protected T InterceptError<T>([NotNull] Func<T> action)
             }
             catch (Exception ex)
             {
-                Logger.Error(ex);
+                Logger.Error(new RepositoryException(ex));
 
                 throw;
             }
@@ -2565,7 +2561,7 @@ protected async Task<T> InterceptErrorAsync<T>([NotNull] Func<Task<T>> action)
             }
             catch (Exception ex)
             {
-                Logger.Error(ex);
+                Logger.Error(new RepositoryException(ex));
 
                 throw;
             }
@@ -2584,7 +2580,7 @@ protected async Task InterceptErrorAsync([NotNull] Func<Task> action)
             }
             catch (Exception ex)
             {
-                Logger.Error(ex);
+                Logger.Error(new RepositoryException(ex));
 
                 throw;
             }

src/DotNetToolkit.Repository/RepositoryBase.cs

@@ -0,0 +1,46 @@
+namespace DotNetToolkit.Repository
+{
+    using System;
+    using System.Runtime.InteropServices;
+    using Properties;
+#if !NETSTANDARD1_3
+    using System.Runtime.Serialization;
+#endif
+
+    /// <summary>
+    /// Represents errors that occur during application execution.
+    /// </summary>
+    [ComVisible(true)]
+#if !NETSTANDARD1_3
+    [Serializable]
+#endif
+    public class RepositoryException : Exception
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RepositoryException" /> class.
+        /// </summary>
+        public RepositoryException() { }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RepositoryException" /> class with a specified error message.
+        /// </summary>
+        public RepositoryException(string message) : base(message) { }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RepositoryException" /> class with a specified error message and a reference to the inner exception that is the cause of this exception.
+        /// </summary>
+        public RepositoryException(string message, Exception inner) : base(message, inner) { }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RepositoryException" /> class with a reference to the inner exception that is the cause of this exception.
+        /// </summary>
+        public RepositoryException(Exception inner) : this(Resources.RepositoryExceptionMessage, inner) { }
+
+#if !NETSTANDARD1_3
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RepositoryException" /> class with serialized data.
+        /// </summary>
+        protected RepositoryException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+#endif
+    }
+}