Skip to content

Commit c66b924

Browse files
Lee EggebrotenJohn Doherty
authored andcommitted
Do not force browser to full screen.
Allow the driver generators to set the desired state.
1 parent f23f0a3 commit c66b924

File tree

4 files changed

+18
-5
lines changed

4 files changed

+18
-5
lines changed

runtime/chromeDriver.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
"use strict";
22
(function(){
33
var chromedriver = require('chromedriver');
4+
var selenium = require('selenium-webdriver');
45

56
module.exports = function () {
6-
return new selenium.Builder().withCapabilities({
7+
var driver = new selenium.Builder().withCapabilities({
78
browserName: 'chrome',
89
javascriptEnabled: true,
910
acceptSslCerts: true,
@@ -12,5 +13,9 @@
1213
},
1314
path: chromedriver.path
1415
}).build();
16+
17+
driver.manage().window().maximize();
18+
19+
return driver;
1520
}
1621
})();

runtime/firefoxDriver.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
"use strict";
22
(function(){
33
var firefox = require('geckodriver');
4+
var selenium = require('selenium-webdriver');
45

56
module.exports = function () {
6-
return new selenium.Builder().withCapabilities({
7+
var driver = new selenium.Builder().withCapabilities({
78
browserName: 'firefox',
89
javascriptEnabled: true,
910
acceptSslCerts: true,
1011
'webdriver.firefox.bin': firefox.path
1112
}).build();
13+
14+
driver.manage().window().maximize();
15+
16+
return driver;
1217
}
1318
})();

runtime/phantomDriver.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
"use strict";
22
(function(){
33
var phantomjs = require('phantomjs-prebuilt');
4+
var selenium = require('selenium-webdriver');
45

56
module.exports = function () {
6-
return new selenium.Builder().withCapabilities({
7+
var driver = new selenium.Builder().withCapabilities({
78
browserName: 'phantomjs',
89
javascriptEnabled: true,
910
acceptSslCerts: true,
1011
'phantomjs.binary.path': phantomjs.path
1112
}).build();
13+
14+
driver.manage().window().maximize();
15+
16+
return driver;
1217
}
1318
})();

runtime/world.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,6 @@ module.exports = function () {
131131
if (!global.driver) {
132132
global.driver = getDriverInstance();
133133
}
134-
135-
driver.manage().window().maximize();
136134
});
137135

138136
this.registerHandler('AfterFeatures', function (features, done) {

0 commit comments

Comments
 (0)