Skip to content

Commit 9b83c5c

Browse files
authored
Fix a bug when running batch_img --update in a venv (#43)
* Fix a bug when running 'batch_img --update' in a venv * Minor
1 parent f1f54ea commit 9b83c5c

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ uv pip install --upgrade batch_img
6666

6767
```
6868
✗ batch_img --version
69-
0.3.6
69+
0.3.7
7070
7171
7272
✗ batch_img auto ~/Documents

batch_img/common.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import itertools
88
import json
99
import subprocess
10+
import sys
1011
import tomllib
1112
from base64 import b64encode
1213
from concurrent.futures import ThreadPoolExecutor, as_completed
@@ -135,6 +136,9 @@ def update_package(pkg_name: str) -> str:
135136
return msg
136137
log.info(f"🔄 Updating {pkg_name} ...")
137138
cmd = f"uv pip install --upgrade {pkg_name}"
139+
if sys.prefix != sys.base_prefix:
140+
# inside a venv or virtualenv
141+
cmd = f"pip install --upgrade {pkg_name}"
138142
try:
139143
Common.run_cmd(cmd)
140144
msg = "✅ Update completed."

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ requires = ["setuptools>=80.0"]
44

55
[project]
66
name = "batch_img"
7-
version = "0.3.6"
7+
version = "0.3.7"
88
description = "Batch process (resize, rotate, remove background, remove GPS, add border, set transparency, auto do all) image files (HEIC, JPG, PNG)"
99
readme = "README.md"
1010
authors = [{ name = "John Liu", email = "rim2rim@gmail.com" }]

tests/test_common.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
_dir = dirname(__file__)
2121

2222

23-
@pytest.fixture(params=[(PKG_NAME, "0.3.6"), ("", "0.3.6")])
23+
@pytest.fixture(params=[(PKG_NAME, "0.3.7"), ("", "0.3.7")])
2424
def ver_data(request):
2525
return request.param
2626

@@ -36,7 +36,7 @@ def test_get_version(ver_data):
3636
(
3737
"0.9.9",
3838
PKG_NAME,
39-
f"🔔 Update available: 0.3.6 → 0.9.9\nRun '{PKG_NAME} --update'",
39+
f"🔔 Update available: 0.3.7 → 0.9.9\nRun '{PKG_NAME} --update'",
4040
),
4141
]
4242
)

0 commit comments

Comments
 (0)