Refactor FileUtilities.cs and add methods for absolute paths. (dotnet#13079)

### Context
PRs dotnet#12914 and dotnet#12868 showed that we need to be able to fix and
normalize `AbsolutePath`. Corresponding methods for strings live in
`FileUtilities.cs` that is a Shared file and cannot reference Framework
classes like `AbsolutePath`.

### Changes Made
- Moved some related functions to FrameworkFileUtilities class.
- Added the needed functions for `AbsolutePath`

### Testing
unit tests

Author: AR-May

src/Build.UnitTests/Construction/SolutionFile_OldParser_Tests.cs

@@ -2555,7 +2555,7 @@ public void AbsolutePathShouldHandleUriLikeRelativePathsOnUnix()
 
         /// <summary>
         /// Test to verify that the fix for issue #1769 works by directly testing
-        /// FileUtilities.FixFilePath integration in AbsolutePath.
+        /// FrameworkFileUtilities.FixFilePath integration in AbsolutePath.
         /// This test simulates scenarios where intermediate path processing might
         /// leave backslashes in the AbsolutePath on Unix systems.
         /// </summary>

src/Build.UnitTests/Evaluation/Expander_Tests.cs

@@ -3455,7 +3455,7 @@ public void PropertyFunctionStaticMethodDirectoryNameOfFileAbove()
 
                 string result = expander.ExpandIntoStringAndUnescape(@"$([MSBuild]::GetDirectoryNameOfFileAbove($(StartingDirectory), $(FileToFind)))", ExpanderOptions.ExpandProperties, MockElementLocation.Instance);
 
-                Assert.Equal(Microsoft.Build.Shared.FileUtilities.EnsureTrailingSlash(tempPath), Microsoft.Build.Shared.FileUtilities.EnsureTrailingSlash(result));
+                Assert.Equal(FrameworkFileUtilities.EnsureTrailingSlash(tempPath), FrameworkFileUtilities.EnsureTrailingSlash(result));
 
                 result = expander.ExpandIntoStringAndUnescape(@"$([MSBuild]::GetDirectoryNameOfFileAbove($(StartingDirectory), Hobbits))", ExpanderOptions.ExpandProperties, MockElementLocation.Instance);
 

src/Build/BackEnd/Components/FileAccesses/FileAccessManager.cs

@@ -9,6 +9,7 @@
 using Microsoft.Build.BackEnd;
 using Microsoft.Build.Execution;
 using Microsoft.Build.Experimental.FileAccess;
+using Microsoft.Build.Framework;
 using Microsoft.Build.Shared;
 using Microsoft.Build.Shared.FileSystem;
 
@@ -44,7 +45,7 @@ public void InitializeComponent(IBuildComponentHost host)
         {
             _scheduler = host.GetComponent(BuildComponentType.Scheduler) as IScheduler;
             _configCache = host.GetComponent(BuildComponentType.ConfigCache) as IConfigCache;
-            _tempDirectory = FileUtilities.EnsureNoTrailingSlash(FileUtilities.TempFileDirectory);
+            _tempDirectory = FrameworkFileUtilities.EnsureNoTrailingSlash(FileUtilities.TempFileDirectory);
         }
 
         public void ShutdownComponent()

src/Build/BackEnd/Components/RequestBuilder/TargetUpToDateChecker.cs

@@ -978,7 +978,7 @@ internal static bool IsAnyOutOfDate<T>(out DependencyAnalysisLogDetail dependenc
             //         possibly the outputs list isn't actually the shortest list. However it always is the shortest
             //         in the cases I've seen, and adding this optimization would make the code hard to read.
 
-            string oldestOutput = EscapingUtilities.UnescapeAll(FileUtilities.FixFilePath(outputs[0].ToString()));
+            string oldestOutput = EscapingUtilities.UnescapeAll(FrameworkFileUtilities.FixFilePath(outputs[0].ToString()));
             ErrorUtilities.ThrowIfTypeDoesNotImplementToString(outputs[0]);
 
             DateTime oldestOutputFileTime = DateTime.MinValue;
@@ -996,15 +996,15 @@ internal static bool IsAnyOutOfDate<T>(out DependencyAnalysisLogDetail dependenc
             if (oldestOutputFileTime == DateTime.MinValue)
             {
                 // First output is missing: we must build the target
-                string arbitraryInput = EscapingUtilities.UnescapeAll(FileUtilities.FixFilePath(inputs[0].ToString()));
+                string arbitraryInput = EscapingUtilities.UnescapeAll(FrameworkFileUtilities.FixFilePath(inputs[0].ToString()));
                 ErrorUtilities.ThrowIfTypeDoesNotImplementToString(inputs[0]);
                 dependencyAnalysisDetailEntry = new DependencyAnalysisLogDetail(arbitraryInput, oldestOutput, null, null, OutofdateReason.MissingOutput);
                 return true;
             }
 
             for (int i = 1; i < outputs.Count; i++)
             {
-                string candidateOutput = EscapingUtilities.UnescapeAll(FileUtilities.FixFilePath(outputs[i].ToString()));
+                string candidateOutput = EscapingUtilities.UnescapeAll(FrameworkFileUtilities.FixFilePath(outputs[i].ToString()));
                 ErrorUtilities.ThrowIfTypeDoesNotImplementToString(outputs[i]);
                 DateTime candidateOutputFileTime = DateTime.MinValue;
                 try
@@ -1022,7 +1022,7 @@ internal static bool IsAnyOutOfDate<T>(out DependencyAnalysisLogDetail dependenc
                 {
                     // An output is missing: we must build the target
                     string arbitraryInput =
-                        EscapingUtilities.UnescapeAll(FileUtilities.FixFilePath(inputs[0].ToString()));
+                        EscapingUtilities.UnescapeAll(FrameworkFileUtilities.FixFilePath(inputs[0].ToString()));
                     ErrorUtilities.ThrowIfTypeDoesNotImplementToString(inputs[0]);
                     dependencyAnalysisDetailEntry = new DependencyAnalysisLogDetail(arbitraryInput, candidateOutput, null, null, OutofdateReason.MissingOutput);
                     return true;
@@ -1039,7 +1039,7 @@ internal static bool IsAnyOutOfDate<T>(out DependencyAnalysisLogDetail dependenc
             // Now compare the oldest output with each input and break out if we find one newer.
             foreach (T input in inputs)
             {
-                string unescapedInput = EscapingUtilities.UnescapeAll(FileUtilities.FixFilePath(input.ToString()));
+                string unescapedInput = EscapingUtilities.UnescapeAll(FrameworkFileUtilities.FixFilePath(input.ToString()));
                 ErrorUtilities.ThrowIfTypeDoesNotImplementToString(input);
                 DateTime inputFileTime = DateTime.MaxValue;
                 try
@@ -1127,8 +1127,8 @@ private void RecordUniqueInputsAndOutputs<T>(IList<T> inputs, IList<T> outputs)
         /// <returns>true, if "input" is newer than "output"</returns>
         private bool IsOutOfDate(string input, string output, string inputItemName, string outputItemName)
         {
-            input = EscapingUtilities.UnescapeAll(FileUtilities.FixFilePath(input));
-            output = EscapingUtilities.UnescapeAll(FileUtilities.FixFilePath(output));
+            input = EscapingUtilities.UnescapeAll(FrameworkFileUtilities.FixFilePath(input));
+            output = EscapingUtilities.UnescapeAll(FrameworkFileUtilities.FixFilePath(output));
             ProjectErrorUtilities.VerifyThrowInvalidProject(input.AsSpan().IndexOfAny(MSBuildConstants.InvalidPathChars) < 0, _project.ProjectFileLocation, "IllegalCharactersInFileOrDirectory", input, inputItemName);
             ProjectErrorUtilities.VerifyThrowInvalidProject(output.AsSpan().IndexOfAny(MSBuildConstants.InvalidPathChars) < 0, _project.ProjectFileLocation, "IllegalCharactersInFileOrDirectory", output, outputItemName);
             bool outOfDate = (CompareLastWriteTimes(input, output, out bool inputDoesNotExist, out bool outputDoesNotExist) == 1) || inputDoesNotExist;

src/Build/BackEnd/Components/SdkResolution/SdkResolverManifest.cs

@@ -5,6 +5,7 @@
 using System.IO;
 using System.Text.RegularExpressions;
 using System.Xml;
+using Microsoft.Build.Framework;
 using Microsoft.Build.Shared;
 
 #nullable disable
@@ -79,7 +80,7 @@ internal static SdkResolverManifest Load(string filePath, string manifestFolder)
                     {
                         SdkResolverManifest manifest = ParseSdkResolverElement(reader, filePath);
 
-                        manifest.Path = FileUtilities.FixFilePath(manifest.Path);
+                        manifest.Path = FrameworkFileUtilities.FixFilePath(manifest.Path);
                         if (!System.IO.Path.IsPathRooted(manifest.Path))
                         {
                             manifest.Path = System.IO.Path.Combine(manifestFolder, manifest.Path);

src/Build/Construction/ProjectImportElement.cs

@@ -52,7 +52,7 @@ internal ProjectImportElement(XmlElementWithLocation xmlElement, ProjectRootElem
         /// </summary>
         public string Project
         {
-            get => FileUtilities.FixFilePath(GetAttributeValue(XMakeAttributes.project));
+            get => FrameworkFileUtilities.FixFilePath(GetAttributeValue(XMakeAttributes.project));
             set
             {
                 ErrorUtilities.VerifyThrowArgumentLength(value, XMakeAttributes.project);
@@ -71,7 +71,7 @@ public string Project
         /// </summary>
         public string Sdk
         {
-            get => FileUtilities.FixFilePath(GetAttributeValue(XMakeAttributes.sdk));
+            get => FrameworkFileUtilities.FixFilePath(GetAttributeValue(XMakeAttributes.sdk));
             set
             {
                 ErrorUtilities.VerifyThrowArgumentLength(value, XMakeAttributes.sdk);

src/Build/Construction/ProjectRootElement.cs

@@ -1256,7 +1256,7 @@ public ProjectTargetElement AddTarget(string name)
         /// </summary>
         public ProjectUsingTaskElement AddUsingTask(string name, string assemblyFile, string assemblyName)
         {
-            ProjectUsingTaskElement usingTask = CreateUsingTaskElement(name, FileUtilities.FixFilePath(assemblyFile), assemblyName);
+            ProjectUsingTaskElement usingTask = CreateUsingTaskElement(name, FrameworkFileUtilities.FixFilePath(assemblyFile), assemblyName);
             AppendChild(usingTask);
 
             return usingTask;

src/Build/Construction/ProjectUsingTaskElement.cs

@@ -3,7 +3,7 @@
 
 using System;
 using System.Diagnostics;
-
+using Microsoft.Build.Framework;
 using Microsoft.Build.ObjectModelRemoting;
 using Microsoft.Build.Shared;
 
@@ -48,14 +48,14 @@ private ProjectUsingTaskElement(XmlElementWithLocation xmlElement, ProjectRootEl
         /// </summary>
         public string AssemblyFile
         {
-            get => FileUtilities.FixFilePath(
+            get => FrameworkFileUtilities.FixFilePath(
                 GetAttributeValue(XMakeAttributes.assemblyFile));
 
             set
             {
                 ErrorUtilities.VerifyThrowArgumentLength(value, XMakeAttributes.assemblyName);
                 ErrorUtilities.VerifyThrowInvalidOperation(String.IsNullOrEmpty(AssemblyName), "OM_EitherAttributeButNotBoth", ElementName, XMakeAttributes.assemblyFile, XMakeAttributes.assemblyName);
-                value = FileUtilities.FixFilePath(value);
+                value = FrameworkFileUtilities.FixFilePath(value);
                 SetOrRemoveAttribute(XMakeAttributes.assemblyFile, value, "Set usingtask AssemblyFile {0}", value);
             }
         }
@@ -249,7 +249,7 @@ internal static ProjectUsingTaskElement CreateDisconnected(string taskName, stri
 
             if (!String.IsNullOrEmpty(assemblyFile))
             {
-                usingTask.AssemblyFile = FileUtilities.FixFilePath(assemblyFile);
+                usingTask.AssemblyFile = FrameworkFileUtilities.FixFilePath(assemblyFile);
             }
             else
             {

src/Build/Construction/Solution/SolutionProjectGenerator.cs

@@ -1308,7 +1308,7 @@ private string GetMetaprojectName(ProjectInSolution project)
                 baseName = project.ProjectName;
             }
 
-            baseName = FileUtilities.EnsureNoTrailingSlash(baseName);
+            baseName = FrameworkFileUtilities.EnsureNoTrailingSlash(baseName);
 
             return GetMetaprojectName(baseName);
         }

src/Build/Definition/Toolset.cs

@@ -13,9 +13,8 @@
 using Microsoft.Build.Collections;
 using Microsoft.Build.Construction;
 using Microsoft.Build.Execution;
-#if NET
 using Microsoft.Build.Framework;
-#endif
+
 using Microsoft.Build.Internal;
 using Microsoft.Build.Shared;
 using Microsoft.Build.Shared.FileSystem;
@@ -367,7 +366,7 @@ private set
                 // technically hurt anything, but it doesn't look nice.)
                 string toolsPathToUse = value;
 
-                if (FileUtilities.EndsWithSlash(toolsPathToUse))
+                if (FrameworkFileUtilities.EndsWithSlash(toolsPathToUse))
                 {
                     string rootPath = Path.GetPathRoot(Path.GetFullPath(toolsPathToUse));