Skip to content

Commit d5a2b44

Browse files
committed
Upgrade/Install: Disable maintenance mode when core auto-update fails.
In [58128], additional maintenance mode calls were added to the automatic updates process. However, there is an early return if a 'core' automatic update fails. Maintenance mode isn't disabled until later in the `WP_Automatic_Updater::update()` method. This means that maintenance mode may continue to be enabled despite the core update being treated as a skipped update. This disables maintenance mode before the early return. Follow-up to [58128]. Props costdev, hellofromTonya, peterwilsoncc. Fixes #61459. See #58281. git-svn-id: https://develop.svn.wordpress.org/trunk@58436 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 199bc9d commit d5a2b44

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/wp-admin/includes/class-wp-automatic-updater.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,9 @@ public function update( $type, $item ) {
511511
&& ( 'up_to_date' === $upgrade_result->get_error_code()
512512
|| 'locked' === $upgrade_result->get_error_code() )
513513
) {
514+
// Allow visitors to browse the site again.
515+
$upgrader->maintenance_mode( false );
516+
514517
/*
515518
* These aren't actual errors, treat it as a skipped-update instead
516519
* to avoid triggering the post-core update failure routines.

0 commit comments

Comments
 (0)