Skip to content

Commit ff362c2

Browse files
committed
feat(node): updating node to 22.17.1
1 parent 7fd193b commit ff362c2

File tree

11 files changed

+278
-397
lines changed

11 files changed

+278
-397
lines changed

.claude/settings.local.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@
2222
"Bash(~/.kit/bin/kit:*)",
2323
"Bash(pnpm ls:*)",
2424
"Bash(NODE_ENV=test pnpm ava src/lib/ai-mcp.test.ts --match \"*global.ai works with MCP tools*\")",
25-
"Bash(KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.9.0/bin/node ~/.kit/bin/kit ~/.kenv/scripts/ai-mcp-api-diagnostic.ts)",
26-
"Bash(DEBUG_AI=1 KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.9.0/bin/node ~/.kit/bin/kit ~/.kenv/scripts/ai-mcp-api-diagnostic.ts)",
27-
"Bash(KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.9.0/bin/node ~/.kit/bin/kit ~/.kenv/scripts/test-mcp-tool-directly.ts)",
28-
"Bash(KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.9.0/bin/node ~/.kit/bin/kit ~/.kenv/scripts/list-all-mcp-tools.ts)",
25+
"Bash(KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.17.1/bin/node ~/.kit/bin/kit ~/.kenv/scripts/ai-mcp-api-diagnostic.ts)",
26+
"Bash(DEBUG_AI=1 KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.17.1/bin/node ~/.kit/bin/kit ~/.kenv/scripts/ai-mcp-api-diagnostic.ts)",
27+
"Bash(KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.17.1/bin/node ~/.kit/bin/kit ~/.kenv/scripts/test-mcp-tool-directly.ts)",
28+
"Bash(KIT_NODE_PATH=/Users/johnlindquist/Library/pnpm/nodejs/22.17.1/bin/node ~/.kit/bin/kit ~/.kenv/scripts/list-all-mcp-tools.ts)",
2929
"Bash(mv:*)",
3030
"Bash(pnpm add:*)",
3131
"Bash(node:*)",
3232
"Bash(pnpm verify:*)"
3333
],
3434
"deny": []
3535
}
36-
}
36+
}

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- name: Install Node.js
3838
uses: actions/setup-node@v4
3939
with:
40-
node-version: 22.9.0
40+
node-version: 22.17.1
4141
cache: "pnpm"
4242

4343
- name: Check node $PATH version
@@ -108,7 +108,7 @@ jobs:
108108
- name: Install Node.js
109109
uses: actions/setup-node@v4
110110
with:
111-
node-version: 22.9.0
111+
node-version: 22.17.1
112112
cache: "pnpm"
113113

114114
- name: Build Kit
@@ -218,7 +218,7 @@ jobs:
218218
- name: Install Node.js
219219
uses: actions/setup-node@v4
220220
with:
221-
node-version: 22.9.0
221+
node-version: 22.17.1
222222
cache: "pnpm"
223223

224224
- name: Build Kit

.npmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
registry=https://registry.npmjs.org
22
install-links=false
33
save-exact=true
4-
use-node-version=22.9.0
4+
use-node-version=22.17.1
55
dangerously-allow-all-builds=true

biome.json

Lines changed: 28 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,47 @@
11
{
2-
"$schema": "https://biomejs.dev/schemas/1.9.0/schema.json",
2+
"$schema": "https://biomejs.dev/schemas/2.1.2/schema.json",
33
"vcs": {
44
"enabled": true,
55
"clientKind": "git",
66
"useIgnoreFile": true,
77
"defaultBranch": "main"
88
},
9-
"organizeImports": {
10-
"ignore": ["assets"],
11-
"enabled": true
9+
"files": {
10+
"includes": [
11+
"src/**/*.ts",
12+
"!.cache/**",
13+
"!.history/**",
14+
"!.npm-cache/**",
15+
"!node_modules/**",
16+
"!.vscode/**",
17+
"!assets/**",
18+
"!src/main/logs.ts"
19+
]
1220
},
1321
"linter": {
14-
"ignore": ["assets"],
15-
"enabled": true,
22+
"includes": ["src/**/*.ts"],
1623
"rules": {
17-
"all": true,
24+
"recommended": true,
1825
"a11y": {
19-
"all": false
26+
"recommended": false
2027
},
2128
"complexity": {
2229
"noExcessiveCognitiveComplexity": "off",
23-
"noForEach": "off"
30+
"noForEach": "warn",
31+
"useArrowFunction": "off"
2432
},
2533
"correctness": {
34+
"noUndeclaredDependencies": "off",
2635
"noUndeclaredVariables": "off",
2736
"noConstantCondition": "off",
2837
"noUnusedVariables": "off",
2938
"noUnusedImports": "off",
3039
"noNodejsModules": "off",
31-
"useExhaustiveDependencies": "off"
40+
"useExhaustiveDependencies": "off",
41+
"useImportExtensions": "off"
3242
},
3343
"style": {
44+
"noNamespace": "off",
3445
"noDefaultExport": "off",
3546
"noParameterAssign": "off",
3647
"useNamingConvention": "off",
@@ -39,7 +50,6 @@
3950
"useTemplate": "off",
4051
"useForOf": "off",
4152
"useLiteralEnumMembers": "off",
42-
"useConst": "off",
4353
"useFilenamingConvention": {
4454
"level": "error",
4555
"options": {
@@ -54,46 +64,28 @@
5464
"suspicious": {
5565
"noEmptyBlockStatements": "off",
5666
"noDebugger": "off",
57-
"noConsoleLog": "off",
67+
"noConsole": "off",
5868
"noExplicitAny": "off",
5969
"noAssignInExpressions": "off",
60-
"noImplicitAnyLet": "off"
61-
},
62-
"security": {
63-
"noDangerouslySetInnerHtml": "off"
70+
"noImplicitAnyLet": "off",
71+
"noReactSpecificProps": "off"
6472
}
6573
}
6674
},
6775
"formatter": {
6876
"enabled": true,
69-
"include": [
70-
"**/*.ts",
71-
"**/*.js",
72-
"**/*.jsx",
73-
"**/*.tsx",
74-
"**/*.css",
75-
"**/*.json"
76-
],
7777
"indentStyle": "space",
7878
"indentWidth": 2,
79-
"lineWidth": 120,
80-
"ignore": [
81-
".cache",
82-
".history",
83-
".npm-cache",
84-
"node_modules",
85-
".vscode",
86-
"assets"
87-
]
79+
"lineWidth": 120
8880
},
8981
"javascript": {
9082
"formatter": {
9183
"enabled": true,
9284
"quoteStyle": "single",
93-
"semicolons": "asNeeded",
85+
"trailingCommas": "all",
86+
"semicolons": "always",
9487
"bracketSpacing": true,
95-
"arrowParentheses": "always",
96-
"trailingCommas": "none"
88+
"arrowParentheses": "always"
9789
}
9890
},
9991
"json": {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@
216216
]
217217
},
218218
"volta": {
219-
"node": "22.9.0"
219+
"node": "22.17.1"
220220
},
221221
"config": {
222222
"commitizen": {

pnpm-lock.yaml

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/api/kit.ts

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -690,15 +690,17 @@ global.prepFlags = (flagsOptions: FlagsObject): FlagsObject => {
690690
if (key === 'order') continue
691691
if (key === 'sortChoicesKey') continue
692692

693+
// Strip non-serializable functions before sending to avoid IPC serialization issues
694+
const { onAction, condition, preview, ...rest } = value ?? {}
693695
let validFlag = {
694-
...value,
696+
...rest,
695697
name: value?.name || key,
696698
shortcut: value?.shortcut || '',
697699
description: value?.description || '',
698700
value: key,
699701
bar: value?.bar || '',
700-
preview: value?.preview || '',
701-
hasAction: Boolean(value?.onAction)
702+
preview: typeof preview === 'string' ? preview : '',
703+
hasAction: Boolean(onAction)
702704
}
703705
validFlags[key] = validFlag
704706

@@ -724,7 +726,13 @@ global.prepFlags = (flagsOptions: FlagsObject): FlagsObject => {
724726
choice.group = value.group
725727
}
726728

727-
global.__kitActionsMap.set(value?.name || key, choice)
729+
// Use the flag key (not the display name) as the map key, since that's what the UI sends back
730+
global.__kitActionsMap.set(key, choice)
731+
// console.log(`[SDK] Storing action in map with key: ${key}`, {
732+
// name: choice.name,
733+
// onAction: typeof value?.onAction,
734+
// shortcut: choice.shortcut
735+
// })
728736
}
729737

730738
return validFlags
@@ -740,6 +748,15 @@ global.setFlags = async (flags: FlagsObject, options = {}) => {
740748
}
741749
}
742750
// TODO: Move props from FlagsObject like "order", "sortChoicesKey" to the options
751+
// console.log(`[SDK] Sending flags to app:`, {
752+
// flagKeys: Object.keys(flagsMessage.flags),
753+
// flagsWithHasAction: Object.entries(flagsMessage.flags).map(([k, v]) => ({
754+
// key: k,
755+
// name: (v as any).name,
756+
// hasAction: (v as any).hasAction,
757+
// shortcut: (v as any).shortcut
758+
// }))
759+
// })
743760
await global.sendWait(Channel.SET_FLAGS, flagsMessage)
744761
}
745762

@@ -1049,7 +1066,8 @@ export let actions: Action[] = [
10491066
description: 'Search for a script by contents',
10501067
shortcut: `${cmd}+f`,
10511068
onAction: async () => {
1052-
global.setFlags({})
1069+
// Don't clear all flags - preserve existing action flags
1070+
// global.setFlags({})
10531071
await run(kitPath('cli', 'find.js'))
10541072
},
10551073
group: 'Script Actions'

src/cli/add-kenv-to-profile.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { existsSync } from "fs"
22

33
//Description: Adds the .kenv bin dir to your $PATH
4-
export {}
4+
export { }
55

66
let kenv = await selectKenv()
77

@@ -12,7 +12,7 @@ if (process.platform === "win32") {
1212
2. Click the "Environment Variables..." button.
1313
3. Under the "System Variables" section, scroll down and highlight the "Path" variable, then click the "Edit..." button.
1414
4. In the next screen, click "New" and then "Browse" to find the ${kenvPath(
15-
"bint"
15+
"bin"
1616
)} directory.
1717
5. Click "OK" to close the dialogs.
1818
6. Close the terminal and open it again.

src/setup/link-kenv-to-kit.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ await cli("install", `"${kitPath()}"`)
4343
let defaultPackageJson = {
4444
type: "module",
4545
engines: {
46-
node: "22.9.0",
46+
node: "22.17.1",
4747
},
4848
devDependencies: {
4949
"@johnlindquist/kit": `link:${(process.env.KIT || home(".kit"))?.replace(/\\/g, '/')}`,
@@ -66,4 +66,4 @@ if (!packageJsonObj.type) {
6666
)
6767
}
6868

69-
export {}
69+
export { }

src/setup/setup-pnpm.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ try {
6363
)
6464
try {
6565
await exec(
66-
"pnpm config set use-node-version 22.9.0 --location project",
66+
"pnpm config set use-node-version 22.17.1 --location project",
6767
{
6868
cwd: kenvPath(),
6969
}
@@ -83,4 +83,4 @@ try {
8383
process.exit(1)
8484
}
8585

86-
export {}
86+
export { }

0 commit comments

Comments
 (0)