Skip to content

Commit 49dba1a

Browse files
update cran comments and readme. remove plos link which fails
1 parent a0b8424 commit 49dba1a

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

README.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ signals %>%
140140
This package makes no attempt to identify or highlight 'trends' (consecutively increasing or decreasing points) or shorter 'shifts' of runs below the median.
141141
In 8 years of working with QI data, I very rarely see trends, and when they do appear, they tend to result after a period of process degradation, when the process begins to return back to its natural median state.
142142

143-
In addition, [research by qicharts2 author Jacob Anhoej shows that the trend rule is not reliable](https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0121349). There are no plans to add tests to identify trends to the package functionality.
143+
In addition, research by qicharts2 author Jacob Anhoej shows that the trend rule is not reliable. There are no plans to add tests to identify trends to the package.
144144

145145
However, analysts are often asked to apply all the run chart rules.
146146
In this case, if you need to apply the rules for trend , and still have the ability to revise run chart medians, you should consider using [the runchart package by Joseph Adams](https://github.com/jsphdms/runchart).

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,11 +162,9 @@ see trends, and when they do appear, they tend to result after a period
162162
of process degradation, when the process begins to return back to its
163163
natural median state.
164164

165-
In addition, [research by qicharts2 author Jacob Anhoej shows that the
166-
trend rule is not
167-
reliable](https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0121349).
168-
There are no plans to add tests to identify trends to the package
169-
functionality.
165+
In addition, research by qicharts2 author Jacob Anhoej shows that the
166+
trend rule is not reliable. There are no plans to add tests to identify
167+
trends to the package.
170168

171169
However, analysts are often asked to apply all the run chart rules.
172170
In this case, if you need to apply the rules for trend , and still have

cran-comments.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
This is a resubmission. In this version I have:
44

5-
* fully specified the url in readme.md to include the protocol (https://johnmackintosh.github.io/runcharter)
5+
* fully specified the url in readme.md to include the protocol and trailing slash (https://johnmackintosh.github.io/runcharter/)
66

77

88
## Test environments

0 commit comments

Comments
 (0)