Merge bitcoin-core/gui-qml#450: Add Multiple Recipients option to the Send form

676db23 Fix typo in MultipleSendReview (Johnny)
69c8d52 qml: Change IconButton disabled color to neutral4 (johnny9)
01affb5 qml: Disable multipleRecipients after clearing the recipients list (johnny9)
2b1d39d qml: Add a recipient when multiple recipients are enabled (johnny9)
2093017 qml: Connect Recipient label to Note to self input (johnny9)
ee08381 qml: New recipients use current's units (johnny9)
1e4159a qml: When multipleRecipients is disabled, clearToFront of the list (johnny9)
5114425 qml: Split amount and display updating for Bitcoin amount input (johnny9)
e29622c qml: Restrict Recipients to 25 (johnny9)
4872600 qml: Handle removal of first recipient properly (johnny9)
4d040e9 qml: Clear Send form after sending transaciton (johnny9)
33502e4 qml: Commit Recipient amount when active focus is lost (johnny9)
8a1dbe0 qml: Add total calculation to SendRecipientsListModel (johnny9)
2de4f26 qml: Cleanup BitcoinAmount (johnny9)
b94f2bb qml: Replace NavButton with IconButton in Send (johnny9)
d7d1d45 qml: Add plus big filled icon (johnny9)
2552e3f qml: Add MultipleSendReview page (johnny9)
bd3fac2 qml: Prepare transaction with recipients list (johnny9)
fdbaf00 qml: Add remove button to multiple recipients (johnny9)
1a8b696 qml: Reduce size of recipient selectors (johnny9)
34706bb qml: Add Multiple Recipients bar to Send form (johnny9)
191edb7 qml: Add Multiple Recipients toggle to Send menu (johnny9)
0cb338c qml: Introduce SendRecipientsListModel (johnny9)

Pull request description:

  This change introduces the multiple recipients controls to the Send form. It is enabled in the ellipses option menu by toggling on "Enable Multiple Recipients". This is stored as a QSetting for the user.

  This PR depends on #448 which contains the

  ![Screenshot from 2025-05-08 11-51-34](https://github.com/user-attachments/assets/c1756abd-b485-4cf1-b6a8-2c0fa91ff05a)
   first implementation of the Send options menu.
  ![Screenshot from 2025-05-08 11-51-26](https://github.com/user-attachments/assets/6ce9dd39-1b12-49dd-af50-2724fabbb8b9)

Top commit has no ACKs.

Tree-SHA512: 2f8f9e76eea107a898015966c6f838f303d7364852a26d0ab74dfb76bbf756563a9d29b0d6572c39b78ca23dc012c93af0fdcfa5d30f6bee693f8ac34c3b0c64

Author: hebasto

qml/bitcoin_qml.qrc

@@ -31,12 +31,12 @@
         <file>controls/FocusBorder.qml</file>
         <file>controls/Header.qml</file>
         <file>controls/Icon.qml</file>
+        <file>controls/IconButton.qml</file>
         <file>controls/InformationPage.qml</file>
         <file>controls/IPAddressValueInput.qml</file>
         <file>controls/KeyValueRow.qml</file>
         <file>controls/LabeledTextInput.qml</file>
         <file>controls/LabeledCoinControlButton.qml</file>
-        <file>controls/EllipsisMenuButton.qml</file>
         <file>controls/EllipsisMenuToggleItem.qml</file>
         <file>controls/NavButton.qml</file>
         <file>controls/NavigationBar.qml</file>
@@ -91,6 +91,7 @@
         <file>pages/wallet/CreatePassword.qml</file>
         <file>pages/wallet/CreateWalletWizard.qml</file>
         <file>pages/wallet/DesktopWallets.qml</file>
+        <file>pages/wallet/MultipleSendReview.qml</file>
         <file>pages/wallet/RequestPayment.qml</file>
         <file>pages/wallet/Send.qml</file>
         <file>pages/wallet/SendResult.qml</file>
@@ -128,6 +129,7 @@
         <file alias="network-dark">res/icons/network-dark.png</file>
         <file alias="network-light">res/icons/network-light.png</file>
         <file alias="plus">res/icons/plus.png</file>
+        <file alias="plus-big-filled">res/icons/plus-big-filled.png</file>
         <file alias="pending">res/icons/pending.png</file>
         <file alias="shutdown">res/icons/shutdown.png</file>
         <file alias="singlesig-wallet">res/icons/singlesig-wallet.png</file>

qml/bitcoinamount.cpp

@@ -1,4 +1,4 @@
-// Copyright (c) 2024 The Bitcoin Core developers
+// Copyright (c) 2024-2025 The Bitcoin Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -7,19 +7,9 @@
 #include <QRegExp>
 #include <QStringList>
 
-
-BitcoinAmount::BitcoinAmount(QObject *parent) : QObject(parent)
+BitcoinAmount::BitcoinAmount(QObject* parent)
+    : QObject(parent)
 {
-    m_unit = Unit::BTC;
-}
-
-int BitcoinAmount::decimals(Unit unit)
-{
-    switch (unit) {
-    case Unit::BTC: return 8;
-    case Unit::SAT: return 0;
-    } // no default case, so the compiler can warn about missing cases
-    assert(false);
 }
 
 QString BitcoinAmount::sanitize(const QString &text)
@@ -43,6 +33,30 @@ QString BitcoinAmount::sanitize(const QString &text)
     return result;
 }
 
+qint64 BitcoinAmount::satoshi() const
+{
+    return m_satoshi;
+}
+
+void BitcoinAmount::setSatoshi(qint64 new_amount)
+{
+    m_isSet = true;
+    if (m_satoshi != new_amount) {
+        m_satoshi = new_amount;
+        Q_EMIT amountChanged();
+    }
+}
+
+void BitcoinAmount::clear()
+{
+    if (!m_isSet && m_satoshi == 0) {
+        return;
+    }
+    m_satoshi = 0;
+    m_isSet = false;
+    Q_EMIT amountChanged();
+}
+
 BitcoinAmount::Unit BitcoinAmount::unit() const
 {
     return m_unit;
@@ -52,103 +66,94 @@ void BitcoinAmount::setUnit(const Unit unit)
 {
     m_unit = unit;
     Q_EMIT unitChanged();
+    Q_EMIT displayChanged();
 }
 
 QString BitcoinAmount::unitLabel() const
 {
     switch (m_unit) {
     case Unit::BTC: return "₿";
-    case Unit::SAT: return "Sat";
+    case Unit::SAT: return "sat";
     }
     assert(false);
 }
 
-QString BitcoinAmount::amount() const
+void BitcoinAmount::flipUnit()
 {
-    return m_amount;
+    if (m_unit == Unit::BTC) {
+        m_unit = Unit::SAT;
+    } else {
+        m_unit = Unit::BTC;
+    }
+    Q_EMIT unitChanged();
+    Q_EMIT displayChanged();
 }
 
-QString BitcoinAmount::satoshiAmount() const
+QString BitcoinAmount::satsToBtcString(qint64 sat)
 {
-    return toSatoshis(m_amount);
-}
+    const bool negative = sat < 0;
+    qint64 absSat = negative ? -sat : sat;
 
-void BitcoinAmount::setAmount(const QString& new_amount)
-{
-    m_amount = sanitize(new_amount);
-    Q_EMIT amountChanged();
+    const qint64 wholePart = absSat / COIN;
+    const qint64 fracInt = absSat % COIN;
+    QString fracPart = QString("%1").arg(fracInt, 8, 10, QLatin1Char('0'));
+
+    QString result = QString::number(wholePart) + '.' + fracPart;
+    if (negative) {
+        result.prepend('-');
+    }
+    return result;
 }
 
-QString BitcoinAmount::toSatoshis(const QString& text) const
+QString BitcoinAmount::toDisplay() const
 {
+    if (!m_isSet) {
+        return "";
+    }
     if (m_unit == Unit::SAT) {
-        return text;
+        return QString::number(m_satoshi);
     } else {
-        return convert(text, m_unit);
+        return satsToBtcString(m_satoshi);
     }
 }
 
-long long BitcoinAmount::toSatoshis(QString& amount, const Unit unit)
+qint64 BitcoinAmount::btcToSats(const QString& btcSanitized)
 {
-    int num_decimals = decimals(unit);
+    if (btcSanitized.isEmpty() || btcSanitized == ".") return 0;
 
-    QStringList parts = amount.remove(' ').split(".");
+    QString cleaned = btcSanitized;
+    if (cleaned.startsWith('.')) cleaned.prepend('0');
 
-    QString whole = parts[0];
-    QString decimals;
-
-    if(parts.size() > 1)
-    {
-        decimals = parts[1];
+    QStringList parts = cleaned.split('.');
+    const qint64 whole = parts[0].isEmpty() ? 0 : parts[0].toLongLong();
+    qint64 frac = 0;
+    if (parts.size() == 2) {
+        frac = parts[1].leftJustified(8, '0').toLongLong();
     }
-    QString str = whole + decimals.leftJustified(num_decimals, '0', true);
 
-    return str.toLongLong();
+    return whole * COIN + frac;
 }
 
-QString BitcoinAmount::convert(const QString& amount, Unit unit) const
+void BitcoinAmount::fromDisplay(const QString& text)
 {
-    if (amount == "") {
-        return amount;
-    }
-
-    QString result = amount;
-    int decimalPosition  = result.indexOf(".");
-
-    if (decimalPosition == -1) {
-        decimalPosition = result.length();
-        result.append(".");
+    if (text.trimmed().isEmpty()) {
+        clear();
+        return;
     }
 
-    if (unit == Unit::BTC) {
-        int numDigitsAfterDecimal = result.length() - decimalPosition - 1;
-        if (numDigitsAfterDecimal < 8) {
-            result.append(QString(8 - numDigitsAfterDecimal, '0'));
-        }
-        result.remove(decimalPosition, 1);
-
-        while (result.startsWith('0') && result.length() > 1) {
-            result.remove(0, 1);
-        }
-    } else if (unit == Unit::SAT) {
-        result.remove(decimalPosition, 1);
-        int newDecimalPosition = decimalPosition - 8;
-        if (newDecimalPosition < 1) {
-            result = QString("0").repeated(-newDecimalPosition) + result;
-            newDecimalPosition = 0;
-        }
-        result.insert(newDecimalPosition, ".");
-
-        while (result.endsWith('0') && result.contains('.')) {
-            result.chop(1);
-        }
-        if (result.endsWith('.')) {
-            result.chop(1);
-        }
-        if (result.startsWith('.')) {
-            result.insert(0, "0");
-        }
+    qint64 newSat = 0;
+    if (m_unit == Unit::BTC) {
+        QString sanitized = sanitize(text);
+        newSat = btcToSats(sanitized);
+    } else {
+        QString digitsOnly = text;
+        digitsOnly.remove(QRegExp("[^0-9]"));
+        newSat = digitsOnly.trimmed().isEmpty() ? 0 : digitsOnly.toLongLong();
     }
+    setSatoshi(newSat);
+}
 
-    return result;
+void BitcoinAmount::format()
+{
+    Q_EMIT displayChanged();
 }

qml/bitcoinamount.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2024 The Bitcoin Core developers
+// Copyright (c) 2024-2025 The Bitcoin Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
@@ -15,8 +15,8 @@ class BitcoinAmount : public QObject
     Q_OBJECT
     Q_PROPERTY(Unit unit READ unit WRITE setUnit NOTIFY unitChanged)
     Q_PROPERTY(QString unitLabel READ unitLabel NOTIFY unitChanged)
-    Q_PROPERTY(QString amount READ amount WRITE setAmount NOTIFY amountChanged)
-    Q_PROPERTY(QString satoshiAmount READ satoshiAmount NOTIFY amountChanged)
+    Q_PROPERTY(QString display READ toDisplay WRITE fromDisplay NOTIFY displayChanged)
+    Q_PROPERTY(qint64 satoshi READ satoshi WRITE setSatoshi NOTIFY amountChanged)
 
 public:
     enum class Unit {
@@ -30,27 +30,34 @@ class BitcoinAmount : public QObject
     Unit unit() const;
     void setUnit(Unit unit);
     QString unitLabel() const;
-    QString amount() const;
-    void setAmount(const QString& new_amount);
-    QString satoshiAmount() const;
+
+    QString toDisplay() const;
+    void fromDisplay(const QString& new_amount);
+    qint64 satoshi() const;
+    void setSatoshi(qint64 new_amount);
+
+    bool isSet() const { return m_isSet; }
+
+    Q_INVOKABLE void format();
+
+    static QString satsToBtcString(qint64 sat);
 
 public Q_SLOTS:
-    QString sanitize(const QString& text);
-    QString convert(const QString& text, Unit unit) const;
-    QString toSatoshis(const QString& text) const;
+    void flipUnit();
+    void clear();
 
 Q_SIGNALS:
     void unitChanged();
-    void unitLabelChanged();
     void amountChanged();
+    void displayChanged();
 
 private:
-    long long toSatoshis(QString &amount, const Unit unit);
-    int decimals(Unit unit);
+    QString sanitize(const QString& text);
+    static qint64 btcToSats(const QString& btc);
 
-    Unit m_unit;
-    QString m_unitLabel;
-    QString m_amount;
+    qint64 m_satoshi{0};
+    bool m_isSet{false};
+    Unit m_unit{Unit::BTC};
 };
 
 #endif // BITCOIN_QML_BITCOINAMOUNT_H

qml/controls/EllipsisMenuButton.qml renamed to qml/controls/IconButton.qml

@@ -11,12 +11,16 @@ import org.bitcoincore.qt 1.0
 Button {
     id: root
 
+    property color iconColor: Theme.color.orange
     property color hoverColor: Theme.color.orange
     property color activeColor: Theme.color.orange
+    property int size: 35
+    property alias iconSource: icon.source
 
     hoverEnabled: AppMode.isDesktop
-    implicitHeight: 35
-    implicitWidth: 35
+    height: root.size
+    width: root.size
+    padding: 0
 
     MouseArea {
         anchors.fill: parent
@@ -25,28 +29,44 @@ Button {
         cursorShape: Qt.PointingHandCursor
     }
 
-    background: null
+    background: Rectangle {
+        id: bg
+        anchors.fill: parent
+        radius: 5
+        color: Theme.color.background
+
+
+        Behavior on color {
+            ColorAnimation { duration: 150 }
+        }
+    }
 
     contentItem: Icon {
-        id: ellipsisIcon
+        id: icon
         anchors.fill: parent
         source: "image://images/ellipsis"
-        color: Theme.color.neutral9
-        size: 35
+        size: root.size
+        color: iconColor
+
+        Behavior on color {
+            ColorAnimation { duration: 150 }
+        }
     }
 
     states: [
         State {
             name: "CHECKED"; when: root.checked
-            PropertyChanges { target: ellipsisIcon; color: activeColor }
+            PropertyChanges { target: icon; color: activeColor }
         },
         State {
             name: "HOVER"; when: root.hovered
-            PropertyChanges { target: ellipsisIcon; color: hoverColor }
+            PropertyChanges { target: icon; color: hoverColor }
+            PropertyChanges { target: bg; color: Theme.color.neutral2 }
         },
         State {
             name: "DISABLED"; when: !root.enabled
-            PropertyChanges { target: ellipsisIcon; color: Theme.color.neutral4 }
+            PropertyChanges { target: icon; color: Theme.color.neutral4 }
+            PropertyChanges { target: bg; color: Theme.color.background }
         }
     ]
 }

qml/controls/NavButton.qml

@@ -53,6 +53,7 @@ AbstractButton {
     }
     contentItem: RowLayout {
         spacing: 0
+        anchors.fill: parent
         Loader {
            id: button_background
            active: root.iconSource.toString().length > 0