Correct errors

Author: johnsamuelwrites

inclusivewriting/rulepacks.py

@@ -16,21 +16,10 @@
     get_all_language_resources,
 )
 from inclusivewriting.file_utils import read_file
+from inclusivewriting.schema_utils import normalize_string_list
 from inclusivewriting.rules import Rule, RuleReplacement
 
 
-def _normalize_str_list(field_name: str, value) -> List[str]:
-    if value is None:
-        return []
-    if isinstance(value, str):
-        return [value]
-    if isinstance(value, list) and all(isinstance(item, str) for item in value):
-        return value
-    raise ValueError(
-        f'Invalid "{field_name}" format: expected string or list of strings'
-    )
-
-
 def _build_rule(language: str, phrase: str, payload: Dict) -> Rule:
     if not isinstance(payload, dict):
         raise ValueError(f'Invalid rule "{phrase}": entry must be an object')
@@ -46,7 +35,7 @@ def _build_rule(language: str, phrase: str, payload: Dict) -> Rule:
         replacements.append(
             RuleReplacement(
                 value=replacement_value,
-                references=_normalize_str_list(
+                references=normalize_string_list(
                     "replacement.references", replacement_payload.get("references")
                 ),
             )

inclusivewriting/rules.py

@@ -12,6 +12,7 @@
 
 
 @dataclass
+# pylint: disable=too-few-public-methods
 class RuleReplacement:
     """A replacement option for a rule."""
 
@@ -43,6 +44,7 @@ def compile_pattern(self) -> Pattern[str]:
 
 
 @dataclass
+# pylint: disable=too-few-public-methods
 class RuleMatch:
     """A match produced by the rule engine."""
 

inclusivewriting/schema_utils.py

@@ -0,0 +1,22 @@
+#
+# SPDX-FileCopyrightText: 2026 John Samuel <johnsamuelwrites@gmail.com>
+#
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+
+"""Helpers for validating and normalizing resource schema fields."""
+
+from typing import List
+
+
+def normalize_string_list(field_name: str, value) -> List[str]:
+    """Normalize a schema field to a list of strings."""
+    if value is None:
+        return []
+    if isinstance(value, str):
+        return [value]
+    if isinstance(value, list) and all(isinstance(item, str) for item in value):
+        return value
+    raise ValueError(
+        f'Invalid "{field_name}" format: expected string or list of strings'
+    )

inclusivewriting/suggestions.py

@@ -8,11 +8,9 @@
 
 from typing import Dict, List, Tuple
 
-from inclusivewriting.configuration import (
-    get_all_language_resource_config_file,
-    get_all_language_resources,
-)
+from inclusivewriting.configuration import get_all_language_resource_config_file
 from inclusivewriting.rulepacks import load_rulepack
+from inclusivewriting.schema_utils import normalize_string_list
 from inclusivewriting.rules import RuleEngine, RuleMatch
 
 
@@ -114,20 +112,14 @@ def __str__(self):
         )
 
 
-def _normalize_link_list(field_name: str, value) -> List[str]:
-    """
-    Normalize a link-like field to a list of strings.
-    """
-    if value is None:
-        return []
-    if isinstance(value, str):
-        return [value]
-    if isinstance(value, list) and all(isinstance(item, str) for item in value):
-        return value
-    raise ValueError(
-        f'Invalid "{field_name}" format: expected string or list of strings'
+def get_all_language_resources(config_file: str = None):
+    """Backward-compatible re-export from configuration module."""
+    from inclusivewriting.configuration import (
+        get_all_language_resources as _configuration_language_resources,
     )
 
+    return _configuration_language_resources(config_file)
+
 
 def _validate_and_build_suggestion(key: str, value: dict) -> Suggestion:
     """
@@ -148,7 +140,7 @@ def _validate_and_build_suggestion(key: str, value: dict) -> Suggestion:
             f'Invalid suggestion "{key}": "replacement" must be an object'
         )
 
-    lexeme = Lexeme(key, _normalize_link_list("lexeme", value.get("lexeme")))
+    lexeme = Lexeme(key, normalize_string_list("lexeme", value.get("lexeme")))
     replacements = []
     for replacement_word, replacement_data in value["replacement"].items():
         if not isinstance(replacement_data, dict):
@@ -158,9 +150,9 @@ def _validate_and_build_suggestion(key: str, value: dict) -> Suggestion:
 
         replacement_lexeme = Lexeme(
             replacement_word,
-            _normalize_link_list("replacement.lexeme", replacement_data.get("lexeme")),
+            normalize_string_list("replacement.lexeme", replacement_data.get("lexeme")),
         )
-        references = _normalize_link_list(
+        references = normalize_string_list(
             "replacement.references", replacement_data.get("references")
         )
         replacements.append(Replacement(replacement_lexeme, references))