-
Notifications
You must be signed in to change notification settings - Fork 19
Expand file tree
/
Copy pathChangeLog
More file actions
2483 lines (2139 loc) · 106 KB
/
ChangeLog
File metadata and controls
2483 lines (2139 loc) · 106 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
OpenVi 7.0.7 -> OpenVi 7.0.8: Mon Jan 31 08:02:27 2022
+ Rework README.md
+ Drop `-pipe` and `-fomit-frame-pointer` defaults for wider compatibility
+ Add support for building on macOS; tested on 12.1/x86_64 (21C5021h)
+ Add support for building on OpenBSD; tested on 7.0-current/ARM64
+ Normalize licensing text, acknowledgements, and copyright statements
+ Normalize macro defines and conditional if/ifdef/ifndef's with `cppi`
+ Add support for building on FreeBSD; tested on 13.0-RELEASE-p6/ARM64
+ Minor code clean-up
+ Drop memmove wrapper macro (for old systems with bcopy but no memmove)
+ Add support for building with musl libc
+ Add `imctrl` and `imkey` options, inspired by `cannactrl` and `fepkey`
options in `nvi-m17n` by itojun. If `imctrl` option is set, the input
method is controlled by using escape sequences compatible with Tera
Term and RLogin. The state of the input method in commands specified
by imkey option is saved and restored automatically. This input method
is deactivated upon returning to command mode; this implementation
taken from NetBSD-current's `contrib/nvi`
+ Improve `make` output and use more logical compilation order
+ Add `virecover.8` man page adapted from NetBSD
+ Add a missing break in `common/log.c`
+ Avoid undefined behavior in `*BIT` macros; patch from NetBSD; also
apply patch from NetBSD for PR bin/52716
+ Update `.gitignore` and `.gitattributes`
OpenVi 7.0.6 -> OpenVi 7.0.7: Fri Jan 28 16:33:22 2022
+ Important fix to `GNUmakefile` for linking with Clang's `lld` linker
+ Remove installed man pages as part of the `uninstall` target
+ Workaround to accommodate the case of `make clean all -j N' when `N` > 1
+ Clean-up whitespace and line lengths of sources and `GNUmakefile`
OpenVi 7.0.5 -> OpenVi 7.0.6: Thu Jan 27 16:45:12 2022
+ Important fix for back-end database file locking; also, switch
back to using the system libc-provided mkstemp functions to elide
some issues that would otherwise occur on networked filesystems.
+ Add proper attribution for DragonflyBSD Project to `LICENSE` text
+ Correct `GNUmakefile` non-verbose messages for the `install` target
+ Clean-up excess and trailing whitespace in source files
OpenVi 7.0.4 -> OpenVi 7.0.5: Thu Jan 27 11:00:46 2022
+ No verbose build by default; set variables V (or DEBUG) to enable
+ No LTO and LGC by default; set variables LTO and/or LGC to enable
+ Don't attempt linking with libjemalloc or libmtmalloc by default
+ Clean-up headers to speed compilation time and decrease binary size
+ Import and adapt OpenBSD Berkeley DB from OpenBSD 7-current libc
+ Remove the unused "maintainer-clean" target from GNUmakefile
+ Build against the newly bundled OpenBSD Berkeley DB by default;
the imperfect Berkeley DB 3/4/5 support will remain available
OpenVi 7.0.3 -> OpenVi 7.0.4: Wed Jan 26 13:09:45 2022
+ New feature: "set visibletab" (abbrev "set vt") which toggles
displaying tabs visibly while editing, useful for Makefiles, etc
+ Decrease the width of the line-number column by one row
+ Increase the length of the divider decoration string (by 2x)
+ Improve the GNUmakefile to avoid remaking any non-stale targets
+ Portably seed the standard random number generator
OpenVi 7.0.2 -> OpenVi 7.0.3: Wed Jan 26 08:31:28 2022
+ GNUmakefile "install" targets now install documentation (man pages)
+ Remove 'docs/internals/cscope.NOTES' and documentation references
+ General GNUmakefile, portability, and code readability improvements
+ Relicense new contributions under the same 3-clause BSD license
used by the overall project and update LICENSE file text
+ Remove unused headers and legacy documentation from the source tree
+ Add standalone "strip" target to GNUmakefile; strip uninstalled binary
+ Set visible tab character to '~' and expose option in GNUmakefile
+ Installed binaries are now prefixed with 'o' (e.g. 'ovi') by default
+ Explicitly invoke the POSIX-compliant version of the awk utility
+ Clarify (and simplify) GNUmakefile and build configuration
+ Update ChangeLog and docs for consistency, fix spelling & other typos
+ Update LICENSE text
OpenVi 7.0.1 -> OpenVi 7.0.2: Tue Jan 25 13:44:48 2022
+ Debugging builds now default to compiling with '-Wall -Wextra'
+ Only pass '-pipe' to the compiler for non-debugging builds
+ Expand the formatting of the usage help text for readability
+ Change the DEBUG_VI GNUmakefile flag to simply DEBUG
+ For debugging builds, document the existence of -T (Trace) in usage
+ Don't strip the binary by default; add "install-strip" target
+ Make clean targets more robust; warn if unable to remove 'bin'
+ Add standard "clean", "distclean", "realclean", "mostlyclean", and
"maintainer-clean" targets to GNUmakefile
+ Increase the default escapetime to 2/10ths of a second
+ Add OpenBSD-compatible mkstemp function allowing for longer filenames
+ Silence some potential warnings with explicit casting
+ Exit with an error when screen is too small for visual mode
+ Apply Debian's patch to fix backwards sentence moving
+ Fix horizontal scroll count; patch from Debian
+ Change a #define to a typedef in regex library
+ Fix some typos and minor errors in the documentation and tutorials
+ Update .gitignore to include patch/diff detritus; no binary change
+ Adjust calculation to avoid "BDB0511 page sizes must be a power-of-2"
warning; BDB 1.85 only cared if page size was even; closes GH issue #3
+ Apply .exrc writeability patch from hesso at pool.math.tu-berlin.de
+ If TERM is unset, set to null, or otherwise unknown, first attempt
to fallback to "vt100"; exit with a fatal error if "vt100" fails
+ Disallow pattern spaces which would cause intermediate
calculations to overflow size_t. (CERT: VU#695940)
+ Bump version and use -dev to denote development version
+ Reformat ChangeLog for consistency; various spelling corrections
+ Update ChangeLog with OpenVi history
+ Format OpenBSD commits to ChangeLog format
+ Clean-up of legacy documentation; adjust formatting
+ Simplify GNUmakefile rules
+ Update GNUmakefile; correct a typo in a message
+ Update LICENSE text and formatting
OpenBSD 7.0.0 -> OpenVi 7.0.1: Mon Jan 24 10:37:28 2022
+ OpenVi created supporting glibc-based Linux systems
+ Create GNUmakefile and adapt build system
+ Attempt to detect and use mtmalloc or jemalloc if available
+ Support builds with post-1.8.5 BerkeleyDB versions (using BDB
1.8.5 emulation) but at the expense of preservation and recovery
+ Create initial README.md stub
Mon Oct 25 14:17:24 2021
+ vi(1): fix use after free with unsaved buffer. Issuing a zero-arg
ex_edit command (:e) while using a named buffer with no backing file
caused vi(1)/ex(1) to free the strings representing the buffer name
and the name of the temporary file. This change detects the situation
and only frees the newly allocated EXF structure (ep). Reported on
bugs@ by kn@. OK millert@
Sun Oct 24 21:24:15 2021
+ For open/openat, if the flags parameter does not contain
O_CREAT, the 3rd (variadic) mode_t parameter is irrelevant
Many developers in the past have passed mode_t (0, 044, 0644,
or such), which might lead future people to copy this broken
idiom, and perhaps even believe this parameter has some meaning
or implication or application. Delete them all. This comes out of
a conversation where tb@ noticed that a strange (but intentional)
pledge behavior is to always knock-out high-bits from mode_t on a
number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least
visually), but no sorry, they are all irrelevant junk. They could
all be 0xdeafbeef. ok millert@
OpenBSD 6.9 -> OpenBSD 7.0: Thu Sep 2 11:19:02 2021
+ Make all signal handler functions async-signal-safe by
deleting the redundant "killersig" struct member and using the
existing sig_atomic_t cl_sigterm variable instead
+ While here, garbage collect the h_hup() signal handler which is
essentially identical to h_term(). This also gets rid of the
last #define & #undef in cl_main.c
Wed Sep 1 14:28:15 2021
+ As a first step towards safe signal handling, improve the
h_int() and h_winch() signal handlers to make one single store
to a sig_atomic_t variable. Note that the h_hup() and h_term()
signal handlers are still unsafe after this commit because they
also set the "killersig" (how fitting!) field in a global struct
OpenBSD 6.8 -> OpenBSD 6.9: Tue Apr 13 15:39:21 2021
+ Require that the argument to the window option be non-zero. A
zero-row window would not be usable (no room to edit) and the
code is full of assumptions that "sp->t_rows - 1" >= 0. From
Erik Ruotsalainen, fixes a bug reported by Paul de Weerd
+ Ignore expandtab setting when in command mode. Fixes things like
searching for a literal tab character when expandtab is enabled;
from nvi2 (leres); OK martijn@
Mon Mar 8 02:47:25 2021
+ Add some references, most of these were removed when we stopped
building and installing USD/SMM/PSD docs
OpenBSD 6.7 -> OpenBSD 6.8: Tue Jan 26 18:19:43 2021
+ Satisfy -fno-common by repairing one enum decl; ok mortimer@
OpenBSD 6.6 -> OpenBSD 6.7: Sun May 24 13:33:55 2020
+ Correct one statement about how the 'm' command works, talk
less about ancient terminals, employ the more usual term "caret"
rather than "up-arrow", and fix a few minor nits
OpenBSD 6.5 -> OpenBSD 6.6: Thu Apr 30 10:40:21 2020
+ Add an expandtab option, similar to what vim supports. If set,
expands tabs to spaces in insert mode as well as when shifting
and indenting/outdenting. If quoted with ^V, a literal tab is
inserted. Adapted from NetBSD, but this implementation more
closely matches vim's behavior. OK dlg@
Fri Oct 4 20:12:01 2019
+ Better link "set" and "SET OPTIONS"; original diff from sven
falempin, tweaked a bit by myself
Mon Jul 22 12:39:02 2019
+ In secure mode (-S), skip sending mail when executing the
:pre[serve] command or when dying from SIGTERM. This way,
creating the recovery file works again without re-adding "proc
exec" to the pledge(2). As reported by Jesper Wallin <jesper
at ifconfig dot se>, this got broken by common/main.c rev. 1.29
(Nov 19, 2015). The general direction of the fix was suggested
by brynet@. OK brynet@ and no opposition when shown on tech@
OpenBSD 6.4 -> OpenBSD 6.5: Tue May 21 09:24:58 2019
+ Also apply stricter pledge when secure mode is set via rc file
or command
OpenBSD 6.3 -> OpenBSD 6.4: Thu Jan 24 15:09:41 2019
+ Fix a crash on long lines when switching to another file by
setting SC_SCR_CENTER which will cause the offsets in HMAP to
be reset when painting the screen. OK martijn@ otto@
Mon Sep 17 15:41:17 2018
+ Use the strict pragma for better warnings
Fri Jul 13 20:06:10 2018
+ Remove Cscope leftover and a stray comma
+ Unused variable
Wed Jul 11 06:39:23 2018
+ Remove an old (and false) comment. REALLOC now free(3)s
the code if realloc fails
OpenBSD 6.2 -> OpenBSD 6.3: Mon Feb 12 01:10:46 2018
+ Simplify documentation of split-screen mode, avoiding abuse
of [] to sometimes mean "character set", which conflicts with
the normal meaning of "optional element" in manual pages
+ While here, add a few related clarifications and tweak a
few details. Triggered by a minor bug report from <trondd at
kagu-tsuchi dot com>, and by bentley@ subsequently pointing out
the abuse of []. Patch using input from jmc@, who also agreed
with some previous versions
Sat Feb 3 15:44:36 2018
+ The recover script should have the same sanity checks as
recover.c. Specifically, open files with O_NONBLOCK and enforce
a mode of 0600
Thu Dec 14 10:02:53 2017
+ Enable the awk scripts to generate ex_def.h and
options_def.h. These scripts generate the enums required for
the ex commands and vi options. Before these lists had to
be maintained either by hand or someone had to stumble upon
these scripts and figure out how to use them. By enabling them
these headers are now always in sync based on the comments in
the corresponding source files, which are a lot harder to miss
during an update than an extra file
Sun Nov 26 09:59:41 2017
+ Fix segfault which could be triggered by deleting a backwards
sentence if cursor's current line was blank:
Fri Nov 10 18:31:36 2017
+ When tracing is compiled in make sure it flushes its content
to disk as soon as the TRACE function is called. This helps
while debugging crashes
+ Fix a use after free when sending SIGHUP or SIGTERM to vi when
in editing mode
+ Add rcv_openat() function that does the open, makes sure it
is a regular file with the expected permissions and locks it
Inspired by changes in NetBSD by Christos. OK martijn@
+ Avoid using system(3) when running "sendmail -t". We already
have the recover file fd open so just run sendmail with stdin
set to the recover file. OK martijn@
OpenBSD 6.1 -> OpenBSD 6.2: Tue Aug 22 20:27:18 2017
+ Do not treat comma as part of the command modifier
Mon Jul 31 19:45:49 2017
+ Silence some warnings generated by clang. Original diff by
espie@ with some minor tweaks by myself
Thu Jul 20 08:37:48 2017
+ Replace usage of strtol() with strtonum()
Wed Jul 5 18:56:33 2017
+ Avoid double space caused by end-of-sentence detection
requested by jmc@
+ Nits about trailing punctuation found with mandoc -Tlint
Mon Jul 3 14:30:11 2017
+ Markup fixes
+ Remove settings that were unimplemented for 20 years; update
STANDARDS
Fri Jun 30 14:42:05 2017
+ Add mdoc(7) macros to vi's built-in lists of roff
paragraph/section macros
Sat Jun 24 16:30:47 2017
+ Fix a check in ADD_SPACE_{GOTO,RET} that potentially allowed
for a NULL-dereference
Tue Jun 20 07:32:56 2017
+ Better document the :s ex command and its variants
Thu Jun 15 06:44:47 2017
+ "10th's of a second" -> "tenths of a second"
Mon Jun 12 18:38:57 2017
+ Use openat() and unlinkat() instead of chdir()ing to the
recovery dir. Since we use flock() and not fcntl() locking we
can open the recovery file read-only. OK martijn@
Wed Apr 26 13:14:28 2017
+ Remove extraneous ", NULL" in the assignment of msgstr which was
leftover from when msg_cat() was removed. From Anton Lindqvist
Tue Apr 18 01:45:33 2017
+ free(NULL) is ok so use it; from Michael W. Bombardieri
OpenBSD 6.0 -> OpenBSD 6.1: Fri Jan 20 00:55:52 2017
+ Nuke some excess whitespace
Sun Dec 18 18:28:38 2016
+ Use %zu/%d to print size_t/ssize_t. Cast recno_t
(a.k.a. u_int32_t) to (unsigned long) to match %lu formats. Makes
gcc happier and quieter
+ Nuke more unused variables
Sat Nov 5 16:21:56 2016
+ Remove syscall.ph from vi.recover
Fri Sep 2 15:38:42 2016
+ Fix the begin of word issue in vi(1). Similar fix went in sed
and ed
OpenBSD 5.9 -> OpenBSD 6.0: Sat Aug 27 04:07:42 2016
+ Pull in <sys/time.h> for struct timespec and timeval
Sun Aug 14 21:47:16 2016
+ Kill '#if defined(DEBUG) && 0' blocks that used %q
Mon Aug 8 15:09:32 2016
+ /tmp and /var/tmp are the same, consistently use the former
in both build/recover and documentation
Mon Aug 1 18:27:35 2016
+ Remove vi's "directory" option and TMPDIR support
Thu Jul 7 09:26:25 2016
+ biff, mesg, vi: only consider ACCESSPERMS for setting tty mode
Wed Jun 29 20:38:39 2016
+ If /tmp/vi.recover doesn't exist, don't create it. Warn once
that it doesn't exist, afterwards fail silently
Sat May 28 18:30:35 2016
+ Test if stdin is a terminal before resetting the tty state. Diff
supplied by Kai Antweiler
Fri May 27 09:18:11 2016
+ Revert CHAR_T removal. Some signedness flaws were
introduced. Found the hard way by jca@
Sat May 7 14:03:01 2016
+ Free memory if realloc fails. The application is most likely
to terminate after a failure, but if it does not we better clean
up after ourselves
Thu May 5 20:36:41 2016
+ Remove __sigblockset. This is a leftover after the removal of
the signal blocking code in common/gs.h rev 1.14
Mon May 2 20:51:35 2016
+ Remove pointless comment. getcwd(3) is safe
+ Remove CHAR_T in favor of native types
Wed Apr 20 19:34:32 2016
+ Remove pointless reenter variable
Tue Apr 19 17:42:09 2016
+ Remove not implemented declaration of sscr_pty
+ Remove some useless code
Wed Mar 30 06:38:40 2016
+ For some time now mandoc has not required MLINKS to function
correctly; logically complete that now by removing MLINKS
from base
OpenBSD 5.8 -> OpenBSD 5.9: Sat Mar 19 00:21:28 2016
+ By issuing :e +something in vi(1) this uncovers a backwards
memcpy with the code because the 2 buffers overlap and in order
to solve it then replace memcpy(3) call by memmove(3)
Thu Mar 17 03:44:05 2016
+ Add error checking for COLUMNS/LINES environment variables
Sun Mar 13 18:30:43 2016
+ Remove an extra space before ^\ help message. Fixes alignment
in viusage
Thu Feb 11 16:34:12 2016
+ Update comment: the #ifdef VDSUSP was removed in r1.22
Tue Feb 9 07:41:12 2016
+ Avoid special characters; from Michael Reed
Wed Feb 3 01:47:25 2016
+ Remove needless alias macros for malloc and calloc. No binary
change. I got this up-streamed a few weeks ago
Sat Jan 30 21:34:57 2016
+ /var/tmp is dead, long live /tmp
+ Replace tail with basename
+ Replace progname variable in gs structure with getprogname
Wed Jan 27 22:46:02 2016
+ remove v_estr in favor of warn and warnx
Wed Jan 27 22:38:12 2016
+ Replace fprintf+exit with errx. No functional change
Wed Jan 20 08:43:27 2016
+ Remove ARG_CHAR_T, a relic from when the code was written
K&R style
Sat Jan 9 16:13:26 2016
+ decls before code; from Martijn van Duren
Wed Jan 6 22:46:59 2016
+ Remove mention of message catalog dir
+ We don't use configure so this file is full of lies and we
are better off without it
+ Remove msgcat from the documentation
+ Remove prototype for now-deleted f_msgcat()
+ Remove the actual message catalogs. From Martijn van Duren
+ Remove the msg_cat() function and adjust its former
callers. From Martijn van Duren
+ Remove the numeric identifiers at the beginning of the messages
which used to be used as the message number to lookup in the
catalog. From Martijn van Duren
+ Remove the message catalog DB. This removes the msg_open()
and msg_close() functions along with the msgcat command. From
Martijn van Duren
Mon Dec 28 19:24:01 2015
+ Use err() instead of custom perr() function. Also applied by
nvi2 upstream; From Martijn van Duren
Mon Dec 7 20:39:19 2015
+ Remove needless type casts and corresponding type parameters
from allocation macros. No binary change
Thu Dec 3 08:13:15 2015
+ After inserting a backslash, don't treat ^H ^? or ^U as special
cases. These days, ^V to escape is a universal feature and
needing two keystrokes to delete backslashes is really annoying
Tue Nov 24 12:56:31 2015
+ Update the other documentation to match the new filec default
+ Turn on filename tab completion in vi by default
Mon Nov 23 09:03:01 2015
+ Remove Cscope references in documentation
Fri Nov 20 04:12:19 2015
+ vi -S doesn't need proc or exec
Thu Nov 19 19:30:44 2015
+ "tty proc exec", not "proc exec tty"
+ Remove Cscope support in vi
OpenBSD 5.7 -> OpenBSD 5.8: Sun Nov 15 01:22:36 2015
+ Vi needs flock, for those who haven't set nolock in .exrc
for years
+ Basic pledge for vi
Mon Sep 14 20:06:58 2015
+ Avoid .Ns right after .Pf, it's pointless
+ In some cases, do additional cleanup in the immediate vicinity
Tue Jul 7 18:34:12 2015
+ Fix a regression caused by timespec changes when vi is run
without a file to edit. Based on a diff from Patrick Keshishian
OpenBSD 5.6 -> OpenBSD 5.7: Fri Apr 24 21:48:31 2015
+ struct timespec/clock_gettime(3) conversion for vi(1)
Tue Apr 21 01:41:42 2015
+ init both fds passed to pipe as -1 instead of init'ing one
twice ok deraadt@ guenther@ miod@ millert@
Sun Apr 19 01:10:59 2015
+ Don't lock the file for "vi -R" or "view". OK deraadt@
Fri Apr 10 18:05:51 2015
+ This changes vi to use resizeterm(3) instead of re-initializing
curses on window re-sizes, which was leaking massive amounts
of memory
Sun Mar 29 01:04:23 2015
+ Remove SA_INTERRUPT, HISTORIC_PRACTICE, and HISTORICAL_PRACTICE
using unifdef. It seems clear that no one was using these
(SA_INTERRUPT didn't even build the other way). Tweak comments
as appropriate
Sat Mar 28 12:54:37 2015
+ vi was using two separate isblank functions: one defined in
<ctype.h> and the other #defined in common/key.h. There is no
reason to have both. For consistency use the isblank function
from <ctype.h>, remove the #define in common/key.h, and add
#include <ctype.h> to the files that were missing the header
Fri Mar 27 04:11:25 2015
+ Some vi cleanup, unifdef's some signal blocking code that has
never been enabled in our tree, also removes some stragglers
from a global struct referencing nonexistent Tcl/TK and "IP
support". And finally.. delete an empty file missed by earlier
cleanup by bentley@
Tue Mar 17 10:08:18 2015
+ Don't use the wrong escape for < and >. Tweak wording to match
the page
Fri Mar 13 19:58:40 2015
+ Remove the first comma from constructs like ", and," and
", or,": you can use "and" and "or" to join sentence clauses,
and you can use commas, but both hinders reading
Tue Mar 10 00:10:59 2015
+ Display "Search wrapped" even when searching from the end of
the file
Sat Feb 28 21:51:56 2015
+ Reduce usage of predefined strings in man pages
Fri Feb 6 22:29:31 2015
+ Do not rely on unspecified behavior for the size_t overflow
check. OK miod@
Fri Jan 16 06:39:28 2015
+ Replace <sys/param.h> with <limits.h> and other less dirty
headers where possible
+ Annotate <sys/param.h> lines with their current reasons
+ Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX
+ Change MIN() and MAX() to local definitions of MINIMUM() and
MAXIMUM() where sensible to avoid pulling in the pollution. These
are the files confirmed through binary verification. ok guenther@,
millert@, doug@ (helped with the verification protocol)
Thu Nov 20 08:50:53 2014
+ Remove the vi Perl API
Wed Nov 19 03:42:40 2014
+ Remove ifdef checks for LIBRARY. It is undocumented and triggers
the same conditional inclusions as PURIFY does
Fri Nov 14 20:27:03 2014
+ _PATH_BSHELL, _PATH_SENDMAIL, _PATH_TMP and _PATH_TTY are defined
in <paths.h> and _PATH_SYSV_TTY is unused. All of them can be
removed from pathnames.h. The other defines can be made
unconditionally
+ The 'tcl' command in vi does nothing, except to print the message
"Vi was not loaded with a Tcl interpreter". Printing the standard
message for unknown commands would be equally descriptive with the
benefit of reducing code size
+ The vi editor contains code for two different file locking methods;
one using flock(), the other using fcntl(). The fcntl method is
unused and has severe limitations (as described in a code comment);
removed it for sake of readability
Wed Nov 12 16:29:04 2014
+ Remove more portability bits for older systems; from Martin
Natano
+ ANSIfy vi
Mon Nov 10 21:40:11 2014
+ Remove various bits of autoconf cruft. from Martin Natano
+ Remove ipc leftovers. from Martin Natano
+ Remove old, unnecessary compat code. from Martin Natano
OpenBSD 5.5 -> OpenBSD 5.6: Thu Nov 6 11:35:02 2014
+ Clean up unused header files and docs referring to them
+ Remove old curses support in vi
OpenBSD 5.4 -> OpenBSD 5.5: Tue Oct 14 22:23:12 2014
+ Create a REALLOCARRAY macro, and use it where it gives us
overflow protection for free ok guenther@
Wed Oct 8 00:53:45 2014
+ Bump max columns out to 768 since screens are getting bigger
Tue Sep 9 14:10:35 2014
+ We no longer need to convert "\<" and "\>" to "[[:<:]]" and
"[[:>:]]" respectively now that the former is natively supported
OK jsg@
Thu Jul 10 20:33:42 2014
+ Add missing include file to bring in protos
Sun Dec 1 20:22:34 2013
+ Change the file reference queue from CIRCLEQ to TAILQ
+ Change the tags queue from CIRCLEQ to TAILQ
+ Change the tag queue from CIRCLEQ to TAILQ
+ Convert the ranges CIRCLEQ to TAILQ
Thu Nov 28 22:12:40 2013
+ Convert the display screens and hidden screens CIRCLEQ's
to TAILQ's
Wed Nov 27 08:52:41 2013
+ Zap some pointer casts became extra (and thus dangerous)
after recent CIRCLEQ removal
Tue Nov 26 17:48:01 2013
+ Fix a possible double-free/NULL deref in msg_print
+ Tweak a tortuous manual loop into a TAILQ_FOREACH()
+ Fix condition after CIRCLEQ -> TAILQ conversion; ok zhuk@
+ Fix incorrectly converted CIRCLEQ_END comparison to prevent
NULL deref's
Mon Nov 25 23:27:11 2013
+ Replace _texth CIRCLEQ with TAILQ. One down, five to go
OpenBSD 5.3 -> OpenBSD 5.4: Thu Aug 22 04:43:40 2013
+ Correct format string mismatches turned up by -Wformat=2
Sat Jun 22 18:52:52 2013
+ Tweak optimization flags on landisk until I have time to
investigate further
Tue May 14 11:51:41 2013
+ When ^W (WERASE) is hit in insert mode it's possible that the
line buffer is accessed out of bounds. If 'max' == 0 and
'tp->cno' == 1 the 'tp->cno' value is first reduced by one and
then 'tp->lb' is accessed at 'tp->cno' - 1. Also remove dead
(and incorrect) code in the TXT_ALTWERASE case; from Arto Jonsson
OK martynas@
OpenBSD 5.2 -> OpenBSD 5.3: Fri May 3 20:43:25 2013
+ Use open(2) / fstat(2) instead of stat(2) / open(2) for checking
proper permissions of "local" .exrc or .nexrc files
Mon Apr 29 00:28:23 2013
+ Use FD_CLOEXEC instead of 1; from David Hill
Thu Dec 20 20:28:12 2012
+ Use openpty() rather than hand-rolled pty opening code
ok millert@
OpenBSD 5.1 -> OpenBSD 5.2: Mon Dec 3 22:05:46 2012
+ Fix hang when exiting shell in script mode. OK naddy@
OpenBSD 5.0 -> OpenBSD 5.1: Tue Jan 17 08:18:36 2012
+ Flesh out the VI COMMANDS section somewhat; diff from Alexis
Fouilhe; help; ok sobrado@
OpenBSD 4.9 -> OpenBSD 5.0: Wed Dec 28 01:52:33 2011
+ These utilities were already part of 1BSD, and some authors
are known. All facts from the CSRG archive CD 1, also available
from minnie.tuhs.org. Feedback and OK sobrado@, ok jmc@
Fri Jul 29 13:24:50 2011
+ Document vi/ex regular expressions, and where they differ from
those documented in re_format(7)
Sun Jul 10 13:20:25 2011
+ Rename O_DIRECTORY to O_TMP_DIRECTORY to avoid a namespace
collision with sys/fcntl.h. OK deraadt@
Mon May 16 16:41:58 2011
+ Better document some of the terminology used in the VI COMMANDS
section; from Alexis Fouilhe
OpenBSD 4.8 -> OpenBSD 4.9: Mon May 2 11:14:11 2011
+ No need to escape `|'; as discussed with schwartze@
Tue Apr 12 18:08:00 2011
+ Better document vi's startup (in terms of environment variables
and config files)
Sun Apr 10 21:21:50 2011
+ Fix display glitch leading to crash. If we're reformatting,
check the screens necessary to display the line and modify head
or tail of the smap accordingly; since it might have changed
due to e.g. smaller tabstop value
Thu Mar 31 20:40:51 2011
+ Add a BUFFERS section, to explain how they work; from Alexis
Fouilhe - many thanks to him for his work on this
Thu Mar 17 11:34:53 2011
+ since we stopped installing the USD docs, it no longer makes
sense for DESCRIPTION to point to SEE ALSO
OpenBSD 4.7 -> OpenBSD 4.8: Wed Jan 5 14:01:32 2011
+ Fix typo, PR#6538
Mon Oct 18 14:42:16 2010
+ Remove references to now removed USD/PSD/SMM docs
Sun Oct 17 22:54:37 2010
+ Stop installing me(1) and ms(1) source code. We will soon get
rid of groff in base, so there is no longer any way to use
these files with base. No opposition on tech@
Wed Sep 29 07:44:56 2010
+ Various EXIT STATUS fixes; from Daniel Dickman
Fri Sep 24 06:40:12 2010
+ Add a little padding to make SYNOPSIS line up nicely
Sun Jul 25 20:23:41 2010
+ ^U scrolls backwards, not forwards; from marrob at lavabit com
Sun Jul 18 21:45:01 2010
+ Remove some nasty hacks
Thu Jul 15 20:51:38 2010
+ More delimiters that need quoting inside macros, hunted down
by jmc@, who asked me to commit because he is just running out
of the door
OpenBSD 4.6 -> OpenBSD 4.7: Sat May 29 06:40:00 2010
+ subsitution -> substitution; from Yoshihiro Ota, FreeBSD PR#130874
Sun Nov 22 22:51:58 2009
+ Fix for flash defaulting to off, pointed out by jmc@
+ Change the flash option to be off by default. Now that xterm
has the flash capability in terminfo, vi was using it instead
of beeping, but it is too slow for some machines
Sun Nov 15 04:32:31 2009
+ Do not leak a lot of memory if a small memory allocation fails,
found by parfait@ ok kettenis@ guenther@
Sat Nov 14 17:44:53 2009
+ Fix leaks in error paths found by parfait ok deraadt@
Tue Oct 27 23:59:19 2009
+ Remove rcsid[] and sccsid[] and copyright[] that are essentially
unmaintained (and unmaintainable). These days, people use source
These id's do not provide any benefit, and do hurt the small
install media (the 33,000 line diff is essentially mechanical); ok
with the idea millert@, ok dms@
OpenBSD 4.5 -> OpenBSD 4.6: Tue Oct 20 09:54:47 2009
+ ex(1) and vi(1) are different editors. The diff is based on the
original printed edition of the User's Reference Manual from
USENIX and O'Reilly. 4.4BSD had exactly this, that is much
more accurate than our current description (while here, Jason
observed that both FreeBSD and NetBSD do the same)
Wed Jun 10 14:03:18 2009
+ Use poll() instead of select(). The sscr_check_input()
bit is adapted from nvi 1.81. Tested by several people during
the hackathon
OpenBSD 4.4 -> OpenBSD 4.5: Tue Jun 2 00:21:32 2009
+ If the read from the tty fails with EAGAIN, pop back up to the
select. Seems to happen occasionally even though select reported
the fd is ready. OK ray@
Mon Apr 27 19:41:10 2009
+ It's called `msgcat', not `mesgcat'
Sun Apr 19 13:12:28 2009
+ Fix tagnext and tagprev; from Patrick Keshishian
Sun Feb 8 17:15:08 2009
+ Bump the POSIX reference in STANDARDS to IEEE Std 1003.1-2008,
with a few updates to follow
Sun Feb 1 21:57:21 2009
+ Move variable declarations around to compile with GCC 2
OpenBSD 4.3 -> OpenBSD 4.4: Wed Jan 28 21:30:43 2009
+ Remove undocumented support for "-e" in ex(1)
+ ex(1), vi(1), and view(1) have different synopses; each nex/nvi
utility should manage the right set of options and return an
appropriate usage when required
Thu Sep 25 11:37:03 2008
+ do not hard code the editor name in the message displayed by
"-r" when there are no files to recover as this flag is used
by ex(1) and view(1) too
Fri Aug 29 13:07:13 2008
+ Fix nvi's Cscope support in the case that someone provided a
filename without a directory (e.g. :cscope add cscope.out)
Found and fixed by Paul Irofti, with help from me; Thanks!
OpenBSD 4.2 -> OpenBSD 4.3: Thu Jun 12 21:22:48 2008
+ Remove superfluous "usage:" from v_estr()
Fri Mar 28 17:58:20 2008
+ Minor ansification from Gleydson Soares
Sat Mar 8 18:11:42 2008
+ Avoid infinite recursion on certain error conditions; from
NetBSD; ok millert@
+ Fix vs_columns() for the "set nu" case. Avoids segfaults for
very long lines containing tabs; from Nathan Houghton; ok millert@
Tue Mar 4 18:55:44 2008
+ Fix ifdef DEBUG code; ok krw@ deraadt@
OpenBSD 4.1 -> OpenBSD 4.2: Sat Nov 24 12:59:28 2007
+ Some spelling fixes from Martynas Venckus
Wed Oct 17 20:10:44 2007
+ Remove "unused variable" warnings
Fri Sep 14 14:29:20 2007
+ Remove some warnings: unused variable `variable' `variable'
might be used uninitialized in this function
Tue Sep 11 15:47:17 2007
+ Use strcspn to properly overwrite '\n' in fgets returned buffer
Sun Sep 2 15:19:07 2007
+ Use calloc() to avoid malloc(n * m) overflows; checked by djm@
canacar@ jsg@
Thu Jul 26 16:11:56 2007
+ Add the correct file descriptor to rdfd when cycling through
the list of scripting windows. Appears to be a cut and paste
error. OK deraadt@
Thu May 31 19:19:00 2007
+ Convert to new .Dd format
Wed May 30 04:41:33 2007
+ Use a consistent text for STANDARDS
+ Note which options are extensions to POSIX
OpenBSD 4.0 -> OpenBSD 4.1: Mon May 14 12:32:29 2007
+ Use sys/queue macros instead of accessing fields directly;
No binary change. ok krw@
Tue Mar 27 18:24:06 2007
+ Catch OOB access for tag searches matching lines ending with a
'\'; patch from Patrick Keshishian with a twist by me. ok thib@
Tue Mar 20 03:56:12 2007
+ Remove some bogus *p tests from charles@ longeau@ ok deraadt@
millert@
Thu Dec 21 21:38:17 2006
+ Fix !command piping by Alexander Bluhm in PR#5325. Tested by
quite a few on tech@
OpenBSD 3.9 -> OpenBSD 4.0: Mon Dec 11 20:50:54 2006
+ RFC 3834 support: Auto-Submitted: auto-generated on lots of
things; from Tamas TEVESZ; ok millert@
Fri Jul 7 12:05:10 2006
+ Don't add space for line numbers twice
Sun Jun 18 20:41:24 2006
+ Fix memleak; From Coverity Scan, CID#3135. From simonb@ NetBSD
Tue May 30 19:43:27 2006
+ Avoid double fclose(), from coverity/NetBSD; ok otto@
OpenBSD 3.8 -> OpenBSD 3.9: Sun May 21 19:21:30 2006
+ Backport fix from nvi 1.81.5: do not go into loop if :set
number and :set leftright and the cursor moves to an empty line
PR#3154; ok beck@
Fri Apr 28 19:48:15 2006
+ Ensure NULL termination after read(); ok ray@
Sat Apr 22 03:09:15 2006
+ Removes unused variables and rename variables shadowing
external variables; no binary change
Mon Mar 20 01:00:36 2006
+ If we're in visual mode reading a command, check the termination
value of v_tcmd() and bail if it's not TERM_OK as opposed to
in a more specific case. This is based on the NetBSD ^C fix
but after discussion with otto@. While it did not affect the
specific crash it is more correct
Wed Mar 15 23:43:27 2006
+ Handle ^C correctly, morph it to escape key so the input
is correctly finished for a potential replay; if not, simply
bail out and notify that something wrong occurs. Callers will
cope. Consistent with what vim and Solaris vi do. Fixes a crash
described in NetBSD PR#11544, fixed by aymeric@ ok otto@ ray@
Sat Mar 11 07:04:53 2006
+ Fixes the `optindx' might be used uninitialized in this function
warning, fixes a spacing nit in a macro, and cleans up a very
bad preprocessor abuse (``if LF_ISSET(OS_DEF)''!)
+ Silence 2 warnings
+ Silence another 39 warnings
+ Silence uninitialized variable warning
+ Make FLUSH macro more function-like, so there are no hidden
surprises; no binary change
+ Initialize p to NULL to prevent gcc warning. Clarify a for
statement
Sat Mar 4 16:18:04 2006
+ Fix "the the"
Fri Feb 17 19:12:41 2006
+ Fix use after free. Problem hunted down by wilfried@; ok fgsch@
millert@
OpenBSD 3.7 -> OpenBSD 3.8: Sun Jan 8 21:10:04 2006
+ Remove unused NADD_USLONG macro, and remove unused sp argument
from NADD_SLONG; no functional change
+ Fix one more uninitialized variable scenario; from Ray Lai
+ Make sure we can exit from a loop in v_key_init() regardless
of the locale we're in; from Ray Lai
+ Appease GCC 3 and the C gods by fixing a couple of undefined
statements; from Ray Lai
+ Explicit braces around macro fields and logical operations,
gets rid of 148 warnings, no functional change
OpenBSD 3.6 -> OpenBSD 3.7: Mon Oct 17 19:04:19 2005
+ Use queue macros instead of directly accessing fields
ok pat@ "put it in" deraadt@
Thu Apr 21 15:39:31 2005
+ Spelling typo in comment; from ray
Thu Apr 21 09:00:25 2005
+ Avoid the "tcsetattr: Interrupted system call" fatal error
when resizing using a window manager that continuously sends
resize events; ok camield@ miod@
Thu Mar 10 18:03:45 2005
+ -v description comes before -w
+ Also a sentence tweak
Sun Jan 9 01:44:35 2005
+ Tidy up FAST STARTUP
+ Better example
+ Better section reference
Sat Jan 8 05:22:25 2005
+ Fix for FreeBSD PR#12801 from Sven Verdoolaege (nvi maintainer)
via FreeBSD (an infinite loop at certain case when options
"comment" and "leftright" are used)
+ Move a line of code which was "obviously" misplaced. This
fixes a core dump when auto-completing filenames and at least
one of the file names is larger than the screen width
+ When an error occurs in v_txt(), leave input mode
too. Otherwise, (among other things) db_get() thinks it can
re-use the TEXT buffers when it's not true, leading to a crash
because that TEXT buffer will be released just before it is
actually used to create a new one. From NetBSD, fixes NetBSD
PR#21797
+ Move the license into the body of the man page; ok millert@
Fri Jan 7 15:04:02 2005
+ Remove line in copyright declaration that conflicts with the
LICENSE file. OK bostic@sleepycat.com
OpenBSD 3.5 -> OpenBSD 3.6: Mon Nov 29 21:51:08 2004
+ Lowercase for consistency
+ Spell precede correctly. 'looks fine' millert@ krw@ ok jmc@
OpenBSD 3.4 -> OpenBSD 3.5: Mon Oct 4 21:45:59 2004
+ Refer to re_format.7 rather than egrep.1 for a description
of EREs
Fri Apr 9 12:12:44 2004
+ ex is not a screen editor
Fri Mar 19 08:14:52 2004
+ Clarify -c
Fri Feb 20 20:05:05 2004
+ Add `ruler' to the list of helpful options; suggested by millert@
+ Add section on helpful ex options; suggested by and ok millert@
Fri Feb 20 13:15:51 2004
+ Cleanup of 6.2: Options, set, and editor startup files
Mon Feb 9 21:16:06 2004
+ Point people to ex tutorial
+ Install edit USD; this has been updated/reworded to work as
an ex tutorial
Fri Jan 30 23:39:22 2004
+ Use paper.txt, rather than some arbitrary target
+ Some additional cleanup
+ Point people to 13.ex, and remove some unnecessary text from
SEE ALSO
Fri Jan 30 23:14:25 2004
+ Install exref; includes updates to sync with current behaviour
fixes, help, and ok millert@
Sun Jan 25 23:22:10 2004
+ Install all the catalogs; as cvs forgot to check this file in
when those were added; millert@ ok
Sat Jan 24 12:32:55 2004
+ Oops. no need for vitut comment
+ Install vi tutorial docs; these have been updated to reflect
reality; help and ok millert@
+ Document how file recovery works on OpenBSD; ok millert@
+ Make vi reference card and vi tutorial easier to find
+ Use -compact for FILES
Fri Jan 16 13:08:32 2004
+ Point people to vi.ref now that it's installed (and get its
name right)
+ Correct a path and Nm
Thu Jan 15 11:17:04 2004
+ Return documented lines option to original (default) value
as pointed out by millert@, it's terminal dependent
+ Update vi.ref to reflect reality; help and ok millert@