Validate summary temperature and provide better logging for summary retrieval from Ollama and OpenAI APIs

Author: johnwarne

classes/webpage-analyzer.php

@@ -507,6 +507,7 @@ public function getSummary() {
       !empty(OLLAMA_URL) &&
       !empty(OLLAMA_MODEL)
     ) {
+      $this->log->info('Trying to get summary from Ollama API for ' . $this->url);
       $model_is_available = false;
       $ollama_tags_url = OLLAMA_URL . '/api/tags';
       $curl_options = array(
@@ -551,19 +552,24 @@ public function getSummary() {
           $curl_response = curlURL($ollama_api_url, $curl_options) ?? '';
           if (!$curl_response) {
             $this->log->error('Ollama API response is empty or invalid');
-            $summary = '';
-          }
-          $response = json_decode($curl_response, true);
-          if (!empty($response['response']) && strlen($response['response']) > 100) {
-            $summary          = $response['response'];
-            $summary_provider = 'ollama';
-            $summary_model    = OLLAMA_MODEL;
-            $this->log->info("Summary for URL $this->url generated by Ollama model $summary_model");
+          } else {
+            $response = json_decode($curl_response, true);
+            if (!$response) {
+              $this->log->error('Ollama API response is not valid JSON');
+            } elseif (!empty($response['response']) && strlen($response['response']) > 100) {
+              $summary          = $response['response'];
+              $summary_provider = 'ollama';
+              $summary_model    = OLLAMA_MODEL;
+              $this->log->info("Summary for URL $this->url generated by Ollama model $summary_model");
+            } else {
+              $this->log->error('Ollama API response does not contain valid summary content');
+            }
           }
         }
       }
     }
     if(!$summary && !empty(OPENAI_API_KEY)) {
+      $this->log->info('Trying to get summary from OpenAI API for ' . $this->url);
       $openai_url = 'https://api.openai.com/v1/chat/completions';
       $openai_model = OPENAI_API_MODEL ?? 'gpt-4o-mini';
       $curl_options = array(
@@ -599,6 +605,12 @@ public function getSummary() {
         $summary_provider = 'openai';
         $summary_model    = $openai_model;
         $this->log->info("Summary for URL $this->url generated by OpenAI model $summary_model");
+      } else {
+        if(!empty($response['error']['message'])) {
+          $this->log->error('OpenAI API response contains an error: ' . $response['error']['message']);
+        } else {
+          $this->log->error('OpenAI API response does not contain valid summary content');
+        }
       }
     }
     if (!$summary) {

config.php

@@ -11,7 +11,7 @@
 
 
 // Set defaults
-const UPVOTE_RSS_VERSION            = '1.2.4';
+const UPVOTE_RSS_VERSION            = '1.2.5';
 const DEFAULT_PLATFORM              = 'lemmy';
 const DEFAULT_HACKER_NEWS_INSTANCE  = 'news.ycombinator.com';
 const DEFAULT_HACKER_NEWS_COMMUNITY = 'beststories';
@@ -295,6 +295,10 @@
 
 // Summary temperature
 $summary_temperature = $_SERVER["SUMMARY_TEMPERATURE"] ?? $_ENV["SUMMARY_TEMPERATURE"] ?? 0.4;
+$summary_temperature = floatval($summary_temperature);
+if (!($summary_temperature > 0 && $summary_temperature <= 1)) {
+  $summary_temperature = 0.4;
+}
 define('SUMMARY_TEMPERATURE', $summary_temperature);