Mass convert to slots: skipping project on error and add logging (#2538)

Author: leotsarev

src/JoinRpg.Portal/Pages/Admin/ConvertInactiveProjectsToSlots.cshtml.cs

@@ -21,10 +21,17 @@ public async Task OnGet()
 
         foreach (var projectId in projects)
         {
-            var id = new PrimitiveTypes.ProjectIdentification(projectId);
-            logger.LogInformation("About to convert {projectId} to slots", id);
-            await slotMassConvertService.MassConvert(id);
-            logger.LogInformation("Converted {projectId} to slots", id);
+            try
+            {
+                var id = new PrimitiveTypes.ProjectIdentification(projectId);
+                logger.LogInformation("About to convert {projectId} to slots", id);
+                await slotMassConvertService.MassConvert(id);
+                logger.LogInformation("Converted {projectId} to slots", id);
+            }
+            catch (Exception exception)
+            {
+                logger.LogError(exception, "Failing to convert {projectId} to slots, skipping", projectId);
+            }
         }
 
     }

src/JoinRpg.Services.Impl/CharacterServiceImpl.cs

@@ -219,100 +219,108 @@ public async Task SetFields(int projectId, int characterId, Dictionary<int, stri
 
     public async Task<int?> CreateSlotFromGroup(int projectId, int characterGroupId, string slotName, bool allowToChangeInactive)
     {
-        var group = await LoadProjectSubEntityAsync<CharacterGroup>(projectId, characterGroupId);
-
-        var projectInfo = await projectMetadataRepository.GetProjectMetadata(new(projectId));
-
-        if (!allowToChangeInactive)
+        try
         {
-            group.Project.EnsureProjectActive();
-        }
-
-        if (!IsCurrentUserAdmin)
-        {
-            group.Project
-                .RequestMasterAccess(CurrentUserId, acl => acl.CanEditRoles);
-        }
+            var group = await LoadProjectSubEntityAsync<CharacterGroup>(projectId, characterGroupId);
 
-        var claims = group.Claims.ToList();
+            var projectInfo = await projectMetadataRepository.GetProjectMetadata(new(projectId));
 
-        var needToSaveClaims = claims.Any();
-        var needToInitSlot = group.HaveDirectSlots && group.Project.Active;
-        var needToClearSlot = group.HaveDirectSlots;
-
-        logger.LogInformation("Group (Id={characterGroupId}, Name={characterGroupName}) is evaluated to convert to slot. Decision (SaveClaims: {needToSaveClaims}, InitSlot: {needToInitSlot}, ClearSlot: {needToClearSlot})",
-            characterGroupId,
-            group.CharacterGroupName,
-            needToSaveClaims,
-            needToInitSlot,
-            needToClearSlot);
+            if (!allowToChangeInactive)
+            {
+                group.Project.EnsureProjectActive();
+            }
 
-        if (!needToSaveClaims && !needToInitSlot && !needToClearSlot)
-        {
-            return null; // Do nothing
-        }
+            if (!IsCurrentUserAdmin)
+            {
+                group.Project
+                    .RequestMasterAccess(CurrentUserId, acl => acl.CanEditRoles);
+            }
 
-        MarkTreeModified(group.Project);
+            var claims = group.Claims.ToList();
 
-        Character? character;
-        if (needToSaveClaims || needToInitSlot)
-        {
+            var needToSaveClaims = claims.Any();
+            var needToInitSlot = group.HaveDirectSlots && group.Project.Active;
+            var needToClearSlot = group.HaveDirectSlots;
 
-            var addCharacterRequest = new AddCharacterRequest(
-                projectId,
-                new[] { characterGroupId },
-                CharacterTypeInfo.DefaultSlot(slotName),
-                new Dictionary<int, string?>());
+            logger.LogInformation("Group (Id={characterGroupId}, Name={characterGroupName}) is evaluated to convert to slot. Decision (SaveClaims: {needToSaveClaims}, InitSlot: {needToInitSlot}, ClearSlot: {needToClearSlot})",
+                characterGroupId,
+                group.CharacterGroupName,
+                needToSaveClaims,
+                needToInitSlot,
+                needToClearSlot);
 
-            character = new Character
+            if (!needToSaveClaims && !needToInitSlot && !needToClearSlot)
             {
-                ParentCharacterGroupIds =
-                    await ValidateCharacterGroupList(addCharacterRequest.ProjectId, Required(addCharacterRequest.ParentCharacterGroupIds)),
-                ProjectId = addCharacterRequest.ProjectId,
-                Project = group.Project,
-            };
-
-            SetCharacterSettings(character, addCharacterRequest.CharacterTypeInfo, projectInfo);
-
-            Create(character);
-
+                return null; // Do nothing
+            }
 
-            //TODO we do not send message for creating character
-            _ = fieldSaveHelper.SaveCharacterFields(CurrentUserId,
-                character,
-                addCharacterRequest.FieldValues, projectInfo);
+            MarkTreeModified(group.Project);
 
-            if (needToInitSlot)
+            Character? character;
+            if (needToSaveClaims || needToInitSlot)
             {
-                // Move limit to character
-                character.CharacterSlotLimit = group.DirectSlotsUnlimited ? null : group.AvaiableDirectSlots;
-                character.IsActive = true;
+
+                var addCharacterRequest = new AddCharacterRequest(
+                    projectId,
+                    new[] { characterGroupId },
+                    CharacterTypeInfo.DefaultSlot(slotName),
+                    new Dictionary<int, string?>());
+
+                character = new Character
+                {
+                    ParentCharacterGroupIds =
+                        await ValidateCharacterGroupList(addCharacterRequest.ProjectId, Required(addCharacterRequest.ParentCharacterGroupIds)),
+                    ProjectId = addCharacterRequest.ProjectId,
+                    Project = group.Project,
+                };
+
+                SetCharacterSettings(character, addCharacterRequest.CharacterTypeInfo, projectInfo);
+
+                Create(character);
+
+
+                //TODO we do not send message for creating character
+                _ = fieldSaveHelper.SaveCharacterFields(CurrentUserId,
+                    character,
+                    addCharacterRequest.FieldValues, projectInfo);
+
+                if (needToInitSlot)
+                {
+                    // Move limit to character
+                    character.CharacterSlotLimit = group.DirectSlotsUnlimited ? null : group.AvaiableDirectSlots;
+                    character.IsActive = true;
+                }
+                else
+                {
+                    character.CharacterSlotLimit = 0;
+                    character.IsActive = claims.Any(c => c.IsPending); // if there is some alive claim
+                }
+
+                // Move claims from group to character
+
+                foreach (var claim in claims)
+                {
+                    claim.CharacterGroupId = null;
+                    claim.Character = character;
+                }
             }
             else
             {
-                character.CharacterSlotLimit = 0;
-                character.IsActive = claims.Any(c => c.IsPending); // if there is some alive claim
+                character = null;
             }
 
-            // Move claims from group to character
+            //Remove direct claim settings for group 
+            group.HaveDirectSlots = false;
+            group.AvaiableDirectSlots = 0;
 
-            foreach (var claim in claims)
-            {
-                claim.CharacterGroupId = null;
-                claim.Character = character;
-            }
+            await UnitOfWork.SaveChangesAsync();
+
+            return character?.CharacterId;
         }
-        else
+        catch (Exception exception)
         {
-            character = null;
+            logger.LogError(exception, "Error during converting CharacterGroup={characterGroupId}", characterGroupId);
+            throw;
         }
-
-        //Remove direct claim settings for group 
-        group.HaveDirectSlots = false;
-        group.AvaiableDirectSlots = 0;
-
-        await UnitOfWork.SaveChangesAsync();
-
-        return character?.CharacterId;
     }
 }