Remove own shuffle() and use morelinq's

Author: leotsarev

src/JoinRpg.Helpers/StaticCollectionHelpers.cs

@@ -65,22 +65,6 @@ public static IEnumerable<T> WhereNotNull<T>(this IEnumerable<T?> source)
 
     public static IEnumerable<T> OrEmptyList<T>(this IEnumerable<T>? collection) => collection ?? Enumerable.Empty<T>();
 
-    public static IEnumerable<T> Shuffle<T>(
-        this IEnumerable<T> source)
-    {
-        ArgumentNullException.ThrowIfNull(source);
-
-        var sourceArray = source.ToArray();
-
-        for (var n = 0; n < sourceArray.Length; n++)
-        {
-            var k = Random.Shared.Next(n, sourceArray.Length);
-            yield return sourceArray[k];
-
-            sourceArray[k] = sourceArray[n];
-        }
-    }
-
     public static IEnumerable<T> UnionUntilTotalCount<T>(
         this IReadOnlyCollection<T> alreadyTaken,
         IEnumerable<T> toAdd,

src/JoinRpg.Portal/Controllers/GameGroupsController.cs

@@ -3,7 +3,6 @@
 using JoinRpg.Data.Interfaces;
 using JoinRpg.DataModel;
 using JoinRpg.Domain;
-using JoinRpg.Helpers;
 using JoinRpg.Portal.Controllers.Common;
 using JoinRpg.Portal.Infrastructure;
 using JoinRpg.Portal.Infrastructure.Authorization;
@@ -18,6 +17,7 @@
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Http.Extensions;
 using Microsoft.AspNetCore.Mvc;
+using MoreLinq;
 
 namespace JoinRpg.Portal.Controllers;