Tech/warnings (#3117)

* Enable & fix CA1835

* filename

Author: leotsarev

.editorconfig

@@ -210,3 +210,4 @@ dotnet_style_qualification_for_field = false:warning
 dotnet_style_qualification_for_property = false:warning
 dotnet_style_qualification_for_method = false:warning
 dotnet_style_qualification_for_event = false:warning
+dotnet_diagnostic.CA1835.severity = warning

src/JoinRpg.BlobStorage/AvatarDownloader.cs

@@ -32,7 +32,7 @@ public AvatarDownloader(IHttpClientFactory httpClientFactory, ILogger<AvatarDown
         var buffer = ArrayPool<byte>.Shared.Rent(8192);
 
         int read;
-        while ((read = await stream.ReadAsync(buffer, 0, buffer.Length, ct)) > 0)
+        while ((read = await stream.ReadAsync(buffer, ct)) > 0)
         {
             totalRead += read;
             if (totalRead > maxSize)

src/JoinRpg.BlobStorage/S3AvatarStorageService.cs

@@ -23,9 +23,9 @@ internal class S3AvatarStorageService(AvatarDownloader avatarDownloader,
             logger.LogInformation("Start uploading avatar from {avatarUri}", remoteUri);
 
             using var memoryStream = new MemoryStream(8192);
-            var downloadResult = await avatarDownloader.DownloadAvatarAsync(remoteUri, memoryStream, ct);
+            var (contentType, extension) = await avatarDownloader.DownloadAvatarAsync(remoteUri, memoryStream, ct);
 
-            var avatarName = CreateAvatarBlobName(remoteUri, downloadResult.Extension);
+            var avatarName = CreateAvatarBlobName(remoteUri, extension);
 
             var hash = SHA256.HashData(memoryStream);
             memoryStream.Seek(0, SeekOrigin.Begin);
@@ -36,7 +36,7 @@ internal class S3AvatarStorageService(AvatarDownloader avatarDownloader,
                 BucketName = options.BucketName,
                 Key = avatarName,
                 InputStream = memoryStream,
-                ContentType = downloadResult.ContentType,
+                ContentType = contentType,
                 ChecksumSHA256 = Convert.ToBase64String(hash),
             };