fix some nullable warnings (#1567)

Author: leotsarev

src/JoinRpg.Data.Interfaces/ICharacterRepository.cs

@@ -57,7 +57,7 @@ public class GroupHeader : IEquatable<GroupHeader>
         public bool Equals(GroupHeader? other) => other != null && CharacterGroupId == other.CharacterGroupId;
 
         /// <inheritdoc />
-        public override bool Equals(object obj) => Equals(obj as GroupHeader);
+        public override bool Equals(object? obj) => Equals(obj as GroupHeader);
 
         /// <inheritdoc />
         public override int GetHashCode() => CharacterGroupId;

src/JoinRpg.WebPortal.Models/AccommodationPotentialNeighbors.cs

@@ -33,7 +33,7 @@ public enum NeighborType
     public class AccommodationPotentialNeighborsComparer : IEqualityComparer<AccommodationPotentialNeighbors>
     {
 
-        public bool Equals(AccommodationPotentialNeighbors x, AccommodationPotentialNeighbors y)
+        public bool Equals(AccommodationPotentialNeighbors? x, AccommodationPotentialNeighbors? y)
         {
             //Check whether the objects are the same object. 
             if (Object.ReferenceEquals(x, y))

src/JoinRpg.WebPortal.Models/Characters/CharacterGroupListItemViewModel.cs

@@ -54,7 +54,7 @@ public int RootGroupId
 
         public bool Equals(CharacterGroupListItemViewModel? other) => other != null && other.CharacterGroupId == CharacterGroupId;
 
-        public override bool Equals(object obj) => Equals(obj as CharacterGroupListItemViewModel);
+        public override bool Equals(object? obj) => Equals(obj as CharacterGroupListItemViewModel);
 
         public override int GetHashCode() => CharacterGroupId;
 

src/JoinRpg.WebPortal.Models/Characters/CharacterGroupReportItemViewModel.cs

@@ -38,7 +38,7 @@ public class CharacterGroupReportItemViewModel : IEquatable<CharacterGroupReport
 
         public bool Equals(CharacterGroupReportItemViewModel? other) => other != null && other.CharacterGroupId == CharacterGroupId;
 
-        public override bool Equals(object obj) => Equals(obj as CharacterGroupReportItemViewModel);
+        public override bool Equals(object? obj) => Equals(obj as CharacterGroupReportItemViewModel);
 
         public override int GetHashCode() => CharacterGroupId;
 

src/JoinRpg.WebPortal.Models/Characters/CharacterTreeViewModel.cs

@@ -84,7 +84,7 @@ public class CharacterLinkViewModel : IEquatable<CharacterLinkViewModel>
 
         public bool Equals(CharacterLinkViewModel? other) => other != null && CharacterId == other.CharacterId;
 
-        public override bool Equals(object obj) => Equals(obj as CharacterLinkViewModel);
+        public override bool Equals(object? obj) => Equals(obj as CharacterLinkViewModel);
 
         public override int GetHashCode() => CharacterId;
 

src/JoinRpg.WebPortal.Models/Characters/CharacterViewModel.cs

@@ -52,7 +52,7 @@ public class CharacterViewModel :
 
         public bool Equals(CharacterViewModel? other) => other != null && CharacterId == other.CharacterId;
 
-        public override bool Equals(object obj) => Equals(obj as CharacterViewModel);
+        public override bool Equals(object? obj) => Equals(obj as CharacterViewModel);
 
         public override int GetHashCode() => CharacterId;
 

src/JoinRpg.WebPortal.Models/Claims/ClaimViewModel.cs

@@ -501,7 +501,7 @@ public ClaimFeeViewModel(Claim claim, ClaimViewModel model, int currentUserId)
             ProjectId = claim.ProjectId;
             FeeVariants = claim.Project.ProjectFeeSettings
                 .Select(f => f.Fee)
-                .Union(CurrentFee)
+                .Append(CurrentFee)
                 .OrderBy(x => x)
                 .ToList();
             FinanceOperations = claim.FinanceOperations

src/JoinRpg.WebPortal.Models/CustomFieldsViewModels.cs

@@ -73,7 +73,7 @@ public class FieldValueViewModel
 
         public bool HasMasterAccess { get; }
 
-        public string Value { get; }
+        public string? Value { get; }
 
         public bool HasValue { get; }
 
@@ -386,8 +386,8 @@ private FieldValueViewModel CreateFieldValueView(FieldWithValue fv, ILinkRendere
         public bool AnythingAccessible => Fields.Any(f => f.CanEdit || f.CanView);
 
         [CanBeNull]
-        public FieldValueViewModel FieldById(int projectFieldId) => Fields.SingleOrDefault(field => field.ProjectFieldId == projectFieldId);
+        public FieldValueViewModel? FieldById(int projectFieldId) => Fields.SingleOrDefault(field => field.ProjectFieldId == projectFieldId);
         [CanBeNull]
-        public FieldValueViewModel Field(ProjectField field) => FieldById(field.ProjectFieldId);
+        public FieldValueViewModel? Field(ProjectField field) => FieldById(field.ProjectFieldId);
     }
 }

src/JoinRpg.WebPortal.Models/Helpers/FinanceDisplayExtensions.cs

@@ -11,7 +11,7 @@ public static class FinanceDisplayExtensions
         /// <summary>
         /// Returns display name of the payment type kind
         /// </summary>
-        public static string GetDisplayName(this PaymentTypeKindViewModel kind, User user, string defaultName = null)
+        public static string GetDisplayName(this PaymentTypeKindViewModel kind, User? user, string? defaultName = null)
         {
             switch (kind)
             {
@@ -29,7 +29,7 @@ public static string GetDisplayName(this PaymentTypeKindViewModel kind, User use
         /// <summary>
         /// Returns display name of the payment type kind
         /// </summary>
-        public static string GetDisplayName(this PaymentTypeKind kind, User user, string defaultName = null)
+        public static string GetDisplayName(this PaymentTypeKind kind, User user, string? defaultName = null)
             => ((PaymentTypeKindViewModel)kind).GetDisplayName(user, defaultName);
 
         /// <summary>

src/JoinRpg.WebPortal.Models/Print/HtmlCardPrintResult.cs

@@ -4,7 +4,7 @@ namespace JoinRpg.Web.Models.Print
 {
     public class HtmlCardPrintResult
     {
-        public HtmlCardPrintResult(string html, CardSize cardSize, string backgroundUrl = null)
+        public HtmlCardPrintResult(string html, CardSize cardSize, string? backgroundUrl = null)
         {
             Html = html;
             CardSize = cardSize;
@@ -17,8 +17,8 @@ public HtmlCardPrintResult(string html, CardSize cardSize, string backgroundUrl
         [PublicAPI]
         public CardSize CardSize { get; }
 
-        [PublicAPI, CanBeNull]
-        public string BackgroundUrl { get; }
+        [PublicAPI]
+        public string? BackgroundUrl { get; }
     }
 
     public enum CardSize