Skip to content

Commit ebbf4b3

Browse files
authored
Fix problem with moving groups (#1524)
1 parent 63cbd76 commit ebbf4b3

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/JoinRpg.Portal/Controllers/GameGroupsController.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ private static T FillFromCharacterGroup<T>(T viewModel, IClaimSource field)
440440
}
441441

442442
[MasterAuthorize(Permission.CanEditRoles)]
443-
[HttpPost]
443+
[HttpGet]
444444
public Task<ActionResult> MoveUp(int projectId, int charactergroupId, int parentCharacterGroupId, int currentRootGroupId) => MoveImpl(projectId, charactergroupId, parentCharacterGroupId, currentRootGroupId, -1);
445445

446446
private async Task<ActionResult> MoveImpl(int projectId, int charactergroupId, int parentCharacterGroupId, int currentRootGroupId, short direction)
@@ -460,7 +460,7 @@ private async Task<ActionResult> MoveImpl(int projectId, int charactergroupId, i
460460
}
461461

462462
[MasterAuthorize(Permission.CanEditRoles)]
463-
[HttpPost]
463+
[HttpGet]
464464
public Task<ActionResult> MoveDown(int projectId, int charactergroupId, int parentCharacterGroupId, int currentRootGroupId) => MoveImpl(projectId, charactergroupId, parentCharacterGroupId, currentRootGroupId, +1);
465465

466466
[HttpGet, MasterAuthorize()]

src/JoinRpg.WebPortal.Models/Characters/CharacterGroupListViewModel.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ public IList<CharacterGroupListItemViewModel> Generate()
103103
vm.ChildGroups = childGroups
104104
.Select(childGroup => GenerateFrom(childGroup, deepLevel + 1, pathForChildren))
105105
.WhereNotNull()
106+
.ToList();
107+
108+
_ = vm.ChildGroups
109+
.Where(x => !x.IsSpecial)
106110
.MarkFirstAndLast();
107111

108112
return vm;

0 commit comments

Comments
 (0)