Fix Null ref in User detailts page

Author: leotsarev

src/JoinRpg.DataModel/Users/User.cs

@@ -42,7 +42,7 @@ public class User
 
         public virtual AllrpgUserDetails Allrpg { get; set; }
         [CanBeNull]
-        public virtual UserExtra Extra { get; set; }
+        public virtual UserExtra? Extra { get; set; }
 
         public virtual HashSet<UserSubscription> Subscriptions { get; set; }
 

src/JoinRpg.Portal/Controllers/UserProfile/UserController.cs

@@ -20,7 +20,7 @@ public async Task<ActionResult> Details(int userId)
         {
             var user = await UserRepository.GetById(userId);
 
-            var currentUser = User.Identity.IsAuthenticated ? await UserRepository.GetById(CurrentUserAccessor.UserId) : null;
+            var currentUser = User.Identity?.IsAuthenticated == true ? await UserRepository.GetById(CurrentUserAccessor.UserId) : null;
 
             var accessReason = (AccessReason)user.GetProfileAccess(currentUser);
             var userProfileViewModel = new UserProfileViewModel()

src/JoinRpg.WebPortal.Models/JoinRpg.WebPortal.Models.csproj

@@ -4,7 +4,7 @@
     <TargetFramework>net5</TargetFramework>
     <RootNamespace>JoinRpg.Web.Models</RootNamespace>
       <NoWarn>${NoWarn};1591</NoWarn>
-    <Nullable>annotations</Nullable>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

src/JoinRpg.WebPortal.Models/UserProfile/UserProfileViewModel.cs

@@ -25,7 +25,7 @@ public IEnumerable<ProjectLinkViewModel> ProjectsToAdd
           => CanGrantAccessProjects.Where(acl => ThisUserProjects.All(acl1 => acl1.ProjectId != acl.ProjectId));
 
         [ReadOnly(true)]
-        public ClaimListViewModel Claims { get; set; }
+        public ClaimListViewModel? Claims { get; set; }
 
         public UserProfileDetailsViewModel Details { get; set; }
 
@@ -47,21 +47,21 @@ public class UserProfileDetailsViewModel
         [Display(Name = "Номер телефона"), DataType(DataType.PhoneNumber), UIHint("PhoneNumber")]
         public string PhoneNumber { get; }
         [Display(Name = "Skype"), UIHint("Skype")]
-        public string Skype { get; }
+        public string? Skype { get; }
         [Display(Name = "Telegram"), UIHint("Telegram")]
-        public string Telegram { get; }
+        public string? Telegram { get; }
         [Display(Name = "ЖЖ"), UIHint("Livejournal")]
-        public string Livejournal { get; }
+        public string? Livejournal { get; }
         [Display(Name = "VK"), UIHint("Vkontakte")]
-        public string Vk { get; }
+        public string? Vk { get; }
         [UIHint("Email")]
         public string Email { get; }
         [DisplayName("ФИО")]
         public string FullName { get; }
 
         public int? AllrpgId { get; }
 
-        public AvatarIdentification Avatar { get; }
+        public AvatarIdentification? Avatar { get; }
         [Editable(false)]
         public UserLinkViewModel User { get; }
 
@@ -95,7 +95,7 @@ public UserProfileDetailsViewModel(User user, AccessReason reason)
                 IsVerifiedUser = user.VerifiedProfileFlag;
                 IsAdmin = user.Auth.IsAdmin;
             }
-            if (HasAccess || user.Extra.SocialNetworksAccess == ContactsAccessType.Public)
+            if (HasAccess || user.Extra?.SocialNetworksAccess == ContactsAccessType.Public)
             {
                 Vk = user.Extra?.Vk;
                 AllrpgId = user.Allrpg?.Sid;