Add ReferenceTrimmer and remove unused references (#2764)

leotsarev · web-flow · commit f43b1f692b8e · 2024-08-21T09:57:48.000Z
* Add ReferenceTrimmer and remove unused references

* Generate documentation for more projects to check references correctly
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -31,4 +31,10 @@
             <_Parameter1>$(AssemblyName).Test</_Parameter1>
         </AssemblyAttribute>
     </ItemGroup>
+  <ItemGroup>
+    <PackageReference Include="ReferenceTrimmer" Version="3.3.6">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
 </Project>
diff --git a/src/JoinRpg.DI/JoinRpg.DI.csproj b/src/JoinRpg.DI/JoinRpg.DI.csproj
@@ -7,7 +7,6 @@
     <PackageReference Include="Autofac" Version="8.0.0" />
   </ItemGroup>
   <ItemGroup>
-    <ProjectReference Include="..\JoinRpg.Common.EmailSending.Impl\JoinRpg.Common.EmailSending.Impl.csproj" />
     <ProjectReference Include="..\JoinRpg.Dal.Impl\JoinRpg.Dal.Impl.csproj" />
     <ProjectReference Include="..\JoinRpg.Services.Email\JoinRpg.Services.Email.csproj" />
     <ProjectReference Include="..\JoinRpg.Services.Export\JoinRpg.Services.Export.csproj" />
diff --git a/src/JoinRpg.Dal.Impl/JoinRpg.Dal.Impl.csproj b/src/JoinRpg.Dal.Impl/JoinRpg.Dal.Impl.csproj
@@ -4,7 +4,6 @@
     <RootNamespace>JoinRpg.Dal.Impl</RootNamespace>
     <AssemblyName>JoinRpg.Dal.Impl</AssemblyName>
     <EmbeddedResourceUseDependentUponConvention>true</EmbeddedResourceUseDependentUponConvention>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\JoinRpg.Data.Interfaces\JoinRpg.Data.Interfaces.csproj" />
diff --git a/src/JoinRpg.Dal.Impl/Repositories/ClaimsRepositoryImpl.cs b/src/JoinRpg.Dal.Impl/Repositories/ClaimsRepositoryImpl.cs
@@ -78,7 +78,7 @@ public async Task<IReadOnlyCollection<ClaimWithPlayer>> GetClaimHeadersWithPlaye
             {
                 Player = claim.Player,
                 ClaimId = claim.ClaimId,
-                CharacterName = claim.Character.CharacterName,
+                CharacterName = claim.Character!.CharacterName,
                 Extra = claim.Player.Extra,
             })
           .ToListAsync();
diff --git a/src/JoinRpg.Helpers.Test/JoinRpg.Helpers.Test.csproj b/src/JoinRpg.Helpers.Test/JoinRpg.Helpers.Test.csproj
@@ -7,7 +7,6 @@
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\JoinRpg.Helpers\JoinRpg.Helpers.csproj" />
-    <ProjectReference Include="..\JoinRpg.TestHelpers\JoinRpg.TestHelpers.csproj" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
diff --git a/src/JoinRpg.Helpers.Web.Test/JoinRpg.Helpers.Web.Test.csproj b/src/JoinRpg.Helpers.Web.Test/JoinRpg.Helpers.Web.Test.csproj
@@ -7,7 +7,6 @@
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\JoinRpg.Helpers.Web\JoinRpg.Helpers.Web.csproj" />
-    <ProjectReference Include="..\JoinRpg.TestHelpers\JoinRpg.TestHelpers.csproj" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
diff --git a/src/JoinRpg.Helpers/JoinRpg.Helpers.csproj b/src/JoinRpg.Helpers/JoinRpg.Helpers.csproj
@@ -6,7 +6,4 @@
     <LangVersion>latest</LangVersion>
     <ImplicitUsings>enable</ImplicitUsings>
   </PropertyGroup>
-    <ItemGroup>
-    <PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
-  </ItemGroup>
 </Project>
diff --git a/src/JoinRpg.IntegrationTests/JoinRpg.IntegrationTest.csproj b/src/JoinRpg.IntegrationTests/JoinRpg.IntegrationTest.csproj
@@ -4,7 +4,6 @@
         <TargetFramework>net8.0</TargetFramework>
 
         <IsPackable>false</IsPackable>
-        <GenerateDocumentationFile>false</GenerateDocumentationFile>
     </PropertyGroup>
 
     <ItemGroup>
diff --git a/src/JoinRpg.Markdown.Test/JoinRpg.Markdown.Test.csproj b/src/JoinRpg.Markdown.Test/JoinRpg.Markdown.Test.csproj
@@ -7,7 +7,6 @@
   <ItemGroup>
     <ProjectReference Include="..\JoinRpg.Helpers\JoinRpg.Helpers.csproj" />
     <ProjectReference Include="..\JoinRpg.Markdown\JoinRpg.Markdown.csproj" />
-    <ProjectReference Include="..\JoinRpg.TestHelpers\JoinRpg.TestHelpers.csproj" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
diff --git a/src/JoinRpg.Portal.Test/JoinRpg.Portal.Test.csproj b/src/JoinRpg.Portal.Test/JoinRpg.Portal.Test.csproj
@@ -4,7 +4,6 @@
     <TargetFramework>net8.0</TargetFramework>
 
     <IsPackable>false</IsPackable>
-      <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/JoinRpg.Portal/JoinRpg.Portal.csproj b/src/JoinRpg.Portal/JoinRpg.Portal.csproj
@@ -47,6 +47,7 @@
     <ProjectReference Include="..\Joinrpg.AspNetCore.Helpers\Joinrpg.AspNetCore.Helpers.csproj" />
     <ProjectReference Include="..\JoinRpg.Blazor.Client\JoinRpg.Blazor.Client.csproj" />
     <ProjectReference Include="..\JoinRpg.BlobStorage\JoinRpg.BlobStorage.csproj" />
+    <ProjectReference Include="..\JoinRpg.Common.EmailSending.Impl\JoinRpg.Common.EmailSending.Impl.csproj" />
     <ProjectReference Include="..\JoinRpg.Dal.DataProtection\JoinRpg.Dal.DataProtection.csproj" />
     <ProjectReference Include="..\JoinRpg.Dal.JobService\JoinRpg.Dal.JobService.csproj" />
     <ProjectReference Include="..\JoinRpg.DI\JoinRpg.DI.csproj" />
diff --git a/src/JoinRpg.PrimitiveTypes/JoinRpg.PrimitiveTypes.csproj b/src/JoinRpg.PrimitiveTypes/JoinRpg.PrimitiveTypes.csproj
@@ -3,7 +3,6 @@
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
     <Nullable>enable</Nullable>
-    <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/JoinRpg.Services.Email.Test/JoinRpg.Services.Email.Test.csproj b/src/JoinRpg.Services.Email.Test/JoinRpg.Services.Email.Test.csproj
@@ -9,8 +9,6 @@
     <ProjectReference Include="..\JoinRpg.DataModel.Mocks\JoinRpg.DataModel.Mocks.csproj" />
     <ProjectReference Include="..\JoinRpg.DataModel\JoinRpg.DataModel.csproj" />
     <ProjectReference Include="..\JoinRpg.Domain\JoinRpg.Domain.csproj" />
-    <ProjectReference Include="..\JoinRpg.Services.Interfaces\JoinRpg.Services.Interfaces.csproj" />
-    <ProjectReference Include="..\JoinRpg.TestHelpers\JoinRpg.TestHelpers.csproj" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
diff --git a/src/JoinRpg.Services.Impl.Test/JoinRpg.Services.Impl.Test.csproj b/src/JoinRpg.Services.Impl.Test/JoinRpg.Services.Impl.Test.csproj
@@ -6,7 +6,6 @@
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\JoinRpg.Services.Impl\JoinRpg.Services.Impl.csproj" />
-    <ProjectReference Include="..\JoinRpg.TestHelpers\JoinRpg.TestHelpers.csproj" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.0" />
diff --git a/src/JoinRpg.WebPortal.Models/JoinRpg.WebPortal.Models.csproj b/src/JoinRpg.WebPortal.Models/JoinRpg.WebPortal.Models.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\JoinRpg.Dal.Impl\JoinRpg.Dal.Impl.csproj" />
     <ProjectReference Include="..\JoinRpg.PrimitiveTypes\JoinRpg.PrimitiveTypes.csproj" />
     <ProjectReference Include="..\JoinRpg.CommonUI.Models\JoinRpg.CommonUI.Models.csproj" />
     <ProjectReference Include="..\JoinRpg.Data.Interfaces\JoinRpg.Data.Interfaces.csproj" />

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public async Task<IReadOnlyCollection<ClaimWithPlayer>> GetClaimHeadersWithPlaye`
`78`	`78`	`{`
`79`	`79`	`Player = claim.Player,`
`80`	`80`	`ClaimId = claim.ClaimId,`
`81`		`- CharacterName = claim.Character.CharacterName,`
	`81`	`+ CharacterName = claim.Character!.CharacterName,`
`82`	`82`	`Extra = claim.Player.Extra,`
`83`	`83`	`})`
`84`	`84`	`.ToListAsync();`