Skip to content

Commit 39bf6f3

Browse files
authored
Merge pull request #47 from jolicode/fix/40-php-8-2
support php 8.2 and test it
2 parents 1331381 + 2a50859 commit 39bf6f3

File tree

20 files changed

+29
-29
lines changed

20 files changed

+29
-29
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
strategy:
5757
max-parallel: 15
5858
matrix:
59-
php-versions: ['8.3', '8.4']
59+
php-versions: ['8.2', '8.3', '8.4']
6060
steps:
6161
- name: Checkout
6262
uses: actions/checkout@v5

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"imagine/imagine": "^1.5",
5050
"league/flysystem-bundle": "^3.4",
5151
"league/flysystem-memory": "^3.0",
52-
"phpunit/phpunit": "^12",
52+
"phpunit/phpunit": "^11",
5353
"psr/log": "^2.0 || ^3.0",
5454
"sonata-project/admin-bundle": "^4.30",
5555
"symfony/browser-kit": "^7.0 || ^8.0",

doc/misc-features/events.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ When resolving a media, the ``PreResolveMediaEvent`` can be used to modify the m
6464

6565
final class ResolveEventListener
6666
{
67-
private const string MEDIA_ORIGINAL_PATH = 'some/legacy/prefix/';
67+
private const MEDIA_ORIGINAL_PATH = 'some/legacy/prefix/';
6868

6969
#[AsEventListener(event: MediaEvents::PRE_RESOLVE_MEDIA)]
7070
public function onPreResolve(PreResolveMediaEvent $event): void

doc/variations/pre-processors.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ A pre-processor class must implement the ``process`` method of the ``Joli\MediaB
5656

5757
readonly class OgImagePreProcessor extends AbstractPreProcessor implements PreProcessorInterface
5858
{
59-
private const int WIDTH = 1200;
60-
private const int HEIGHT = 1000;
59+
private const WIDTH = 1200;
60+
private const HEIGHT = 1000;
6161

6262
public function __construct(
6363
private ImagineInterface $imagine,

src/Bridge/EasyAdmin/src/Asset/Package.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
final readonly class Package implements PackageInterface
1212
{
13-
public const string NAME = 'joli-media-easy-admin';
13+
public const NAME = 'joli-media-easy-admin';
1414

1515
private PackageInterface $package;
1616

src/Bridge/SonataAdmin/src/Asset/Package.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
final readonly class Package implements PackageInterface
1212
{
13-
public const string NAME = 'joli-media-sonata-admin';
13+
public const NAME = 'joli-media-sonata-admin';
1414

1515
private PackageInterface $package;
1616

src/Doctrine/Type/MediaType.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class MediaType extends StringType
1313
use MediaTypeTrait;
1414

1515
#[\Deprecated(message: 'use Types::MEDIA instead')]
16-
public const string NAME = Types::MEDIA;
16+
public const NAME = Types::MEDIA;
1717

1818
/**
1919
* @param Media|string|null $value

src/Doctrine/Types.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55
class Types
66
{
7-
public const string MEDIA = 'media';
7+
public const MEDIA = 'media';
88

9-
public const string MEDIA_LONG = 'media_long';
9+
public const MEDIA_LONG = 'media_long';
1010

1111
public const MEDIA_TYPES = [
1212
self::MEDIA,

src/Inspector/TransformationDataHolder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
class TransformationDataHolder
1212
{
13-
private const string STOPWATCH_KEY = 'JoliMediaBundle';
13+
private const STOPWATCH_KEY = 'JoliMediaBundle';
1414

1515
private const TRANSFORMATION_PROPERTIES = [
1616
'binaryWidth' => 'Binary width (before the transformation)',

src/PostProcessor/Gifsicle.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/**
1111
* @var array<string, mixed>
1212
*/
13-
private const array DEFAULT_OPTIONS = [
13+
private const DEFAULT_OPTIONS = [
1414
'optimize' => 3,
1515
'lossy' => 20,
1616
'colors' => 256,

0 commit comments

Comments
 (0)