Merge pull request #68 from jolicode/log-when-no-library-defined

log a warning when no library is defined

Author: xavierlacot

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [0.1.4] - 2024-11-23
+
+- fix - do not trigger an error when no library is defined
+
 ## [0.1.3] - 2024-11-23
 
 - fix - `Request::get()` deprecation
@@ -47,3 +51,4 @@ This is the initial release of the bundle.
 [0.1.1]: https://github.com/jolicode/mediabundle/releases/tag/v0.1.1
 [0.1.2]: https://github.com/jolicode/mediabundle/releases/tag/v0.1.2
 [0.1.3]: https://github.com/jolicode/mediabundle/releases/tag/v0.1.3
+[0.1.4]: https://github.com/jolicode/mediabundle/releases/tag/v0.1.4

config/services.php

@@ -206,7 +206,10 @@
         // library
         ->set('joli_media.library_container', LibraryContainer::class)
         ->public()
-        ->arg('$libraries', tagged_locator('joli_media.library', indexAttribute: 'name'))
+        ->args([
+            '$libraries' => tagged_locator('joli_media.library', indexAttribute: 'name'),
+            '$logger' => service('logger')->ignoreOnInvalid(),
+        ])
         ->alias(LibraryContainer::class, 'joli_media.library_container')
 
         ->set('.joli_media.library.abstract', Library::class)

src/JoliMediaBundle.php

@@ -97,7 +97,7 @@ public function loadExtension(array $config, ContainerConfigurator $container, C
 
         // define the default library name
         $builder->getDefinition('joli_media.library_container')
-            ->setArgument('$defaultLibraryName', $config['default_library'] ?? array_key_first($config['libraries']))
+            ->setArgument('$defaultLibraryName', $config['default_library'])
         ;
 
         // pre-processors

src/Library/LibraryContainer.php

@@ -2,16 +2,27 @@
 
 namespace JoliCode\MediaBundle\Library;
 
+use Psr\Log\LoggerInterface;
 use Symfony\Component\DependencyInjection\ServiceLocator;
 
 class LibraryContainer
 {
     public function __construct(
         private readonly ServiceLocator $libraries,
-        private string $defaultLibraryName,
+        private ?string $defaultLibraryName = null,
+        private readonly ?LoggerInterface $logger = null,
     ) {
-        if (!$this->has($defaultLibraryName)) {
-            throw new \InvalidArgumentException(\sprintf('Library "%s" not found.', $defaultLibraryName));
+        if (0 === $libraries->count()) {
+            $this->logger?->warning('No library has been defined in the MediaBundle configuration. Please add one to be able to use the bundle features.');
+        }
+
+        if (null === $this->defaultLibraryName && $libraries->count() > 0) {
+            $names = array_keys($libraries->getProvidedServices());
+            $this->defaultLibraryName = $names[0];
+        }
+
+        if (null !== $this->defaultLibraryName && !$this->has($this->defaultLibraryName)) {
+            throw new \InvalidArgumentException(\sprintf('Library "%s" not found.', $this->defaultLibraryName));
         }
     }
 
@@ -30,11 +41,19 @@ public function get(?string $name = null): Library
 
     public function getDefault(): Library
     {
+        if (null === $this->defaultLibraryName) {
+            throw new \InvalidArgumentException('The default library is not defined');
+        }
+
         return $this->get($this->defaultLibraryName);
     }
 
     public function getDefaultName(): string
     {
+        if (null === $this->defaultLibraryName) {
+            throw new \InvalidArgumentException('The default library is not defined');
+        }
+
         return $this->defaultLibraryName;
     }