fix: handle case where class target has adder and remover AND constructor arguments (#212)

After some attempts, I came to this solution for this issue:
#211.

Not sure if it's the right thing to do.

Author: Korbeil

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Fixed
 - [GH#207](https://github.com/jolicode/automapper/pull/207) [GH#208](https://github.com/jolicode/automapper/pull/208) Fix implicity nullable parameter deprecations
+- [GH#212](https://github.com/jolicode/automapper/pull/212) Fix cases where class target has adder and remover AND constructor arguments
 
 ## [9.2.0] - 2024-11-19
 ### Added

src/Transformer/AbstractArrayTransformer.php

@@ -43,7 +43,7 @@ public function transform(Expr $input, Expr $target, PropertyMetadata $propertyM
         /* Get the transform statements for the source property */
         [$output, $itemStatements] = $this->itemTransformer->transform($loopValueVar, $target, $propertyMapping, $uniqueVariableScope, $source);
 
-        if ($propertyMapping->target->writeMutator && $propertyMapping->target->writeMutator->type === WriteMutator::TYPE_ADDER_AND_REMOVER) {
+        if (null === $propertyMapping->target->parameterInConstructor && $propertyMapping->target->writeMutator && $propertyMapping->target->writeMutator->type === WriteMutator::TYPE_ADDER_AND_REMOVER) {
             /**
              * Use add and remove methods.
              *

tests/AutoMapperTest.php

@@ -48,6 +48,7 @@
 use AutoMapper\Tests\Fixtures\ObjectWithDateTime;
 use AutoMapper\Tests\Fixtures\Order;
 use AutoMapper\Tests\Fixtures\PetOwner;
+use AutoMapper\Tests\Fixtures\PetOwnerWithConstructorArguments;
 use AutoMapper\Tests\Fixtures\PrivatePropertyInConstructors\ChildClass;
 use AutoMapper\Tests\Fixtures\PrivatePropertyInConstructors\OtherClass;
 use AutoMapper\Tests\Fixtures\Provider\CustomProvider;
@@ -1088,6 +1089,26 @@ public function testAdderAndRemoverWithNull(): void
         self::assertCount(0, $petOwnerData->getPets());
     }
 
+    public function testAdderAndRemoverWithConstructorArguments(): void
+    {
+        if (!class_exists(ClassDiscriminatorFromClassMetadata::class)) {
+            self::markTestSkipped('Symfony Serializer is required to run this test.');
+        }
+
+        $petOwner = [
+            'pets' => [
+                ['type' => 'cat', 'name' => 'Félix'],
+            ],
+        ];
+
+        $petOwnerData = $this->autoMapper->map($petOwner, PetOwnerWithConstructorArguments::class);
+
+        self::assertIsArray($petOwnerData->getPets());
+        self::assertCount(1, $petOwnerData->getPets());
+        self::assertSame('Félix', $petOwnerData->getPets()[0]->name);
+        self::assertSame('cat', $petOwnerData->getPets()[0]->type);
+    }
+
     public function testIssueTargetToPopulate(): void
     {
         $source = new Fixtures\IssueTargetToPopulate\VatModel();

tests/Fixtures/PetOwnerWithConstructorArguments.php

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace AutoMapper\Tests\Fixtures;
+
+class PetOwnerWithConstructorArguments
+{
+    /** @var array<int, Pet> */
+    private $pets;
+
+    public function __construct(array $pets)
+    {
+        $this->pets = $pets;
+    }
+
+    /**
+     * @return Pet[]
+     */
+    public function getPets(): array
+    {
+        return $this->pets;
+    }
+
+    public function addPet(Pet $pet): void
+    {
+        $this->pets[] = $pet;
+    }
+
+    public function removePet(Pet $pet): void
+    {
+        $index = array_search($pet, $this->pets);
+
+        if ($index !== false) {
+            unset($this->pets[$index]);
+        }
+    }
+}