Clean the tests suite (#243)

Author: joelwurtz

.php-cs-fixer.php

@@ -24,6 +24,7 @@
         'no_trailing_comma_in_singleline' => false,
         'function_declaration' => ['trailing_comma_single_line' => true],
         'phpdoc_to_comment' => ['allow_before_return_statement' => true],
+        'psr_autoloading'  => false, // Does not work well with "map.php" files in tests
         PhpCsFixerCustomFixers\Fixer\MultilinePromotedPropertiesFixer::name() => true,
     ])
     ->setFinder($finder)

castor.php

@@ -15,15 +15,15 @@ function qa_cs_check()
     ]);
 }
 
-#[AsTask('cs:fix', namespace: 'qa', description: 'Fix all coding standards')]
+#[AsTask('cs:fix', namespace: 'qa', description: 'Fix all coding standards', aliases: ['cs'])]
 function qa_cs_fix()
 {
-    php_cs_fixer(['fix', '--config', __DIR__ . '/.php-cs-fixer.php'], '3.50', [
+    php_cs_fixer(['fix', '--config', __DIR__ . '/.php-cs-fixer.php', '-v'], '3.50', [
         'kubawerlos/php-cs-fixer-custom-fixers' => '^3.21',
     ]);
 }
 
-#[AsTask('phpstan', namespace: 'qa', description: 'Run PHPStan for static analysis')]
+#[AsTask('phpstan', namespace: 'qa', description: 'Run PHPStan for static analysis', aliases: ['phpstan'])]
 function qa_phpstan(bool $generateBaseline = false)
 {
     $params = ['analyse', '--configuration', __DIR__ . '/phpstan.neon', '--memory-limit=-1', '-v'];

composer.json

@@ -37,6 +37,7 @@
         "phpunit/phpunit": "^9.0",
         "symfony/browser-kit": "^6.4 || ^7.0",
         "symfony/console": "^6.4 || ^7.0",
+        "symfony/finder": "^6.4 || ^7.2",
         "symfony/filesystem": "^6.4 || ^7.0",
         "symfony/framework-bundle": "*",
         "symfony/http-client": "^6.4 || ^7.0",
@@ -45,6 +46,7 @@
         "symfony/stopwatch": "^6.4 || ^7.0",
         "symfony/twig-bundle": "^6.4 || ^7.0",
         "symfony/uid": "^6.4 || ^7.0",
+        "symfony/var-dumper": "^6.4 || ^7.2",
         "symfony/web-profiler-bundle": "^6.4 || ^7.0",
         "symfony/yaml": "^6.4 || ^7.0",
         "willdurand/negotiation": "^3.0"

tests/AutoMapperBaseTest.php tests/AutoMapperBuilder.phptests/AutoMapperBaseTest.php renamed to tests/AutoMapperBuilder.php

@@ -8,25 +8,16 @@
 use AutoMapper\Configuration;
 use AutoMapper\ConstructorStrategy;
 use AutoMapper\Symfony\ExpressionLanguageProvider;
-use PHPUnit\Framework\TestCase;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Filesystem\Filesystem;
 
 /**
  * @author Baptiste Leduc <[email protected]>
  */
-abstract class AutoMapperBaseTest extends TestCase
+class AutoMapperBuilder
 {
-    protected AutoMapper $autoMapper;
-
-    protected function setUp(): void
-    {
-        unset($this->autoMapper);
-        $this->buildAutoMapper();
-    }
-
-    protected function buildAutoMapper(
+    public static function buildAutoMapper(
         bool $allowReadOnlyTargetToPopulate = false,
         bool $mapPrivatePropertiesAndMethod = false,
         ConstructorStrategy $constructorStrategy = ConstructorStrategy::AUTO,
@@ -53,7 +44,7 @@ classPrefix: $classPrefix,
             allowReadOnlyTargetToPopulate: $allowReadOnlyTargetToPopulate,
         );
 
-        return $this->autoMapper = AutoMapper::create(
+        return AutoMapper::create(
             $configuration,
             cacheDirectory: __DIR__ . '/cache/',
             transformerFactories: $transformerFactories,

tests/AutoMapperMapToTest.php

@@ -20,7 +20,7 @@
 /**
  * @author Joel Wurtz <[email protected]>
  */
-class AutoMapperMapToTest extends AutoMapperBaseTest
+class AutoMapperMapToTest extends AutoMapperTestCase
 {
     public function testMapTo()
     {
@@ -40,7 +40,7 @@ public function testMapToArray()
             'transformerWithDependency' => fn () => fn () => new TransformerWithDependency(new FooDependency()),
         ]));
 
-        $this->buildAutoMapper(propertyTransformers: [new TransformerWithDependency(new FooDependency())], expressionLanguageProvider: $expressionLanguageProvider);
+        $this->autoMapper = AutoMapperBuilder::buildAutoMapper(propertyTransformers: [new TransformerWithDependency(new FooDependency())], expressionLanguageProvider: $expressionLanguageProvider);
 
         $foo = new FooMapTo('foo');
         $bar = $this->autoMapper->map($foo, 'array');
@@ -86,7 +86,7 @@ public function testMapToArrayGroups()
             'transformerWithDependency' => fn () => fn () => new TransformerWithDependency(new FooDependency()),
         ]));
 
-        $this->buildAutoMapper(propertyTransformers: [new TransformerWithDependency(new FooDependency())], expressionLanguageProvider: $expressionLanguageProvider);
+        $this->autoMapper = AutoMapperBuilder::buildAutoMapper(propertyTransformers: [new TransformerWithDependency(new FooDependency())], expressionLanguageProvider: $expressionLanguageProvider);
 
         $foo = new FooMapTo('foo');
         $bar = $this->autoMapper->map($foo, 'array');