Discord Direct Message Failure Clarification

[fwosh]

The bot attempts to send dm's sequentially on the Secret Santa user list. As soon as it hits a failed dm, it will not attempt to send messages to the remaining users, regardless of whether the other users have the appropriate settings. This is misleading since the admin sees a full list of affected users (presumed to all have the wrong settings) and the FAQ is not clear that other message attempts have not been made.

Ideally, the FAQ can be clearer to communicate the above. That is, the user with the thrown error must be fixed in order for the bot to continue trying to send the messages to remaining users.

https://secret-santa.team/faq#discord-server-dm

(Or of course, attempt to send to other users and only throw errors for those affected.)

[damienalexandre]

Hi! Thanks for the detailed report, we are aware of this situation - sadly we have no way to tell if a member disabled bot messages before actually sending a message to him (as far as we know).

Maybe we can improve this part:

secret-santa/src/Santa/MessageDispatcher.php

Lines 29 to 46 in 1c59ec0

	public function dispatchRemainingMessages(SecretSanta $secretSanta, ApplicationInterface $application): void
	{
	$startTime = time();
	$failedUsers = $secretSanta->getErrors();
	foreach ($secretSanta->getRemainingAssociations() as $giver => $receiver) {
	if ((time() - $startTime) > 5) {
	throw new MessageDispatchTimeoutException($secretSanta);
	}
	if ($failedUsers[$giver] ?? false) {
	continue;
	}
	$application->sendSecretMessage($secretSanta, $giver, $receiver);
	$secretSanta->markAssociationAsProceeded($giver);
	}
	}

To try other members before sending the MessageSendFailedException.

Would you be interested in contributing a Pull Request for this?