Merge pull request #23 from jolicode/doctrine

Change the type of Seo Columns from string(255) to text

Author: pyrech

.travis.yml

@@ -31,3 +31,7 @@ before_script:
 script:
     - vendor/bin/simple-phpunit
     - if [ "$check_cs" = "true" ]; then vendor/bin/php-cs-fixer fix --config=.php_cs --dry-run --diff; fi;
+
+branches:
+  only:
+    - master

CHANGELOG.md

@@ -1,6 +1,9 @@
 # Changes between versions
 
-## Not yet released
+## 0.4.0 (2017-09-12)
+
+* [BC BREAK][Doctrine] Change the type of Seo Columns from string(255) to text
+* [BC BREAK][Symfony] Remove Symfony Validator Asserts on Seo object
 
 ## 0.3.1 (2017-09-01)
 

src/Bridge/Doctrine/Resources/config/doctrine/Seo.orm.yml

@@ -3,36 +3,29 @@ Joli\SeoOverride\Bridge\Doctrine\Entity\Seo:
   fields:
     title:
       column: title
-      type: string
-      length: 255
+      type: text
       nullable: true
     description:
       column: description
-      type: string
-      length: 255
+      type: text
       nullable: true
     keywords:
       column: keywords
-      type: string
-      length: 255
+      type: text
       nullable: true
     robots:
       column: robots
-      type: string
-      length: 255
+      type: text
       nullable: true
     canonical:
       column: canonical
-      type: string
-      length: 255
+      type: text
       nullable: true
     ogTitle:
       column: og_title
-      type: string
-      length: 255
+      type: text
       nullable: true
     ogDescription:
       column: og_description
-      type: string
-      length: 255
+      type: text
       nullable: true

src/Bridge/Doctrine/Resources/config/doctrine/SeoOverride.orm.yml

@@ -13,8 +13,7 @@ Joli\SeoOverride\Bridge\Doctrine\Entity\SeoOverride:
   fields:
     path:
       column: path
-      type: string
-      length: 255
+      type: text
     domainAlias:
       column: domain_alias
       type: string

src/Bridge/Symfony/DataCollector/SeoOverrideDataCollector.php

@@ -58,7 +58,7 @@ public function getStatus()
 
     public function getStatusLabel()
     {
-        return $this->data['status'] === self::STATUS_MATCHED ? 'matched' : 'no match';
+        return self::STATUS_MATCHED === $this->data['status'] ? 'matched' : 'no match';
     }
 
     public function getVersions()

src/Bridge/Symfony/DependencyInjection/CompilerPass/RegisterFetcherPass.php

@@ -53,7 +53,7 @@ public function process(ContainerBuilder $container)
                 $optionNormalized = $this->camelize($option);
                 $index = array_search($optionNormalized, $arguments, true);
 
-                if ($index === false) {
+                if (false === $index) {
                     throw new LogicException(sprintf(
                         'Unkown "%s" option for fetcher "%s"',
                         $option,

src/Bridge/Symfony/Resources/config/validation.yml

@@ -31,7 +31,7 @@ public function __construct(SeoManagerInterface $seoManager)
 
     public function onKernelResponse(FilterResponseEvent $event)
     {
-        if ($event->getRequestType() === HttpKernelInterface::MASTER_REQUEST) {
+        if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) {
             $path = $event->getRequest()->getPathInfo();
             $domain = $event->getRequest()->getHost();