-
Notifications
You must be signed in to change notification settings - Fork 146
π fix: [email protected] always load main.jsbundle instead of thread bundleΒ #158
Copy link
Copy link
Open
Description
Hi! π
Firstly, thanks for your work on this project! π
Today I used patch-package to patch [email protected] for the project I'm working on.
Here is the diff that solved my problem:
diff --git a/node_modules/react-native-threads/ios/ThreadManager.m b/node_modules/react-native-threads/ios/ThreadManager.m
index 3aa1bba..f3b22aa 100644
--- a/node_modules/react-native-threads/ios/ThreadManager.m
+++ b/node_modules/react-native-threads/ios/ThreadManager.m
@@ -19,8 +19,15 @@ @implementation ThreadManager
}
int threadId = abs(arc4random());
+ NSURL *threadURL = NULL;
+
+ // NSURL *threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name fallbackResource:name];
+#if DEBUG
+ threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name];
+#else
+ threadURL = [[NSBundle mainBundle] URLForResource:name withExtension:@"jsbundle"];
+#endif
- NSURL *threadURL = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:name fallbackResource:name];
NSLog(@"starting Thread %@", [threadURL absoluteString]);
This issue body was partially generated by patch-package.
Metadata
Metadata
Assignees
Labels
No labels