Skip to content

Commit 3e90d91

Browse files
committed
chore: apply suggestions from extensions.gnome.org review
1 parent 46c0e7c commit 3e90d91

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

extension.js

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ const AareGuruIndicator = GObject.registerClass(
173173

174174
const settingsItem = new PopupMenu.PopupMenuItem(_(UI_STRINGS.SETTINGS));
175175
settingsItem.connect('activate', () => {
176-
this._openSettings();
176+
this.openPrferences();
177177
});
178178
this.menu.addMenuItem(settingsItem);
179179
}
@@ -374,24 +374,14 @@ const AareGuruIndicator = GObject.registerClass(
374374
);
375375
}
376376

377-
_openSettings() {
378-
try {
379-
const proc = Gio.Subprocess.new(
380-
['gnome-extensions', 'prefs', 'aareguru@jon4hz.io'],
381-
Gio.SubprocessFlags.NONE
382-
);
383-
} catch (error) {
384-
log(`Error opening settings: ${error.message}`);
385-
}
386-
}
387-
388377
destroy() {
389378
if (this._updateTimeout) {
390379
GLib.source_remove(this._updateTimeout);
391380
this._updateTimeout = null;
392381
}
393382

394383
if (this._httpSession) {
384+
this._httpSession.abort();
395385
this._httpSession = null;
396386
}
397387

metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"uuid": "aareguru@jon4hz.io",
33
"name": "Aare Guru",
4-
"description": "Display water temperature and flow information from Aare.guru API in your GNOME Shell panel",
4+
"description": "Display water temperature and flow information from aareguru.existenz.ch, the API for aare.guru, in your GNOME Shell panel",
55
"shell-version": ["45", "46", "47", "48"],
66
"version": "1.0.0",
77
"url": "https://github.com/jon4hz/gnome-shell-extension-aareguru",

0 commit comments

Comments
 (0)