Skip to content

Commit f8b7fd4

Browse files
authored
Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore (#105)
* Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore * adds reference to PR to the changelog
1 parent 7534740 commit f8b7fd4

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ project adheres to [Semantic Versioning](http://semver.org/).
77

88
## [Unreleased](https://github.com/dividab/tsconfig-paths-webpack-plugin/compare/v4.0.1...master)
99

10+
- Remove warning on missing baseUrl, which tsconfig-paths ^4.0.0 doesn't require anymore [#105](https://github.com/dividab/tsconfig-paths-webpack-plugin/pull/105).
11+
1012
## [4.0.1](https://github.com/dividab/tsconfig-paths-webpack-plugin/compare/v4.0.0...v4.0.1) - 2023-03-09
1113

1214
- Update tsconfig-paths [#103](https://github.com/dividab/tsconfig-paths-webpack-plugin/pull/103). Thanks to [@rippedspine](https://github.com/rippedspine) for this PR!

src/plugin.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -173,16 +173,6 @@ export class TsconfigPathsPlugin implements ResolvePluginInstance {
173173
return;
174174
}
175175

176-
const { baseUrl } = this;
177-
178-
if (!baseUrl) {
179-
// Nothing to do if there is no baseUrl
180-
this.log.logWarning(
181-
"tsconfig-paths-webpack-plugin: Found no baseUrl in tsconfig.json, not applying tsconfig-paths-webpack-plugin"
182-
);
183-
return;
184-
}
185-
186176
// The file system only exists when the plugin is in the resolve context. This means it's also properly placed in the resolve.plugins array.
187177
// If not, we should warn the user that this plugin should be placed in resolve.plugins and not the plugins array of the root config for example.
188178
// This should hopefully prevent issues like: https://github.com/dividab/tsconfig-paths-webpack-plugin/issues/9

0 commit comments

Comments
 (0)