f rename is_positive in schnorrsig module to has_square_y

Author: jonasnick

src/modules/schnorrsig/main_impl.h

@@ -77,8 +77,8 @@ int secp256k1_schnorrsig_sign(const secp256k1_context* ctx, secp256k1_schnorrsig
     secp256k1_ge_set_gej(&pk, &pkj);
 
     /* Because we are signing for a x-only pubkey, the secret key is negated
-     * before signing if the point corresponding to the secret key is not
-     * positive. */
+     * before signing if the point corresponding to the secret key does not
+     * have a square Y. */
     if (!secp256k1_fe_is_quad_var(&pk.y)) {
         secp256k1_scalar_negate(&x, &x);
     }

src/modules/schnorrsig/tests_impl.h

@@ -664,15 +664,15 @@ void test_schnorrsig_taproot(void) {
     secp256k1_xonly_pubkey output_pk;
     unsigned char output_pk_bytes[32];
     unsigned char tweak[32];
-    int is_positive;
+    int has_square_y;
     unsigned char msg[32];
     secp256k1_schnorrsig sig;
 
     /* Create output key */
     secp256k1_rand256(sk);
     CHECK(secp256k1_xonly_pubkey_create(ctx, &internal_pk, sk) == 1);
     memset(tweak, 1, sizeof(tweak));
-    CHECK(secp256k1_xonly_pubkey_tweak_add(ctx, &output_pk, &is_positive, &internal_pk, tweak) == 1);
+    CHECK(secp256k1_xonly_pubkey_tweak_add(ctx, &output_pk, &has_square_y, &internal_pk, tweak) == 1);
     CHECK(secp256k1_xonly_pubkey_serialize(ctx, output_pk_bytes, &output_pk) == 1);
 
     /* Key spend */
@@ -688,7 +688,7 @@ void test_schnorrsig_taproot(void) {
     /* Verify script spend */
     CHECK(secp256k1_xonly_pubkey_parse(ctx, &output_pk, output_pk_bytes) == 1);
     CHECK(secp256k1_xonly_pubkey_parse(ctx, &internal_pk, internal_pk_bytes) == 1);
-    CHECK(secp256k1_xonly_pubkey_tweak_verify(ctx, &output_pk, is_positive, &internal_pk, tweak) == 1);
+    CHECK(secp256k1_xonly_pubkey_tweak_verify(ctx, &output_pk, has_square_y, &internal_pk, tweak) == 1);
 }
 
 void run_schnorrsig_tests(void) {