Merge bitcoin-core#619: Clear a copied secret key after negation

gmaxwell · gmaxwell · commit 735fbde04e07 · 2019-05-16T08:38:30.000Z
069870d Clear a copied secret key after negation (Seonpyo Kim) Pull request description: It closes bitcoin-core#618 Tree-SHA512: 05299597c886c5d1a913fd0ce8c698d2e513eb80fbd33d571a02fc6910cfd337324c6f0f27175eaf125eb3478d38187763680e859ece9a469a034c9b8a8d6920
diff --git a/src/secp256k1.c b/src/secp256k1.c
@@ -457,6 +457,7 @@ int secp256k1_ec_privkey_negate(const secp256k1_context* ctx, unsigned char *sec
     secp256k1_scalar_negate(&sec, &sec);
     secp256k1_scalar_get_b32(seckey, &sec);
 
+    secp256k1_scalar_clear(&sec);
     return 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -457,6 +457,7 @@ int secp256k1_ec_privkey_negate(const secp256k1_context* ctx, unsigned char *sec`
`457`	`457`	`secp256k1_scalar_negate(&sec, &sec);`
`458`	`458`	`secp256k1_scalar_get_b32(seckey, &sec);`
`459`	`459`
	`460`	`+ secp256k1_scalar_clear(&sec);`
`460`	`461`	`return 1;`
`461`	`462`	`}`
`462`	`463`