f const casting

Author: jonasnick

src/modules/schnorrsig/main_impl.h

@@ -132,7 +132,7 @@ static int secp256k1_schnorrsig_real_verify(const secp256k1_context* ctx, secp25
 
     secp256k1_scalar_negate(&nege, e);
 
-    if (!secp256k1_pubkey_load(ctx, &pkp, (secp256k1_pubkey *) pk)) {
+    if (!secp256k1_pubkey_load(ctx, &pkp, (const secp256k1_pubkey *) pk)) {
         return 0;
     }
     secp256k1_gej_set_ge(&pkj, &pkp);
@@ -238,7 +238,7 @@ static int secp256k1_schnorrsig_verify_batch_ecmult_callback(secp256k1_scalar *s
         secp256k1_scalar_set_b32(sc, buf, NULL);
         secp256k1_scalar_mul(sc, sc, &ecmult_context->randomizer_cache[(idx / 2) % 2]);
 
-        if (!secp256k1_pubkey_load(ecmult_context->ctx, pt, (secp256k1_pubkey *) ecmult_context->pk[idx / 2])) {
+        if (!secp256k1_pubkey_load(ecmult_context->ctx, pt, (const secp256k1_pubkey *) ecmult_context->pk[idx / 2])) {
             return 0;
         }
     }
@@ -277,7 +277,7 @@ static int secp256k1_schnorrsig_verify_batch_init_randomizer(const secp256k1_con
          * xonly_pubkey serialization and a user would wrongly memcpy
          * normal secp256k1_pubkeys into xonly_pubkeys then the randomizer
          * would be the same for two different pubkeys. */
-        secp256k1_ec_pubkey_serialize(ctx, buf, &buflen, (secp256k1_pubkey *) pk[i], SECP256K1_EC_COMPRESSED);
+        secp256k1_ec_pubkey_serialize(ctx, buf, &buflen, (const secp256k1_pubkey *) pk[i], SECP256K1_EC_COMPRESSED);
         secp256k1_sha256_write(sha, buf, buflen);
     }
     ecmult_context->ctx = ctx;

src/secp256k1.c

@@ -785,7 +785,7 @@ int secp256k1_xonly_pubkey_serialize(const secp256k1_context* ctx, unsigned char
     ARG_CHECK(pubkey != NULL);
     ARG_CHECK(output32 != NULL);
 
-    if (!secp256k1_ec_pubkey_serialize(ctx, buf, &outputlen, (secp256k1_pubkey *) pubkey, SECP256K1_EC_COMPRESSED)) {
+    if (!secp256k1_ec_pubkey_serialize(ctx, buf, &outputlen, (const secp256k1_pubkey *) pubkey, SECP256K1_EC_COMPRESSED)) {
         return 0;
     }
     memcpy(output32, &buf[1], 32);
@@ -797,7 +797,7 @@ int secp256k1_xonly_pubkey_from_pubkey(const secp256k1_context* ctx, secp256k1_x
     ARG_CHECK(xonly_pubkey != NULL);
     ARG_CHECK(pubkey != NULL);
 
-    *xonly_pubkey = *(secp256k1_xonly_pubkey *) pubkey;
+    *xonly_pubkey = *(const secp256k1_xonly_pubkey *) pubkey;
 
     secp256k1_ec_pubkey_absolute(ctx, (secp256k1_pubkey *) xonly_pubkey, sign);
     return 1;
@@ -808,7 +808,7 @@ int secp256k1_xonly_pubkey_to_pubkey(const secp256k1_context* ctx, secp256k1_pub
     ARG_CHECK(pubkey != NULL);
     ARG_CHECK(xonly_pubkey != NULL);
 
-    *pubkey = *(secp256k1_pubkey *) xonly_pubkey;
+    *pubkey = *(const secp256k1_pubkey *) xonly_pubkey;
     if (sign) {
         return secp256k1_ec_pubkey_negate(ctx, pubkey);
     }
@@ -842,7 +842,7 @@ int secp256k1_xonly_pubkey_tweak_add(const secp256k1_context* ctx, secp256k1_pub
     ARG_CHECK(output_pubkey != NULL);
     ARG_CHECK(tweak32 != NULL);
 
-    *output_pubkey = *(secp256k1_pubkey *)internal_pubkey;
+    *output_pubkey = *(const secp256k1_pubkey *)internal_pubkey;
     return secp256k1_ec_pubkey_tweak_add(ctx, output_pubkey, tweak32);
 }