Fixing forbidden calls

Author: jonathan-buttner

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elastic/authorization/AuthorizationModel.java

@@ -150,9 +150,7 @@ private static AuthorizationResponseEntity.Configuration getConfigurationOrEmpty
         return AuthorizationResponseEntity.Configuration.EMPTY;
     }
 
-    private static Map<String, Object> getChunkingSettingsMap(
-        AuthorizationResponseEntity.Configuration configuration
-    ) {
+    private static Map<String, Object> getChunkingSettingsMap(AuthorizationResponseEntity.Configuration configuration) {
         return Objects.requireNonNullElse(configuration.chunkingSettings(), new HashMap<>());
     }
 
@@ -181,21 +179,9 @@ private static ElasticInferenceServiceDenseTextEmbeddingsModel createDenseTextEm
     }
 
     private static void validateConfigurationForTextEmbedding(AuthorizationResponseEntity.Configuration config) {
-        validateFieldPresent(
-            AuthorizationResponseEntity.Configuration.ELEMENT_TYPE,
-            config.elementType(),
-            TaskType.TEXT_EMBEDDING
-        );
-        validateFieldPresent(
-            AuthorizationResponseEntity.Configuration.DIMENSIONS,
-            config.dimensions(),
-            TaskType.TEXT_EMBEDDING
-        );
-        validateFieldPresent(
-            AuthorizationResponseEntity.Configuration.SIMILARITY,
-            config.similarity(),
-            TaskType.TEXT_EMBEDDING
-        );
+        validateFieldPresent(AuthorizationResponseEntity.Configuration.ELEMENT_TYPE, config.elementType(), TaskType.TEXT_EMBEDDING);
+        validateFieldPresent(AuthorizationResponseEntity.Configuration.DIMENSIONS, config.dimensions(), TaskType.TEXT_EMBEDDING);
+        validateFieldPresent(AuthorizationResponseEntity.Configuration.SIMILARITY, config.similarity(), TaskType.TEXT_EMBEDDING);
     }
 
     private static void validateFieldPresent(String field, Object fieldValue, TaskType taskType) {
@@ -206,14 +192,8 @@ private static void validateFieldPresent(String field, Object fieldValue, TaskTy
         }
     }
 
-    private static SimilarityMeasure getSimilarityMeasure(
-        AuthorizationResponseEntity.Configuration configuration
-    ) {
-        validateFieldPresent(
-            AuthorizationResponseEntity.Configuration.SIMILARITY,
-            configuration.similarity(),
-            TaskType.TEXT_EMBEDDING
-        );
+    private static SimilarityMeasure getSimilarityMeasure(AuthorizationResponseEntity.Configuration configuration) {
+        validateFieldPresent(AuthorizationResponseEntity.Configuration.SIMILARITY, configuration.similarity(), TaskType.TEXT_EMBEDDING);
 
         return SimilarityMeasure.fromString(configuration.similarity());
     }
@@ -288,7 +268,7 @@ public List<ElasticInferenceServiceModel> getEndpoints(Set<String> endpointIds)
 
     @Override
     public String toString() {
-        return String.format("AuthorizationModel{authorizedEndpoints=%s, taskTypes=%s}", authorizedEndpoints, taskTypes);
+        return Strings.format("AuthorizationModel{authorizedEndpoints=%s, taskTypes=%s}", authorizedEndpoints, taskTypes);
     }
 
     @Override