Skip to content

Commit af03b01

Browse files
committed
Cleaned up Dockerfile some more
1 parent 10a2017 commit af03b01

File tree

2 files changed

+18
-46
lines changed

2 files changed

+18
-46
lines changed

.devcontainer/Dockerfile

Lines changed: 16 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,25 @@
1-
FROM node:22.15.0-bookworm
1+
FROM node:23.10.0-bookworm
22

3+
ARG GIT_VERSION=2.49.0
34
ARG SF_CLI_VERSION=2.86.9
45
ARG SF_LWC_JEST_VERSION=7.0.1
5-
# ARG PRETTIER_VERSION=3.5.3
6-
# ARG PRETTIER_PLUGIN_APEX_VERSION=2.2.5
76

8-
# WORKDIR /workspaces/NebulaLogger
9-
10-
# Updates + locale setup
11-
RUN apt-get update && \
12-
apt-get install -y locales && \
13-
sed -i 's/^# *\(en_US.UTF-8\)/\1/' /etc/locale.gen && \
14-
locale-gen en_US.UTF-8 && \
15-
update-locale LANG=en_US.UTF-8
16-
ENV LANG=en_US.UTF-8
17-
ENV LANGUAGE=en_US:en
18-
ENV LC_ALL=en_US.UTF-8
19-
20-
# Set up npm dependencies (including sf CLI)
21-
# COPY package.json ./
22-
# COPY package-lock.json ./
23-
# COPY package*.json ./
24-
# RUN npm ci
25-
26-
# TODO new
27-
# RUN npm install --global @salesforce/cli@${SF_CLI_VERSION} \
28-
# && npm install --global @salesforce/sfdx-lwc-jest@${SF_LWC_JEST_VERSION} \
29-
# && npm install --global prettier@${PRETTIER_VERSION} \
30-
# && npm install --global prettier-plugin-apex@${PRETTIER_PLUGIN_APEX_VERSION}
7+
RUN apt-get update && apt-get install -y \
8+
gnupg \
9+
jq \
10+
locales \
11+
openssh-client \
12+
&& sed -i 's/^# *\(en_US.UTF-8\)/\1/' /etc/locale.gen \
13+
&& locale-gen en_US.UTF-8 \
14+
&& update-locale LANG=en_US.UTF-8
15+
ENV LANG=en_US.UTF-8 \
16+
LANGUAGE=en_US:en \
17+
LC_ALL=en_US.UTF-8
18+
19+
# Install & setup CLI - docs for environment variables: https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_dev_cli_env_variables.htm
3120
RUN npm install --global \
3221
@salesforce/cli@${SF_CLI_VERSION} \
3322
@salesforce/sfdx-lwc-jest@${SF_LWC_JEST_VERSION}
34-
# prettier@${PRETTIER_VERSION}
35-
# prettier-plugin-apex@${PRETTIER_PLUGIN_APEX_VERSION}
36-
# "@cparra/apexdocs": "1.13.7",
37-
# "@salesforce/cli": "^2.86.9",
38-
# "@salesforce/sfdx-lwc-jest": "^7.0.1",
39-
# "@types/jest-when": "^3.5.5",
40-
# "husky": "^9.1.7",
41-
# "jest-when": "^3.7.0",
42-
# "jsdoc-to-markdown": "^9.1.1",
43-
# "lint-staged": "^15.5.0",
44-
# "prettier": "^3.5.3",
45-
# "prettier-plugin-apex": "^2.2.5",
46-
# "pwsh": "^0.3.0"
47-
48-
# Now that the npm dependencies are installed locally via package.json, make global shortcuts for them
49-
# so they can be easily used within the devcontainer/VS Code.
50-
# RUN ln -s ./node_modules/.bin/prettier /usr/local/bin/prettier
51-
# RUN ln -s ./node_modules/.bin/sf /usr/local/bin/sf
52-
# sf CLI environment variables: https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_dev_cli_env_variables.htm
5323
ENV FORCE_SHOW_SPINNER=true \
5424
SF_DISABLE_AUTOUPDATE=true \
5525
SF_DISABLE_TELEMETRY=true \
@@ -78,4 +48,5 @@ ENV PATH="$JAVA_HOME/bin:$PATH"
7848

7949
# Set up Oh My Bash
8050
RUN bash -c "$(curl -fsSL https://raw.githubusercontent.com/ohmybash/oh-my-bash/master/tools/install.sh)" \
51+
# Another possible theme option: powerline-icon
8152
&& sed -i 's/OSH_THEME=.*/OSH_THEME="agnoster"/' ~/.bashrc

scripts/dev/devcontainer-post-start.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ if sf org display --json > /dev/null 2>&1; then
1313
sf lightning debug
1414
wait
1515

16-
./auto-log-fetcher.sh
16+
# SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
17+
# "$SCRIPT_DIR/auto-fetch-logs.sh"
1718
else
1819
echo "No default org set — skipping script."
1920
fi

0 commit comments

Comments
 (0)