Updated devcontainer config so all npm dev dependencies are baked into the image itself

Also switched to the official node image as the base docker image + upgraded to java v21

Author: jongpie

.devcontainer/Dockerfile

@@ -1,19 +1,44 @@
-FROM salesforce/cli:2.82.6-full
+FROM node:22.15.0-bookworm
+
+# https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_dev_cli_env_variables.htm
+# ENV SF_CONTAINER_MODE=true
+ENV SF_DISABLE_AUTOUPDATE=true
+ENV SF_DISABLE_TELEMETRY=true
+ENV SF_LOG_LEVEL=debug
+ENV SF_SKIP_NEW_VERSION_CHECK=true
+
+WORKDIR /workspaces/NebulaLogger
+
+# Setup npm dependencies (including sf CLI)
+COPY package.json ./
+COPY package-lock.json ./
+RUN npm ci
+
+# Now that the npm dependencies are installed locally via package.json, (re-)install some of them globally
+# so they can be easily used within the devcontainer/VS Code.
+RUN npm install -g @salesforce/cli@$(node -p "require('./package.json').devDependencies['@salesforce/cli']")
+RUN npm install -g prettier@$(node -p "require('./package.json').devDependencies['prettier']")
 
 # Set up sf plugins
 RUN mkdir $HOME/.config && mkdir $HOME/.config/sf \
-  # && echo '[ "@jongpie/sfdx-bummer-plugin", "jamessimone/sf-trace-plugin", "sf-trace-plugin" ]' > $HOME/.config/sf/unsignedPluginAllowList.json \
-  && echo '[ "@jongpie/sfdx-bummer-plugin" ]' > $HOME/.config/sf/unsignedPluginAllowList.json \
-  # TODO migrate all scripts (including in build.yml) to use
-  # the new code-analyzer plugin / eliminate sfdx-scanner
-  && sf plugins install code-analyzer@ \
-  # && sf plugins install @salesforce/sfdx-scanner \
+  # TODO revisit sf-trace-plugin install weirdness with @jamessimone
+  && echo '[ "@jongpie/sfdx-bummer-plugin", "jamessimone/sf-trace-plugin", "sf-trace-plugin" ]' > $HOME/.config/sf/unsignedPluginAllowList.json \
+  && sf plugins install code-analyzer \
+  && sf plugins install community \
+  && sf plugins install custom-metadata \
   && sf plugins install @jongpie/sfdx-bummer-plugin \
+  # I am still not clear why this is needed, but echo y is still needed here.
+  # Putting the plugin into the allow list (above) doesn't seem to work for some reason.
   && echo y | sf plugins install jamessimone/sf-trace-plugin
 
+# Set up Java
+RUN apt-get update && apt-get install -y curl zip unzip && \
+  curl -s "https://get.sdkman.io" | bash && \
+  bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && sdk install java 21-tem"
+
+ENV JAVA_HOME=/root/.sdkman/candidates/java/current
+ENV PATH="$JAVA_HOME/bin:$PATH"
+
 # Set up Oh My Bash
 RUN bash -c "$(curl -fsSL https://raw.githubusercontent.com/ohmybash/oh-my-bash/master/tools/install.sh)" \
   && sed -i 's/OSH_THEME=.*/OSH_THEME="agnoster"/' ~/.bashrc
-
-ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64
-ENV PATH=$JAVA_HOME/bin:$PATH

.devcontainer/devcontainer.json

@@ -1,18 +1,23 @@
 {
   "name": "Nebula Logger Dev Container",
+  "context": "..",
   "dockerFile": "Dockerfile",
   "features": {},
   "remoteUser": "root",
+  "workspaceFolder": "/workspaces/NebulaLogger",
+  "postCreateCommand": "chmod +x scripts/dev/devcontainer-post-start.sh",
+  "postStartCommand": "./scripts/dev/devcontainer-post-start.sh",
   "mounts": [
-    "source=${localWorkspaceFolder}/.npm,target=/home/vscode/.npm,type=bind",
-    "source=${localWorkspaceFolder}/.sf,target=/home/vscode/.sf,type=bind",
-    "source=${localWorkspaceFolder}/.sfdx,target=/home/vscode/.sfdx,type=bind"
+    "source=nebula-logger-dev-npm-cache,target=/root/.npm,type=volume",
+    "source=nebula-logger-dev-sf,target=/root/.sf,type=volume",
+    "source=nebula-logger-dev-sfdx,target=/root/.sfdx,type=volume"
   ],
-  "postCreateCommand": "npm ci",
   "customizations": {
     "vscode": {
       "settings": {
-        "codeAnalyzer.enableV5": true,
+        "codeAnalyzer.analyzeOnOpen.enabled": false,
+        "codeAnalyzer.normalizeSeverity.enabled": false,
+        "codeAnalyzer.scanner.engines": "pmd,retire-js,eslint-lwc",
         "editor.defaultFormatter": "esbenp.prettier-vscode",
         "editor.formatOnSave": true,
         "explorer.copyRelativePathSeparator": "/",
@@ -39,7 +44,7 @@
           "tags": false,
           "worktrees": false
         },
-        "salesforcedx-vscode-apex.java.home": "/usr/lib/jvm/java-11-openjdk-amd64",
+        "salesforcedx-vscode-apex.java.home": "/root/.sdkman/candidates/java/current",
         "salesforcedx-vscode-core.show-cli-success-msg": false,
         "terminal.integrated.defaultProfile.linux": "bash"
       },
@@ -54,6 +59,8 @@
         "github.vscode-github-actions",
         "github.vscode-pull-request-github",
         "gruntfuggly.todo-tree",
+        "janisdd.vscode-edit-csv",
+        "mechatroner.rainbow-csv",
         "mhutchie.git-graph",
         "modicatech.apex-code-coverage-visualizer",
         "ms-azuretools.vscode-docker",

scripts/dev/devcontainer-post-start.sh

@@ -0,0 +1,14 @@
+#!/bin/bash
+
+set -e
+
+if sf org display --json > /dev/null 2>&1; then
+  echo "Default org found, running startup script..."
+  sf apex trace
+  wait
+
+  sf lightning debug
+  wait
+else
+  echo "No default org set — skipping script."
+fi